Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp974346pxb; Tue, 9 Feb 2021 18:32:17 -0800 (PST) X-Google-Smtp-Source: ABdhPJyzHQ8JVK8H9NtSqAq415Ghux2ClKLeweWreO82KVfdOLDe9sH1BoWMlIkhnQ9KofaMAAqb X-Received: by 2002:a17:906:4f96:: with SMTP id o22mr642644eju.511.1612924336946; Tue, 09 Feb 2021 18:32:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612924336; cv=none; d=google.com; s=arc-20160816; b=UmeYsdNXPQe0khc83NJgU/QMNdy83/6V9SgJecafWbEays86Rc00ItXPh4G1nemzsM 4IqoyJJTXXx5I1RilP42gTgTEO22Nr0M/A18iQmFV4pTXIx0QAd+nP8UBn5fXy+yHw4E tLSswkfFdFo/KJ5MFhOI3Fw2OFpsknk1HY34eDYUGf0CRSELfqQ9yssogOJPrI9Cy5O0 xUIVFE8OyAEj8XEoMQ89jqmZ6ySPpdyiO1z7i8Ac/DRcf4a93E7R4E94SXundjtm+8ik B848dO6WSk/L3lR1BueVhd+Iuu9x0x3NGOs0qmZ7Q0iSxIIIdz4SIikKmGz524TfS/02 devg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=YWhGIQVbv2azk+PitXofSAwe/Rv5BoIc5lOEYkl3ba0=; b=Qhg1I/rrFg9rXeWYmLPnn/rYdgjLpyduyu8aNFwAVFjEHiAFUb8MvLXtgsO+2bnjH9 grG44D91tgsz2R61ZtvmIZ/lQPIA0VLVJQyaEanSsoIB3CGVT11UmJb26BWye6LGt1mc jDSJ7QZxwEDJNqsQB6DIVjBlOrxuGJz79puoqu2NkyUFMSEyYgpjP2dCFlEpTiaa5N0U uYGNd8JBEaJwfg4uRSc5HN02nFonu4SomUnDlP2oswHbtOpckbHQn28jXhHQlO0MpqR4 q3cLdUiyK3qHZhZJ8vggwc+2B8MYp62VGDCWf+0eUngaLvZOGVxU2ppzobOdMNFI7I8S dHAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t9si417740edd.589.2021.02.09.18.31.53; Tue, 09 Feb 2021 18:32:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235358AbhBJCbO (ORCPT + 99 others); Tue, 9 Feb 2021 21:31:14 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:59208 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235236AbhBJCFH (ORCPT ); Tue, 9 Feb 2021 21:05:07 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l9eri-005Dxe-0k; Wed, 10 Feb 2021 03:04:26 +0100 Date: Wed, 10 Feb 2021 03:04:26 +0100 From: Andrew Lunn To: Michael Walle Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski Subject: Re: [PATCH net-next 6/9] net: phy: icplus: don't set APS_EN bit on IP101G Message-ID: References: <20210209164051.18156-1-michael@walle.cc> <20210209164051.18156-7-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209164051.18156-7-michael@walle.cc> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 05:40:48PM +0100, Michael Walle wrote: > This bit is reserved as 'always-write-1'. While this is not a particular > error, because we are only setting it, guard it by checking the model to > prevent errors in the future. > > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew