Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RFC][PATCH v6 3/7] drm: ttm_pool: Rework ttm_pool_free_page to
 allow us to use it as a function pointer
To:     John Stultz <john.stultz@linaro.org>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        Daniel Vetter <daniel@ffwll.ch>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        Liam Mark <lmark@codeaurora.org>,
        Chris Goldsworthy <cgoldswo@codeaurora.org>,
        Laura Abbott <labbott@kernel.org>,
        Brian Starkey <Brian.Starkey@arm.com>,
        Hridya Valsaraju <hridya@google.com>,
        Suren Baghdasaryan <surenb@google.com>,
        Sandeep Patil <sspatil@google.com>,
        Daniel Mentz <danielmentz@google.com>,
        =?UTF-8?Q?=c3=98rjan_Eide?= <orjan.eide@arm.com>,
        Robin Murphy <robin.murphy@arm.com>,
        Ezequiel Garcia <ezequiel@collabora.com>,
        Simon Ser <contact@emersion.fr>,
        James Jones <jajones@nvidia.com>,
        linux-media <linux-media@vger.kernel.org>,
        dri-devel <dri-devel@lists.freedesktop.org>
References: <20210205080621.3102035-1-john.stultz@linaro.org>
 <20210205080621.3102035-4-john.stultz@linaro.org>
 <8a4cacb7-3042-53c7-02fe-de18cc49fc0e@amd.com>
 <CALAqxLX7KT8Zqv+qjpbiDzSLubvDgXz6Ayk_U_q5e0veweHcFw@mail.gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <884a5f8f-00e2-5aa6-6dfb-67e86c89e599@amd.com>
Date:   Tue, 9 Feb 2021 13:13:58 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <CALAqxLX7KT8Zqv+qjpbiDzSLubvDgXz6Ayk_U_q5e0veweHcFw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [IPv6:2a02:908:1252:fb60:444c:9a67:948b:2493] (2a02:908:1252:fb60:444c:9a67:948b:2493) by AM0PR10CA0122.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.20 via Frontend Transport; Tue, 9 Feb 2021 12:14:02 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 9f3af74b-497c-4f59-a002-08d8ccf4322c
X-MS-TrafficTypeDiagnostic: MN2PR12MB4813:
X-Microsoft-Antispam-PRVS: <MN2PR12MB481363BDFA3E836DCD13D610838E9@MN2PR12MB4813.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: EzyB6QbU6h2X3sCfTxb+bL9XpFV7rreUNgd598hY1I7heBkrKahSoACKGKgRE/DXUPOfluLXqfKdDidzNxeFP4tvc4f51Qf76Q/emXmy5NwOE2h/oBayZmh27vLGMUIGooc6iEhLobv/QR3lGeLpGRPm+c9k1QyKY4Iq1SCSE0olVmTL2CWuz4rXCnZuiViFpK1fibciObKwu5QnhkUg+jBOy8PMmLFeuTE3cU+5LP4e0up+/Sca3whTfbXXQYpb43tt0IUTVr3agVRd/UhdGwtJl03z7TVRmSjWVpkKaeMkBJwQXd+nTUpAUR0anjJmCPRUI6OEEAPcB9R5wOpMBMof8ni5GQWmYuH8OJFsjpnLmuB8dpM7ytPhmwj9ydjRygWEoa2zY28ZqinGG0kVtcIaC456dmXcVBGuHAztHuaDnnSUTlypH/7xNosn3XkZQmo3dzK5IKbiiMHTCHqudGEzun+d6L39xhSZfhCoNRcvQAE6HFvKvodxDzH08fUqA+av3mdgutu792gJK9P2Bk94J96SWZH4y+Cv0mQYrt1vK690cirEVRYlpFd6CBMmDCldz9aaJNEgoxzY1InysbITo9Tthj43KrXuq6++nYw=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN2PR12MB3775.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(136003)(39860400002)(396003)(376002)(346002)(52116002)(478600001)(31696002)(2616005)(16526019)(4326008)(5660300002)(8936002)(66574015)(6916009)(6486002)(36756003)(66946007)(6666004)(54906003)(31686004)(2906002)(8676002)(316002)(66556008)(7416002)(186003)(53546011)(66476007)(86362001)(43740500002)(45980500001);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?Z01CYTA1RUx4d2pXWDRoMDgwOEVjSXNLUkhVcjRyT3lhUEhPT0JUQ1RiVHph?=
 =?utf-8?B?RFVkTDZFQkZVQ09RUVIvV2J2aFgwUjVMVnBOU0FQZ3J2a3M0NndQbC9TbUpt?=
 =?utf-8?B?WStCS2xsZm5pUDF3L1h6VjBjaE5nUWZjTmRFaElSY0ppc3dXaDRrbDZUdk9m?=
 =?utf-8?B?YU05UFgza21wdzh5WUszWHI2S1JPOVZiNytkbU9TZGYwaGR0TVc2TFFTdEpB?=
 =?utf-8?B?SUlSeWg5NnIvZFgwOEIrbm9pZXMzUFR6NDNYVHJITmRXSHM1UU85dVZsa0hm?=
 =?utf-8?B?T01xZmVCYXdZRk82OGRuUG9TUFRubm5ZTUgyOW84ZHBWNmIycXU3bzdBdTY5?=
 =?utf-8?B?V1Qxb20xQTlEU2swb21FaFhWWnpWL3lPNk94ZVBkSEpML0E4M05zVDl4U3NU?=
 =?utf-8?B?Q3kxTGFUZXVKNHh6cXIxRGZKcHBZcjN0Z2U2R0dER0VQRmxBYnFXWEd4VkdP?=
 =?utf-8?B?TXdORnMySzEwWmJ6clBlZ3BGRjQ0WGkrTEVTcmlwdFN6djZZU2M4OFFNZWFw?=
 =?utf-8?B?NjVzajBzQ2xONlhqUDVvYi9VN3p1b3MvbHhVMkdZRWxaVmV6SXJZVEJXUFNG?=
 =?utf-8?B?dWtIbzRvN1h6MUI2cytBUHMvTGtaL1RrT3V3ZG82cFZzcklCdFlJV0UvL1J0?=
 =?utf-8?B?ZDQ5bURoeWtvYUtsTldleWo2S0ZpRndhQ1RySUtJNXp3ZGhHLy9RSVJ5WS8z?=
 =?utf-8?B?ZFYxNTFoTGFpQVNUcEJFMzlxdkdSRjZPd3BDa0xPZFh0SSs4S3lDSWhsNmxj?=
 =?utf-8?B?YmI2U1RRRkVQYnA1eVE2a09SOGkrblRoVmRRSWNMMEErR081SElNWHpPOGxT?=
 =?utf-8?B?QU9tWklTellneTZIWFNTSXNFajlXOW02MytDVVNHWnZzWGRzTFNZdjJ5M0xm?=
 =?utf-8?B?SmlDTVdVaWJLR1lQaUxhbUJOQTJSN3hhUDZIYlpPV2p5elRMd0hZNndVVHBC?=
 =?utf-8?B?TzlPeU5qczc4czVMYmlvYmxnTStmYTVWNUNBODNpZFF3dGwwbUhNTWoydDZt?=
 =?utf-8?B?VEFaSWNjY2huUnpEYjhHOWo5U1FkU0gxSmRCUDhtcmFvTFA5SnNNYWhEZ0o5?=
 =?utf-8?B?OE91TDNVa3BaUlduUHhpWXFrVXJXbVpsMjNmSjBqTnR5SVc3MW1BclRhR1RX?=
 =?utf-8?B?cGNTdzV4N1RaZk5PTUtoVExiTnlTbnNtWk9nVDkzM1J6WTdjckdUalUxOW5R?=
 =?utf-8?B?TmI5NjF6UkUxVlNCNGlwMVhpQUg1S1htbFVrSksvRGJWOFNLN0NXZFJWeHBk?=
 =?utf-8?B?L3FreWN0eG5HZHNvaHdsdDEwdGI1UmNXWHVQRk9VWGEwRzZOSzBKQmxRYldM?=
 =?utf-8?B?Mk54S2NFQ3Q4RFJ5dkw5c0dyZkRsSWRPcFNYQloxTVdSMlZKWmZRVlpVSUdG?=
 =?utf-8?B?RWlwM0VpbFRac2JOY3RRWENPeE9PbVg4T244Y1NCaXJ3d2NLZ05SVWdNN3VR?=
 =?utf-8?B?d3FwcU9TQ2lWNG5ybllmaGRPSnV5ZlBvd1ZxN2FyRmd5VUFQYnVaNi9qOXlv?=
 =?utf-8?B?S21hT3RocDlDelFBR2RyNTdwc09SVm1zZ29oc2UrbnN6SFN6MXlNVzVTaTNF?=
 =?utf-8?B?V0Y2T2t2alk3VUFFMERpcEJmRWUwZlpTQXFmN2ZoUTFPQUFwQmpJM3JhUHV3?=
 =?utf-8?B?Nk1FOThzbTcydjYrVTVkVThsOS9tcTZWOTFEeCtOREx3TGpSdklyWWxtQ0p5?=
 =?utf-8?B?R2xEVUptbjVmWE1WTSt4aVFvbUJPUVJzb0dNcDE5VzdnOXIvQURpK0pHdXdz?=
 =?utf-8?B?MmtoTEJvVWZtcDVZbFV1N1ZjQUg0M0ZjMWNpSUVHSlpuWUNzMkkycmNPQUJX?=
 =?utf-8?B?ejJnL2Zxb3g1NUdCNGsxbldDdEpqeHRLdWxyOHJybXk2enU4RkJTbkVIRlkz?=
 =?utf-8?Q?fvu++OaQ/w1Gq?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f3af74b-497c-4f59-a002-08d8ccf4322c
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB3775.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 12:14:06.5583
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lxXswcqV65Tm1vDmz56XCaUPm9MYQsKorEYKPWYI0ETUM81AhJsmMQBRzZqamhvQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4813
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Am 05.02.21 um 20:47 schrieb John Stultz:
> On Fri, Feb 5, 2021 at 12:28 AM Christian König
> <christian.koenig@amd.com> wrote:
>> Am 05.02.21 um 09:06 schrieb John Stultz:
>>> This refactors ttm_pool_free_page(), and by adding extra entries
>>> to ttm_pool_page_dat, we then use it for all allocations, which
>>> allows us to simplify the arguments needed to be passed to
>>> ttm_pool_free_page().
>> This is a clear NAK since the peer page data is just a workaround for
>> the DMA-API hack to grab pages from there.
>>
>> Adding this to all pages would increase the memory footprint drastically.
> Yea, that's a good point!  Hrm... bummer. I'll have to see if there's
> some other way I can get the needed context for the free from the
> generic page-pool side.

What exactly is the problem here? As far as I can see we just have the 
lru entry (list_head) and the pool.

How the lru is cast to the page can be completely pool implementation 
specific.

Regards,
Christian.

>
> Thanks so much for the review!
> -john