Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1054004pxb; Tue, 9 Feb 2021 21:36:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJyjwquuX/LC8n0x2UJrozSc70HiXvod1KGC5E/468IIySwD0+7lKNjw6C1vwetC9he/tfbz X-Received: by 2002:a17:906:4442:: with SMTP id i2mr1279426ejp.41.1612935379516; Tue, 09 Feb 2021 21:36:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612935379; cv=none; d=google.com; s=arc-20160816; b=LW2+aY75c1/Uvb5ehW3xzPcmpY8Xv1MfJSrH3vYi4NjSPRlBRpPczRl2n7ALHtOCw6 IaQ8ZEFPnmOHqvsNYNq5NOSjRUhyxE67quNNk5cI+T0AAVa4HcGc/67wx18mcQvhuvUg fwcflwxzbKten/EDkKgxSyYLNaQFMElSuamD6L6s7hjf2g7IFfaiBw1V04WPF+Do5LoO /FIeSzobY1u4H8pmPhzNv8v4ku/MtNcDGhe0nBPIfNzXXJg9A4QVpcqHeXejqvcktsr3 8antEdgTz2yyiZzLxLMJVDRqwa3xnqL5DbKd7xPGU4+PEfUGPR2AwaWVpLNGquBxPrRR RrxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=jWkC5nvDedOQcOGLRZAcnUf5BoS6QiBKxlVWMLT7CHM=; b=YnaUZ0qPuuN5q/UMJUQPN9MLPSIxTJaL5HcltHLSifGT024DponQsf/YTOHHetrWKW AJT1JWch5rfwgx6Ur9cJMCc8CSdx8eNAzB61TM+CxlbgR2X7e//4ycRvvTxcsfe/wRMQ +kb4eswwITca3pJcJlYtNLHS8v2CKtb5H+JsbKhcO2MR22gepShASRyt+gvh8lx0TJnz E1xyux0jNPCQbU//DxXkR3kuEMqVszm+cPo4RISupai8zRcM7mRFOTnDcky7zdPI+0Fo jKtZr46sMA28jhct6IfXqH1Jpe0fPFo5TmAj3FRC6OTJTfoLncpga9NSXLT/iRPJ1rU+ vvgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=QGqKYYWn; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=Cpkjvk2f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u4si642767ejy.552.2021.02.09.21.35.56; Tue, 09 Feb 2021 21:36:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=QGqKYYWn; dkim=neutral (no key) header.i=@linutronix.de header.s=2020e header.b=Cpkjvk2f; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232388AbhBIPNT (ORCPT + 99 others); Tue, 9 Feb 2021 10:13:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232069AbhBIPNR (ORCPT ); Tue, 9 Feb 2021 10:13:17 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 466BDC061786 for ; Tue, 9 Feb 2021 07:12:37 -0800 (PST) From: Thomas Gleixner DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1612883555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jWkC5nvDedOQcOGLRZAcnUf5BoS6QiBKxlVWMLT7CHM=; b=QGqKYYWnMA3mU43y2z7xvEqbZJbKvxBwkXGsBXae4OM90NZ3eGQqXWDM+E0OMOpsEBCzlh VJl5V67Wv3K8g73t9MZCDH8biIf1lXbgq3O6g6VrhR4Jr0P4kFiYOu3szJuxSb3kf9YToK nz6m5DusbGscbbWu5LyFha9CC4yH1AkTfqjBW+RdGUXF0Rd6wyWQZhZ5wSAja9MokHNo5C yuxYSGToLrJdbfSNLhjxEioTUe4sJsKFONt8x52y9KatkS4o37xnzSjfOKDwWrxMCOsB8I i9rrkxldIw4aEl+WUtFAaHl/Bly9+OBhVLWIABEh2Kj3oEhRWH2qyJYLpbG4Kg== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1612883555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=jWkC5nvDedOQcOGLRZAcnUf5BoS6QiBKxlVWMLT7CHM=; b=Cpkjvk2fNjX4Xz21a2VIDvEz8oMpKWvUynhgIyef9vNg4bOneDvTt78kMOq+YLuwL1ZwLJ on4hL77BsZcwcgBQ== To: Josh Poimboeuf Cc: LKML , x86@kernel.org, Kees Cook Subject: Re: [patch 05/12] x86/irq: Provide macro for inlining irq stack switching In-Reply-To: <20210208204209.yccd76j7sp2zbv37@treble> References: <20210204204903.350275743@linutronix.de> <20210204211154.618389756@linutronix.de> <20210208204209.yccd76j7sp2zbv37@treble> Date: Tue, 09 Feb 2021 16:12:33 +0100 Message-ID: <87zh0db7ha.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 08 2021 at 14:42, Josh Poimboeuf wrote: > On Thu, Feb 04, 2021 at 09:49:08PM +0100, Thomas Gleixner wrote: >> #ifdef CONFIG_X86_64 >> + >> +#ifdef CONFIG_UNWINDER_FRAME_POINTER >> +# define IRQSTACK_CALL_CONSTRAINT , ASM_CALL_CONSTRAINT >> +#else >> +# define IRQSTACK_CALL_CONSTRAINT >> +#endif > > Is this really needed? i.e. does ASM_CALL_CONSTRAINT actually affect > code generation with !FRAME_POINTER? The problem is that if the asm inline is the first operation in a function some compilers insert the asm inline before setting up the frame pointer. That's actualy irrelevant here as the compiler cannot reorder against the C code leading to the asm inline. So we can probably replace it with a big fat comment. Thanks, tglx