Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1117183pxb;
        Tue, 9 Feb 2021 23:54:59 -0800 (PST)
X-Google-Smtp-Source: ABdhPJylrJzGozG3ZDk43kiQQaFBk/kZIGzC/vBRxEeLZV6anj4YQcLtStBzd/3NbopN1Hqpz1Wn
X-Received: by 2002:aa7:c944:: with SMTP id h4mr1973280edt.233.1612943699515;
        Tue, 09 Feb 2021 23:54:59 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612943699; cv=none;
        d=google.com; s=arc-20160816;
        b=Ek8pN6xfO//vvesO46iNJeFNRQ+v9s7fBSrKQeoopSbOFbw4FFoATLNP9WHQkO4Jlu
         CR6Aa7twh1vO1CF3CB8jCQSNcG2mhwx+LvcQ/acfwPfb1b6rzpPP1N4W+oS4uba4Q/0i
         KpQu74S9GFBPbpwGIrN0YcVNydiqRVWAYk6/khzud0NglUDOPHNL7j0KJjGPB2ON6geI
         H+M82aT4Vi2/z4Lxqhl7HTsBRgbkDHp1igDuur4gmqFUP3Q43hhj9vS6sCUvbJjVvimB
         IPEwCO/DhpIJRnMMhrlT2XZcFEfUPkc+MRdr5rfTNtC1hNMdcvQpaU9Vd2u1roj6oTUS
         yfLQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=BdYavbqSygPuXE/vj/PdTFNJ7e77Yqxqw54eNCVzZ4U=;
        b=qwUk/ghei/VJadgaw1I3XidKBGrtqRQt2NNguppvBc+gF9W5O2e30f3UtH8imt+k2x
         22X1HVka/TM36ERaNkfnvTTF6+2ewpu8Shgj+EIfUEq2o2NpUDOXlS9Pfkv9zU4ZmJzk
         TvQxoSB8OteAQvRkTt4gmN3DAKjmL+ZSd+B83tDYnCBsb2T2j2dfieCLwakQqbStRvce
         LEnmkDJ66rbSuKPcqecwcp8951Um8YQ4zfoo3CeCrbizUZ4DzljQ89RFVSvrvHdrrrtj
         2fTmPSrWOAxiL8yUZuLc25KTnUqNyB61ZOBDZ/gaT2g132by+7ZQzY+H82lK755ARR8r
         2gHQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q9DTTvxw;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id t14si1007315edd.161.2021.02.09.23.54.35;
        Tue, 09 Feb 2021 23:54:59 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q9DTTvxw;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233727AbhBIUf6 (ORCPT <rfc822;llc123456a@gmail.com> + 99 others);
        Tue, 9 Feb 2021 15:35:58 -0500
Received: from mail.kernel.org ([198.145.29.99]:43200 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233361AbhBIS2k (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Feb 2021 13:28:40 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 1452364E31;
        Tue,  9 Feb 2021 18:26:08 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1612895169;
        bh=Jz0JK48Orafd4J5E+nIWTO9fcLP1eHH9cCNJvB2TVRM=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=q9DTTvxwKJbm+48jZi5HXxJRzw7e/k+3N/Q+mvB0nUOHnf8h2PfaLLjhN5uhbzBux
         5UBKFmokPgUl/0TrE4dij2n2wkMXljoK/V6pez2eCg12FLKmkrGTecD/XtW4NCPFDL
         EgBBJwsiT6iu1+ynXyyiVODUM0B+JOPG35JIOQjy/FpUtHdeJQS6fbG1FqyIkNDBOj
         l3yP58qruCmi0VMFwvga06hPyrYKndOOh8GDuCG11jjZXbSgsLY5toph+HWoXjUR//
         XCZY5s9OIz7yg2ZI/jW8HcXPl0se43x+/yNnjkDibmTGX90HE/B2BDWhjTK2b0Xgfo
         KXwXah1SoNRVw==
Date:   Tue, 9 Feb 2021 10:26:06 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <davem@davemloft.net>, <willemdebruijn.kernel@gmail.com>,
        <andrew@lunn.ch>, <sgoutham@marvell.com>, <lcherian@marvell.com>,
        <gakula@marvell.com>, <jerinj@marvell.com>, <sbhatta@marvell.com>
Subject: Re: [Patch v4 net-next 0/7] ethtool support for fec and link
 configuration
Message-ID: <20210209102606.5f3fd258@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <1612866931-79299-1-git-send-email-hkelam@marvell.com>
References: <1612866931-79299-1-git-send-email-hkelam@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:
> v4:
> 	- Corrected indentation issues
> 	- Use FEC_OFF if user requests for FEC_AUTO mode
> 	- Do not clear fec stats in case of user changes
> 	  fec mode
> 	- dont hide fec stats depending on interface mode
> 	  selection

What about making autoneg modes symmetric between set and get?