Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750940AbWIWEuK (ORCPT ); Sat, 23 Sep 2006 00:50:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750941AbWIWEuJ (ORCPT ); Sat, 23 Sep 2006 00:50:09 -0400 Received: from smtp.osdl.org ([65.172.181.4]:29154 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750933AbWIWEuH (ORCPT ); Sat, 23 Sep 2006 00:50:07 -0400 Date: Fri, 22 Sep 2006 21:50:00 -0700 From: Andrew Morton To: Auke Kok Cc: Holger Kiehl , linux-kernel , linux-net , netdev@vger.kernel.org, "Ronciak, John" Subject: Re: 2.6.1[78] page allocation failure. order:3, mode:0x20 Message-Id: <20060922215000.c1fde093.akpm@osdl.org> In-Reply-To: <4514190C.8010901@intel.com> References: <20060922004253.2e2e2612.akpm@osdl.org> <4514190C.8010901@intel.com> X-Mailer: Sylpheed version 2.2.7 (GTK+ 2.8.17; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 28 On Fri, 22 Sep 2006 10:10:36 -0700 Auke Kok wrote: > I wonder if we can't account for NET_IP_ALIGN when selecting bufsize, to get at > rid of at least 1 order size before we netdev_alloc_skb. This should make 9k > frames only kmalloc(16384) and thus stay within the 16k boundary. I hope. > > Completely untested: don't commit :) > I did - I think we want this patch. > > e1000: account for NET_IP_ALIGN when calculating bufsiz > > Account for NET_IP_ALIGN when requesting buffer sizes from netdev_alloc_skb to > reduce slab allocation by half. Could we please do whatever is needed to get this blessed and merged? This is such a common problem on such a common driver that I would suggest that we want this in 2.6.18.x as well. At least, I'd expect distributors to ship this fix (they're nuts if they don't) and so it makes sense to deliver it from kernel.org. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/