Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Feb 2021 12:27:18 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Yang Shi <shy828301@gmail.com>
CC:     <ktkhai@virtuozzo.com>, <vbabka@suse.cz>, <shakeelb@google.com>,
        <david@fromorbit.com>, <hannes@cmpxchg.org>, <mhocko@suse.com>,
        <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [v7 PATCH 02/12] mm: vmscan: consolidate shrinker_maps handling
 code
Message-ID: <20210209202718.GE524633@carbon.DHCP.thefacebook.com>
References: <20210209174646.1310591-1-shy828301@gmail.com>
 <20210209174646.1310591-3-shy828301@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210209174646.1310591-3-shy828301@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.DHCP.thefacebook.com (2620:10d:c090:400::5:ed49) by SJ0PR03CA0081.namprd03.prod.outlook.com (2603:10b6:a03:331::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.21 via Frontend Transport; Tue, 9 Feb 2021 20:27:21 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 75b520db-cdbf-40c7-39e3-08d8cd391ad8
X-MS-TrafficTypeDiagnostic: BYAPR15MB2758:
X-Microsoft-Antispam-PRVS: <BYAPR15MB2758ECC90DA9AE5E4F4DF90BBE8E9@BYAPR15MB2758.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:2958;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: tfe8eNt95ahD8LGRMzwamA3M55VjdTo4hRSsPAM8NGu1Wi9xfqWhXrCA5JeZk0LaKEI63Y+Z1EdZIC7yaA7hlEZch6esEaYa3UpRLvQ0bLuAhZ3yfjfMjOg76EZe6P2ZDKxIIfn40R/1ns3vhwY1McdeYwEy7HWrdLx5ThFN700mhQbuU9EabCJ9Mxtd7dBGPhm+q7eiq7u90xLPcpJ+55Y3FOvcCpk98nked1v93gNVTL0HxSMFAQAPeXWXhPm8eFx+9VPBFUpl0nWJo82rQKMUZbHrl3Wmr0KD6cr9p7XuOqYlj4LxORebu55JQkJbcMvpDQoDAy8jFwLVsENrROTyk++uMbUL2X9UyIoQkQxkj1w8K4POBHMGT597yKUNFTgsQO2xVK7jYXnSqaF50b3ra26+fTaCpNXH3OcBgFx2qIoNdX+J2ji0lVmU29bSdIEAxu7qDoZ0LwC5C1ZEqSDk6Y068yNoGp7ZQgiQCJwNkrCdTZdscDGl9q0D/BWEVsWTPRiZOG4X2twGcKPOLw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(366004)(396003)(136003)(39860400002)(8676002)(8936002)(52116002)(7696005)(478600001)(6506007)(9686003)(316002)(6916009)(16526019)(6666004)(86362001)(186003)(7416002)(55016002)(66476007)(2906002)(4326008)(66556008)(66946007)(33656002)(1076003)(5660300002)(4744005);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?WWDuhP0vELIdEsKzlhlVSJ2KYKkfptpFH20fkkWxb/spiTAnXOjiMSfmlSmk?=
 =?us-ascii?Q?/YIKO/ZroFTigxDamyABEtnht+bmngMXjK4d7sdQ0qi2gQzdhMJpWlbPUNWC?=
 =?us-ascii?Q?AmcjgSWF4a8BSZXvnX+R/ko9UFNzdyDTr41MDEMcgr+lOi8CCFPKmFqGT4g1?=
 =?us-ascii?Q?WE6tnXhk+EgeMhEloqnnXWr+i2PG/bViwavRm1GRo5S3ovie3mwXyJjMsLgU?=
 =?us-ascii?Q?Mlu8qap5xWS5Q6JtnIav2hgUR2xyA/zFTLZaO6PM6iKqFYWIQ7gdDiBMnl4x?=
 =?us-ascii?Q?8Iof+pZbD9+clSPKEerH0fKM/8xt+xET8Md5ha6uEuv0SXZz+StOAH2kWKLj?=
 =?us-ascii?Q?tQtnuRwqmqq/ChHYxGpWakgkbnRrzvfTDJo2S8S//9sFIPTAOyjecPoFLSaO?=
 =?us-ascii?Q?+nYCVJl/pwayuZtCU934NL2CoMUay0isMNPjEk4CT4sWoAeMWPPLplrSpY0d?=
 =?us-ascii?Q?c/DNoBxllfLCuFys9dauhwbiLwogjMQ+CLETN/9h+3X6vwDJWcMAQwInvYQh?=
 =?us-ascii?Q?XTk+G2q8ejQUQ4brP4+eVCwYTmnbUMsAG+RexkfiNoDys8XDGum4/kEOaOP9?=
 =?us-ascii?Q?M5G9+FVYH7G3xo0cQ/WcBhZ/MaGVNsQy3NzwXeCFZLNXdZnpkXyfJ7BO4YX9?=
 =?us-ascii?Q?GdsWMg4S+lgpcb055Rn3tXYhQwq45dDyih1oaVGh9MhazG7VpZQgi4iLbytj?=
 =?us-ascii?Q?Sw6UF5NDpBw6XjU2rr1q2A8jEY532s9/sKhLXWEWD7vaAOnNzs4s57cAdAHw?=
 =?us-ascii?Q?9/N1npYn1W4EyArm/3szyuZX9+EBVr/Rk8hSaCURoQWM87qtFQ2yS4SWiYGF?=
 =?us-ascii?Q?EBljHSFqjp7UrwU+u4Q3znRnNdrYirnqY9gd5B4yka++4y7MruBFVlg31/e3?=
 =?us-ascii?Q?nujLprt/esXC+jm5IVm9I00+wnE1gKQkHXDTK741SKs54GT5HMBuaLC51xTG?=
 =?us-ascii?Q?duGx+vTdQEG8xjw9DzlAEZ9svkRPG3Q0N9sfmqEtfki17kbbs7nWUfdpeQO9?=
 =?us-ascii?Q?c1rS52h9vFrzQ4TskOl8kjwupbd6OJTg7ajr4qoIe2gogjBirWmCF/MfBylI?=
 =?us-ascii?Q?DVbfuRDEC09umlO1qkIcMXvpt2w8ab40A+FGrYS2CMEr3bV3267RXrSHc4dw?=
 =?us-ascii?Q?qijLHqpfSESWbAiv69K5cysM17P19q4Gc+VEhOmWhkti+RkMyscg9NaagXlU?=
 =?us-ascii?Q?v/alkYkrXvUbQ5rDuA4vDMKjGdt4MhRfN73exPsKl6PzW/oDpOLRGvRV/xHY?=
 =?us-ascii?Q?kP6mJ4xUfdxsFx71EGLerRGR2HSVlms9QmLD+8RohhpqGKsaVAh+XhhzYmv3?=
 =?us-ascii?Q?uLkXR3oKohBiHiahURYnT61ToJ6fVmR+yeNHK+J3mHiTWg=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 75b520db-cdbf-40c7-39e3-08d8cd391ad8
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2021 20:27:22.2022
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: l61KqNROo7nA7mTS/0fDta14ZC7DYrgDtFZmCP/bzww9lNFpb4JW5OuUFDTIoKcw
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2758
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-09_06:2021-02-09,2021-02-09 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 suspectscore=0
 malwarescore=0 impostorscore=0 mlxlogscore=774 mlxscore=0
 priorityscore=1501 phishscore=0 spamscore=0 lowpriorityscore=0
 clxscore=1015 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2102090101
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 09, 2021 at 09:46:36AM -0800, Yang Shi wrote:
> The shrinker map management is not purely memcg specific, it is at the intersection
> between memory cgroup and shrinkers.  It's allocation and assignment of a structure,
> and the only memcg bit is the map is being stored in a memcg structure.  So move the
> shrinker_maps handling code into vmscan.c for tighter integration with shrinker code,
> and remove the "memcg_" prefix.  There is no functional change.
> 
> Acked-by: Vlastimil Babka <vbabka@suse.cz>
> Acked-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> Signed-off-by: Yang Shi <shy828301@gmail.com>

Acked-by: Roman Gushchin <guro@fb.com>

Thanks!