Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1133154pxb; Wed, 10 Feb 2021 00:26:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJxSc7btiMGxwGi5UcS4VqRC+nziUoTD6j3hWq0qgFw3RS3Nzw18UsTfl5EtJdk8SJNAxei0 X-Received: by 2002:a05:6402:786:: with SMTP id d6mr2126386edy.270.1612945563116; Wed, 10 Feb 2021 00:26:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612945563; cv=none; d=google.com; s=arc-20160816; b=U21C83PpqtTP1UUa1lahpwOjz/DfBWAi1kXhJ3HTjqaAIbMWkmjNZdbmn1Zmn2f6O6 GqldKkKH/RENtcBXhSg8o/9ghbeDe1KNrVlGHWqlqbGtIrbk2O8DIT1i+cRMPosk4Aup KHCCEeAHZp+hToDe66w+2QyrX7U3CvoBhSiPIyIZtvWgvP0+gn4ihA9i6j05W18dDUzh ErOCZ94ZMpWPEc7JATFtsG8eI5Wtevp3HR8VS2eKEz4PQoEFRqwUE+wuBADD+07Ajk3/ YLRiEZI6NS4MyU5F0FAD6m2tFvx713/HZgMtsSAP/SqqSDClAaxNI/3yNySFz5o4zL5V m1fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Hws10haiapCVdbuygVYLPsPV+zfJIrA6LcprPByFF7E=; b=C6v9r+VwmN2JH3QrtbtGAMlpQLlYmr7qqk6p0mrw8BYBzxRHkfG5MEyEUEKRnXr+aN VToj0WIHa5qiYNb1+CiW3EPHFHemuq3iRA2qS3LffR1piTlaO7BueMxRhslkkRcOuspE orqLqtwj/q0LFEpfiazA+sPw4T8h+aEP8h62kFDeWuO+K7ZdoqdsVYPCiFg1zBaibNtF Y5puxv+6AkxAjvi8Z7ILZ4T/q5tVErZXFty4myfdqbD1WRxONOkMlmPmrUefkcqI6ZW+ 9xPDknwejG48hvc8fGKnKrD5IHXtLtHj9JS0HrQV2hEt7+lj3jZ48z8xXSlmHkZ2jLVa VIBw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j16si852796ejm.573.2021.02.10.00.25.40; Wed, 10 Feb 2021 00:26:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230302AbhBJDRU (ORCPT + 99 others); Tue, 9 Feb 2021 22:17:20 -0500 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:6841 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229753AbhBJDRT (ORCPT ); Tue, 9 Feb 2021 22:17:19 -0500 Received: from spf.mail.chinamobile.com (unknown[172.16.121.11]) by rmmx-syy-dmz-app02-12002 (RichMail) with SMTP id 2ee2602350070c8-30d05; Wed, 10 Feb 2021 11:16:24 +0800 (CST) X-RM-TRANSID: 2ee2602350070c8-30d05 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from localhost.localdomain (unknown[223.112.105.130]) by rmsmtp-syy-appsvr06-12006 (RichMail) with SMTP id 2ee66023500448f-68b16; Wed, 10 Feb 2021 11:16:23 +0800 (CST) X-RM-TRANSID: 2ee66023500448f-68b16 From: Tang Bin To: clabbe@baylibre.com, herbert@gondor.apana.org.au, davem@davemloft.net Cc: linux-crypto@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, Tang Bin Subject: [PATCH] crypto: amlogic - Fix unnecessary check in meson_crypto_probe() Date: Wed, 10 Feb 2021 11:16:37 +0800 Message-Id: <20210210031637.19408-1-tangbin@cmss.chinamobile.com> X-Mailer: git-send-email 2.20.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function meson_crypto_probe() is only called with an openfirmware platform device. Therefore there is no need to check that the passed in device is NULL. Signed-off-by: Tang Bin --- drivers/crypto/amlogic/amlogic-gxl-core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c index 466552acb..468a16f62 100644 --- a/drivers/crypto/amlogic/amlogic-gxl-core.c +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c @@ -229,9 +229,6 @@ static int meson_crypto_probe(struct platform_device *pdev) struct meson_dev *mc; int err, i; - if (!pdev->dev.of_node) - return -ENODEV; - mc = devm_kzalloc(&pdev->dev, sizeof(*mc), GFP_KERNEL); if (!mc) return -ENOMEM; -- 2.20.1.windows.1