Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 4jbqIJd47mV347C5yniagTVO9AE3nQl8hDFdu39dOGfNdPZeQoIqqLL99EgSrK2B1zei9xzUJ8
 0cljFi/A2w7A==
IronPort-SDR: fHQvCnhlOtpRt/EKP5B3+VPI2dGSObwzKuNs0Lq9H3QS1KyzWTsijlzy8VHsMgSshoDPp1Ls93
 aUUTFNv06Ifw==
From:   "Kelley, Sean V" <sean.v.kelley@intel.com>
To:     "Zhuo, Qiuxu" <qiuxu.zhuo@intel.com>
CC:     Bjorn Helgaas <bhelgaas@google.com>,
        "Luck, Tony" <tony.luck@intel.com>, "Jin, Wen" <wen.jin@intel.com>,
        Linux PCI <linux-pci@vger.kernel.org>,
        "Linux List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP
 devices
Thread-Topic: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP
 devices
Thread-Index: AQHW/1Fz49ox/DonIU+F7sGLouNbVqpQzR2A
Date:   Wed, 10 Feb 2021 04:33:28 +0000
Message-ID: <131C9BC0-87C6-48EF-A07F-1B4537BD2671@intel.com>
References: <20210210020516.95292-1-qiuxu.zhuo@intel.com>
In-Reply-To: <20210210020516.95292-1-qiuxu.zhuo@intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <7BD697AE6BC7BB4186256437569B0F60@namprd11.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a55b57c3-b594-46cd-d44e-08d8cd7d03d0
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2021 04:33:29.0234
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DzrMOOxUqARinU0zCgEcXdsx97EZ4kb3N4GmHKCsAffGZ/nbQIl3BZaY55xts30Cxsih4KFAwvJbHo1DMr5dPA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5123
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Feb 9, 2021, at 6:05 PM, Qiuxu Zhuo <qiuxu.zhuo@intel.com> wrote:
>=20
> On a Sapphire Rapids server, it failed to inject correctable errors
> to the RCiEP device e8:02.0 which was associated with the RCEC device
> e8:00.4. See the following error log before applying the patch:
>=20
> aer-inject -s e8:02.0 examples/correctable
> Error: Failed to write, No such device
>=20
> This was because rcec_assoc_rciep() mistakenly used "rciep->devfn" as
> device number to check whether the corresponding bit was set in
> the RCiEPBitmap of the RCEC. So that the RCiEP device e8:02.0 wasn't
> linked to the RCEC and resulted in the above error.
>=20
> Fix it by using PCI_SLOT() to convert rciep->devfn to device number.
> Ensure that the RCiEP devices associated with the RCEC are linked to
> the RCEC as the RCEC is enumerated. After applying the patch, correctable
> errors can be injected to the RCiEP successfully.
>=20
> Reported-and-tested-by: Wen Jin <wen.jin@intel.com>
> Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>

Reviewed-by: Sean V Kelley <sean.v.kelley@intel.com>

Thanks,

Sean

> ---
> drivers/pci/pcie/rcec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/pci/pcie/rcec.c b/drivers/pci/pcie/rcec.c
> index 2c5c552994e4..d0bcd141ac9c 100644
> --- a/drivers/pci/pcie/rcec.c
> +++ b/drivers/pci/pcie/rcec.c
> @@ -32,7 +32,7 @@ static bool rcec_assoc_rciep(struct pci_dev *rcec, stru=
ct pci_dev *rciep)
>=20
> 	/* Same bus, so check bitmap */
> 	for_each_set_bit(devn, &bitmap, 32)
> -		if (devn =3D=3D rciep->devfn)
> +		if (devn =3D=3D PCI_SLOT(rciep->devfn))
> 			return true;
>=20
> 	return false;
> --=20
> 2.17.1
>=20