Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1137383pxb; Wed, 10 Feb 2021 00:34:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxIXQMRwjsAaMxhfflyZfNkbFdGbf+1u9s+gcc9lhdCgj+70jbd9/iLfrqgNcJu9UKZU+AU X-Received: by 2002:aa7:c80a:: with SMTP id a10mr2115129edt.141.1612946065287; Wed, 10 Feb 2021 00:34:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612946065; cv=none; d=google.com; s=arc-20160816; b=qN4+xs4lAFiuQAbc6tU7nJ6pyqCGs8rhBDz63FjEIIGw4tgYo17RMKcb8UppdUlyyE kX2HW2qEgp9NVY3KuzKMfR60umspqifxTpCUP/F6bWqC6rkFgjAonZQrKfVkNTF8f7tY qv1zK+srj958YCYVfSfCjrsZO2r2iRQqtOcbZqq8sU+gc7grz05hD+nwGYSZgCyggRCS kW+aQ7zzuHe/+5UI9j/p/8NRFtpM5O8uX/QT4RlXEJe1apKBdhPDRRspIHFoTK+kxc5a ZG4oq67RsOlE3OA2YZB/X5KZdniZ/4pV2mYVuDC3dwdA287tMxt2lCDWcVKvcaGgHSC6 P3Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:message-id:in-reply-to :date:references:subject:cc:to:from:dmarc-filter:sender :dkim-signature; bh=yA4uPCcjgumhOn0bEUKjVJ4BqtcWpZ83bZnHx4aWj0s=; b=VBozD/p2yhhjCaDXVwh+4xyXk5RELoQygekXr16bIAE2on8aiMPFV2K4vOYjz+iU/9 RQSddIgyc4uR6U7j8+zQtNBMd6Qn4SnVkWKtnKR4aqRIsvfpMjcXmQ8UE9AG/E1vmh4y 9sjiVpUeWAIZauFfJfyQqeV69PTENmSG78oK76/5BGmH2/P76rWQlXnr/1IAzPFOIqro scjp3QCBM68VesslOw+l8sKTnvCq5cVgr2VV2ixCDRLyOBXSOy0ioUO/fuDrM9np6KU4 MJYpHKO5HNZq+j2rTKOz2QivLoAF9Rk/sCd0wVWcVI7xaQY0thvL6rg2ZgoMb1yHN0c3 q61A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Q6rNZZtP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 96si953259edr.333.2021.02.10.00.34.01; Wed, 10 Feb 2021 00:34:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=Q6rNZZtP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231315AbhBJFTO (ORCPT + 99 others); Wed, 10 Feb 2021 00:19:14 -0500 Received: from so15.mailgun.net ([198.61.254.15]:18047 "EHLO so15.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231278AbhBJFTK (ORCPT ); Wed, 10 Feb 2021 00:19:10 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1612934347; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=yA4uPCcjgumhOn0bEUKjVJ4BqtcWpZ83bZnHx4aWj0s=; b=Q6rNZZtP/osBHZ+Sk+c425bct9i2+TxX7qF8N56N65rdGd4DRt/Qxyw2to4kZxdHApOhvGvl wCa/rXshxXHpZ+YK4QrEIb4zGoP578vzigyJ1rMO8lE2wCbATRG0HQPKetcOt/cton+W+9lk 8/CPu48pzP2RnuUAIRMcrixsPG4= X-Mailgun-Sending-Ip: 198.61.254.15 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60236c9c8e43a988b781a34b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 10 Feb 2021 05:18:20 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9E7F1C433C6; Wed, 10 Feb 2021 05:18:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id C8A4AC433C6; Wed, 10 Feb 2021 05:18:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org C8A4AC433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: "Rafael J. Wysocki" Cc: Paul McKenney , Linux PM , Peter Zijlstra , Frederic Weisbecker , "Rafael J. Wysocki" , LKML , ath10k@lists.infradead.org, Johannes Berg Subject: Re: WARNING: suspicious RCU usage (5.11.0-rc7+ #1812 Tainted: G) References: <2578278.ATerS0GEoy@kreacher> <877dnhv4lg.fsf@codeaurora.org> Date: Wed, 10 Feb 2021 07:18:13 +0200 In-Reply-To: (Rafael J. Wysocki's message of "Tue, 9 Feb 2021 18:44:21 +0100") Message-ID: <87pn18tsa2.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Rafael J. Wysocki" writes: >> > AFAICT that's a simple 'use RCU without holding rcu_read_lock' warning. >> > I've not dug through ath10k to see who should be doing rcu_read_lock, >> > but the few places I did look at don't seem to have changed recently. >> >> Just this morning I applied a patch which should fix this: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=ath-next&id=2615e3cdbd9c0e864f5906279c952a309871d225 >> >> Please let me know if it fixes the issue. > > The traces are gone after applying this patch, so it does help: > > Tested-by: Rafael J. Wysocki Good, thanks for testing. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches