Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <db5dd593cfd8b428ce44c1cce7484d887fa5e67c.1612869229.git.viresh.kumar@linaro.org>
In-Reply-To: <db5dd593cfd8b428ce44c1cce7484d887fa5e67c.1612869229.git.viresh.kumar@linaro.org>
From:   Jassi Brar <jassisinghbrar@gmail.com>
Date:   Wed, 10 Feb 2021 00:25:28 -0600
Message-ID: <CABb+yY3QkiZqWLJ8LmXXVy0n-UN1YxxbBOMcnTmHTe6WLeKmpA@mail.gmail.com>
Subject: Re: [PATCH Resend] mailbox: arm_mhuv2: Fix sparse warnings
To:     Viresh Kumar <viresh.kumar@linaro.org>
Cc:     Tushar Khandelwal <Tushar.Khandelwal@arm.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        kernel test robot <lkp@intel.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Feb 9, 2021 at 5:18 AM Viresh Kumar <viresh.kumar@linaro.org> wrote:
>
> This patch fixes a bunch of sparse warnings in the newly added arm_mhuv2
> driver.
>
> drivers/mailbox/arm_mhuv2.c:506:24: warning: incorrect type in argument 1 (different address spaces)
> drivers/mailbox/arm_mhuv2.c:506:24:    expected void const volatile [noderef] __iomem *addr
> drivers/mailbox/arm_mhuv2.c:506:24:    got unsigned int [usertype] *
> drivers/mailbox/arm_mhuv2.c:547:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/mailbox/arm_mhuv2.c:547:42:    expected unsigned int [usertype] *reg
> drivers/mailbox/arm_mhuv2.c:547:42:    got unsigned int [noderef] __iomem *
> drivers/mailbox/arm_mhuv2.c:625:42: warning: incorrect type in argument 2 (different address spaces)
> drivers/mailbox/arm_mhuv2.c:625:42:    expected unsigned int [usertype] *reg
> drivers/mailbox/arm_mhuv2.c:625:42:    got unsigned int [noderef] __iomem *
> drivers/mailbox/arm_mhuv2.c:972:24: warning: dereference of noderef expression
> drivers/mailbox/arm_mhuv2.c:973:22: warning: dereference of noderef expression
> drivers/mailbox/arm_mhuv2.c:993:25: warning: dereference of noderef expression
> drivers/mailbox/arm_mhuv2.c:1026:24: warning: dereference of noderef expression
> drivers/mailbox/arm_mhuv2.c:1027:22: warning: dereference of noderef expression
> drivers/mailbox/arm_mhuv2.c:1048:17: warning: dereference of noderef expression
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> Hi,
>
> This should have been merged to 5.11-rc since the driver got introduced
> in 5.11-rc1 itself. I don't see it queued for linux-next as well. It was
> posted over 6 weeks back and no response is received yet:
>
Yup any bug fix should be sent in rc. But this, imo, lies on the
boundary of code and cosmetic issues, so I practiced discretion to
keep it for the next pull request lest I won't have much to send ;)

> https://lore.kernel.org/lkml/db5dd593cfd8b428ce44c1cce7484d887fa5e67c.1609303304.git.viresh.kumar@linaro.org/
>
> Would be good if this can still go in 5.11.
>
Of course it will.

thanks.