Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1143223pxb; Wed, 10 Feb 2021 00:45:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJwmhBhENsRCsaRSlfRaqSzdhAQ2nddoyE0Tqo5rV3ZM3U7HaIXkElNDEnIhzisqq286vxvu X-Received: by 2002:a05:6402:1342:: with SMTP id y2mr2182150edw.105.1612946723710; Wed, 10 Feb 2021 00:45:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612946723; cv=none; d=google.com; s=arc-20160816; b=ldbgL59asuBaK3OLCD28UjLlVAECpUpTSkfS8+lgLXMbctsuEvx/8IYMxB7b4dmdyD BStminEHtjzYk27lyPAFYncthhjBPy5Bf1uWLBwMU4IBmDXFa5eUvxxZ61FEiagfkBVI j22z8G+GCxXoSEy+vTD6WEDUUvKOTubXkK6qCPL4u/B59zeRg27cVf07AejLdi4nug3l v1fYgIxRRpfNpQ/TqcZaxartSn2gm7PZ7EgQhhd03a3/LMonsK1E8oXPw5Zccoc3KPMI DI3RYAPXiYRpiqiwY7Fj0zqt4Oj8PQxEUU+iYhn/H9xf5Q1+cpYSYnfCvQmRe8EblakI WkLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rBkqkZTd5g9iMpheqnnUlGoR1nH7kXohQFG15Ej9IvU=; b=h9kdFnR/o/6wU38d8Iufkx2/hxWabsLxqK2R2k0jaOJAt1StqJ8DJS4x0Z3NnlxX0i F0l6Rr7fppTbBFotkwLYK9tnyoLG7+bfKorQO+yBt5khwWiK8p8ez94qBioBV2B/SfB3 xe8goeoYaUj4//HRUs4foF7arnUFcSJOkjHPs5fM9No5HsyZ4q0Zn+MDyHD5hJF3f5fO V+B5lA3XGm5TxxBWOknENE96jLPc30KzhQmwbnkiN25bK37yj60yob9xxJqaS7P+SAxM +Wwt9Iqu5wLUBo5AslXf9WqJemMdODqrSkgAewEdY6cV/YXRsg/Z6kmzYW0GFlCHq36C MjOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@beagleboard-org.20150623.gappssmtp.com header.s=20150623 header.b=AUxr9dYS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y16si999393edq.459.2021.02.10.00.45.00; Wed, 10 Feb 2021 00:45:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@beagleboard-org.20150623.gappssmtp.com header.s=20150623 header.b=AUxr9dYS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233074AbhBJHv5 (ORCPT + 99 others); Wed, 10 Feb 2021 02:51:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232939AbhBJHvV (ORCPT ); Wed, 10 Feb 2021 02:51:21 -0500 Received: from mail-pl1-x62d.google.com (mail-pl1-x62d.google.com [IPv6:2607:f8b0:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5626C061786 for ; Tue, 9 Feb 2021 23:50:41 -0800 (PST) Received: by mail-pl1-x62d.google.com with SMTP id e9so757827plh.3 for ; Tue, 09 Feb 2021 23:50:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=beagleboard-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rBkqkZTd5g9iMpheqnnUlGoR1nH7kXohQFG15Ej9IvU=; b=AUxr9dYSK65v0KhZ89C0z56tmdMSZYJOxt1oncONInfyHwDhNqMUNFxvNMKMjl06Np qa63EmhI+yIK+bATCe8ESWDSluJvRMKrAkVnZVgPDyc9Qu6HSIOR+XQWnFwX9uq0gE/0 mPottdu94hroAEIwnbltsnoOhx0u06q/FXhco/39hHBQzgCydMadUCt3Tr62B75XFqMU UnYUbHg6Z5tXxKDP30NdeSlsxvTplaS9BX7OhFPDvlNDr4oR27GVcBtj2xS7GJJGj4m5 rDnM0VOJIW/YXCO8LYx75PIfUP5qASxk6t3LpuY7zmR/vY69eq2lwr3tFrM7PHkAmwfo 1m7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rBkqkZTd5g9iMpheqnnUlGoR1nH7kXohQFG15Ej9IvU=; b=fkl6b2M78lxcl79+YYiK26eENRkMsukkF1EN3p3YpBkdJl50sCiyM/rWKFXTctEYeK mtQv8sqLfPEM2bIo0qLEt+z9S2DkHiuwAV/NckdxyPsAGolReEFG9xCXqjDVKDNUebip Y0r18LX5022LbR2TX8R2Q9Cyy7KwL19DBZN/ObdP7Q5aBzpOFVTj85drBlcRy0YEphmJ qjoNo8hISgW4kuqMfFsxbJ6dRvL3INHTk+8Gf1FeZCwV8hOE5iFmxsSjBFAlnaXCGOK3 lduIguXo2ZMWp00ieh+vnCYpWNQEDal+DGUBRinh9x8NuWX6dEYqsR1xLo5fCtpAuxxO MhCg== X-Gm-Message-State: AOAM532u36H9Gu3dRoxnrnxdCK2IgC75OoTEgbcHf1CDlOKsWZcwM3tU auHh1nUmwo/FMyoVf77ac3kAhA== X-Received: by 2002:a17:90b:4a02:: with SMTP id kk2mr1945395pjb.115.1612943441296; Tue, 09 Feb 2021 23:50:41 -0800 (PST) Received: from x1.hsd1.or.comcast.net ([2601:1c0:4701:ae70:7b19:df69:92d6:528e]) by smtp.gmail.com with ESMTPSA id b25sm1261710pfp.26.2021.02.09.23.50.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 23:50:40 -0800 (PST) From: Drew Fustini To: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Tony Lindgren , Andy Shevchenko , Alexandre Belloni , Geert Uytterhoeven , Pantelis Antoniou , Jason Kridner , Robert Nelson Cc: Drew Fustini Subject: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files Date: Tue, 9 Feb 2021 23:49:46 -0800 Message-Id: <20210210074946.155417-2-drew@beagleboard.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210210074946.155417-1-drew@beagleboard.org> References: <20210210074946.155417-1-drew@beagleboard.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c | 6 +++--- drivers/pinctrl/pinconf.c | 4 ++-- drivers/pinctrl/pinmux.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 3663d87f51a0..c9c28f653799 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -1914,11 +1914,11 @@ static void pinctrl_init_debugfs(void) return; } - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO, + debugfs_create_file("pinctrl-devices", 0400, debugfs_root, NULL, &pinctrl_devices_fops); - debugfs_create_file("pinctrl-maps", S_IFREG | S_IRUGO, + debugfs_create_file("pinctrl-maps", 0400, debugfs_root, NULL, &pinctrl_maps_fops); - debugfs_create_file("pinctrl-handles", S_IFREG | S_IRUGO, + debugfs_create_file("pinctrl-handles", 0400, debugfs_root, NULL, &pinctrl_fops); } diff --git a/drivers/pinctrl/pinconf.c b/drivers/pinctrl/pinconf.c index 02c075cc010b..f005921bb49e 100644 --- a/drivers/pinctrl/pinconf.c +++ b/drivers/pinctrl/pinconf.c @@ -370,9 +370,9 @@ DEFINE_SHOW_ATTRIBUTE(pinconf_groups); void pinconf_init_device_debugfs(struct dentry *devroot, struct pinctrl_dev *pctldev) { - debugfs_create_file("pinconf-pins", S_IFREG | S_IRUGO, + debugfs_create_file("pinconf-pins", 0400, devroot, pctldev, &pinconf_pins_fops); - debugfs_create_file("pinconf-groups", S_IFREG | S_IRUGO, + debugfs_create_file("pinconf-groups", 0400, devroot, pctldev, &pinconf_groups_fops); } diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index bab888fe3f8e..7f6190eaedbb 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -676,9 +676,9 @@ DEFINE_SHOW_ATTRIBUTE(pinmux_pins); void pinmux_init_device_debugfs(struct dentry *devroot, struct pinctrl_dev *pctldev) { - debugfs_create_file("pinmux-functions", S_IFREG | S_IRUGO, + debugfs_create_file("pinmux-functions", 0400, devroot, pctldev, &pinmux_functions_fops); - debugfs_create_file("pinmux-pins", S_IFREG | S_IRUGO, + debugfs_create_file("pinmux-pins", 0400, devroot, pctldev, &pinmux_pins_fops); } -- 2.25.1