Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1143233pxb; Wed, 10 Feb 2021 00:45:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJz9iACq693HDrbqO6VMT/vEXjBnHqiwve19QxL0FJaZWpbmdXjijuozKd2EzO/6N6Lidijp X-Received: by 2002:a17:906:128e:: with SMTP id k14mr1844951ejb.427.1612946725099; Wed, 10 Feb 2021 00:45:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612946725; cv=none; d=google.com; s=arc-20160816; b=q4Ok62/HKOBxCjIKkJsk1vMYtWpG1oVPWS9E5AbcBGPGpn9uqViDjdcQkFByX+tIRQ ylwLDSss05w/R7CkvONNxbOpcuHV9JA7xzL3jsU3tUYh24q3SH81146ytf2vrkzJDZQZ L0I+fKc7sSbOh9AnsyakMp7mr6u6R3JEqThBS1fDVsdOOldleIsij8Lg6yB+MWRZ9CiK tXGvmPv+yHUZWS1bB2XqqHLrmG5LryYdT1O2Vr+cGBZawJbgq0fbNLTJsE1Bq3o70El1 6MGbKGcqoyS56sA1lO+S/4K9LN8Iu2Zu4DWQeQcrb2y0uWyWIxLZ1mfn1SsUWdn1LWPT fbgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=YyBmWzIgaypHBOxLcBA8mGFFixbhc7oAYF/CjhB5HEw=; b=vZb2dHlLRq0NcNDdFJ0nzm0LVn1X7eYpn6hxz7P9qR7WoT3kSkFdiY8iGpA3eO+j6r InVJlEAKvOf4I23p+FT4/fUcHJvsZYZeNprBKnyqYbrK+DAfHSfx7mDfGYBgC0/dfSIb zP0rzCyYe2hmmmvt+NJu7JYpsNg4NzYPBC16NRNQ/RUDHkHy5ne5SYBy0BFTLSrM0Jz0 20BRvlNoQya5zFmLvZUR19eud2al2xO2K1Z03H6mqh4YzsrACCftIjpIJn1RGu0wlVLm rSbth8oMuP/iyZG81x46QxsTlUr+bNE6Wa8E8ctU5tdHnl4EQhHinS3WwV3VZaMFvPzU Eocw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c17si952849eds.438.2021.02.10.00.45.01; Wed, 10 Feb 2021 00:45:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232764AbhBJHio (ORCPT + 99 others); Wed, 10 Feb 2021 02:38:44 -0500 Received: from verein.lst.de ([213.95.11.211]:49660 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232484AbhBJHim (ORCPT ); Wed, 10 Feb 2021 02:38:42 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id EACAD67373; Wed, 10 Feb 2021 08:37:59 +0100 (CET) Date: Wed, 10 Feb 2021 08:37:59 +0100 From: Christoph Hellwig To: Filippo Sironi Cc: serebrin@amazon.com, dwmw@amazon.co.uk, benh@amazon.com, kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] nvme: Add 48-bit DMA address quirk for Amazon NVMe controllers Message-ID: <20210210073759.GA23269@lst.de> References: <20210203094338.19473-1-sironi@amazon.de> <20210210003942.25700-1-sironi@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210003942.25700-1-sironi@amazon.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 01:39:42AM +0100, Filippo Sironi wrote: > Amazon NVMe controllers do not support 64-bit DMA addresses; they are > limited to 48-bit DMA addresses. Let's add a quirk to ensure that we > make use of 48-bit DMA addresses to avoid misbehavior. This should probably say some, and mention that they do not follow the spec. But I can fix this up when applying the patch.