Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1143726pxb; Wed, 10 Feb 2021 00:46:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxcnLBMhWJ92o/vlddIQwua7XHV2J4+QTfDobJXDnCmLOQZTkGRjJ8/oR87xnLpo4+He+MH X-Received: by 2002:a17:906:b30b:: with SMTP id n11mr1966924ejz.116.1612946774767; Wed, 10 Feb 2021 00:46:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612946774; cv=none; d=google.com; s=arc-20160816; b=lthrAOZggnsu02E4+f/8NuvzsUPtjZvt9VrDqb6JVWas6/yYyuMeq1VMKouhXsn24M neg9saW/+A14aUbsfNfq1wz9GPLxZUTNWTY8U/w3uOWf3IMDfA7ywBbZZuqELFLpSe1U DDGR1dqA+xemlNbzTYES1nf2I25ye4CoCbXDqNiz0r+j1ZxpSXNtN9KztJ/sntvuDUZm U3Xa6cvHAGSYhu/SazqCx8oTOkWuiD4Wa2S47Pn13WYBMLC6BPaIDjIksuQDZ+Z+kOc6 gLzYwcbAfeb9yQVr98cMzs4M+b2b8iD4VFL8eeY5o0J7xBs6xXqwiVSfFOK5NSZOKcNW LJtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=HeS+tPvqcPkptiISv7//oKiNFkddcxYVm3AU5m2pdj8=; b=k1GofShc8HeLc277Bi6SgXMZa1aBc6lEhMDZjWwaHhhZ+zNgHNfM7TU+4Jlo3YVVIA g4PuSshim+tChb3BWwI2bx5kqL0FF9owoikvYD/zxVywsMjxasV2CfQL8iOyu3b0Ytg1 L0EDDJ65AqC5UeaqkkauCm3NOeX2miuvb3coXzMqUwxmri3ULimDdSmrxGF+pf5k/6Qv 3d7xaECdPgZ6lQxe4EVsHq/HOg+gcxnXL8W2qsZJV/mV+7iwwmhMXLb3DREuf025HVYR j+zX7wwkOEG0cuznHQW/qDFcauYqOW6qB1FKLaiBGbDFqp0MXQ5I6DaZn8x+gcctUFX0 Mpig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i15si908182edx.596.2021.02.10.00.45.51; Wed, 10 Feb 2021 00:46:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233153AbhBJHzu (ORCPT + 99 others); Wed, 10 Feb 2021 02:55:50 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:12533 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233145AbhBJHzr (ORCPT ); Wed, 10 Feb 2021 02:55:47 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DbBp73RJQzMQFV; Wed, 10 Feb 2021 15:53:19 +0800 (CST) Received: from huawei.com (10.175.104.175) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Wed, 10 Feb 2021 15:54:58 +0800 From: Miaohe Lin To: , CC: , , Subject: [PATCH] mm/hugetlb: remove redundant reservation check condition in alloc_huge_page() Date: Wed, 10 Feb 2021 02:54:43 -0500 Message-ID: <20210210075443.26238-1-linmiaohe@huawei.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.175] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If there is no reservation corresponding to a vma, map_chg is always != 0, i.e. we can not meet the condition where a vma does not have reservation while map_chg = 0. Signed-off-by: Miaohe Lin --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 4f2c92ddbca4..36c3646fa55f 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -2311,7 +2311,7 @@ struct page *alloc_huge_page(struct vm_area_struct *vma, /* If this allocation is not consuming a reservation, charge it now. */ - deferred_reserve = map_chg || avoid_reserve || !vma_resv_map(vma); + deferred_reserve = map_chg || avoid_reserve; if (deferred_reserve) { ret = hugetlb_cgroup_charge_cgroup_rsvd( idx, pages_per_huge_page(h), &h_cg); -- 2.19.1