Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1143738pxb;
        Wed, 10 Feb 2021 00:46:16 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxgTL3Er7NDXJhlZoPQyD6qDslCRw1CU8GXiFhvS+OMkY0h2s8c4+ILKM1x0ktkS/o2v0uZ
X-Received: by 2002:a17:906:5857:: with SMTP id h23mr1813467ejs.465.1612946776122;
        Wed, 10 Feb 2021 00:46:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612946776; cv=none;
        d=google.com; s=arc-20160816;
        b=REFL+1YjyI5HgEi4oNVsoSyE6T4fzmELGBSLJzxp7FnB/i14PUaKiLWVUcHScBo00u
         azrEGxWzaxYe3rAMMg8RuM96x5gL+X/ZtvkU0rlkf+fKP32mxg3Us4eYBEhqBm6IVaVG
         aIHEB9xa5BriXAJo9dJMbbrDQKwTYzlXzY6cRtk5WdhkniEPw1DxvNWBcctpd+YrHJYu
         tj+W3ZPjr6R599n7oyt3KtknZG/wQN+s8miRbsxv/MN9qk19n+89OtOiaAGXdG4A8NlZ
         a+Df1oFJZHoK10hOoYG+/9rX7HC9oA7jNHykGAf3l8fB3XwXQlcrEVSdnoTgNd5V5ieh
         FVmw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to
         :references:mime-version:dkim-signature;
        bh=VJiP6abJMM0Su6pGO5hZby/1O1e5TrK9ylS0T3dXchg=;
        b=nBFF/UFaES87Uyd91o6h4+fkTImzYrcDqaplbURlKbRT54Y5rj0e319e4uqx76Gswq
         8YsKn48M6x7VgCYqZHydWFEKOMizYI30vP+IRcDmNRdJNAensp5ry11VgYyOUkYccdJz
         qCxIPQRm1doPhestk/+BGQVdfTgay8UUxhgI+M2ADqN1OstZvZmKDNip75W8Z2YCVgk6
         DH9jv6qrM3bl5lwkCoWiSdcSS2gaDv0zlDMOkQCfttTOmJloHXZzMyVZYOtbhi7C+CDe
         9N1mrtTvBKkNzXyE8+tC/7h+TT4aTXWpaDje6u5oVxMP7cL8v02YUWIdpAIMpgbp8bYx
         T9Jg==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ro0LhPtO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r14si999811edw.243.2021.02.10.00.45.52;
        Wed, 10 Feb 2021 00:46:16 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Ro0LhPtO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S231611AbhBJIYa (ORCPT <rfc822;lnx4us@gmail.com> + 99 others);
        Wed, 10 Feb 2021 03:24:30 -0500
Received: from mail.kernel.org ([198.145.29.99]:47140 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233972AbhBJIYK (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Feb 2021 03:24:10 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E23064E3E;
        Wed, 10 Feb 2021 08:23:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1612945409;
        bh=VJiP6abJMM0Su6pGO5hZby/1O1e5TrK9ylS0T3dXchg=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=Ro0LhPtO3/RkuCZbLBlNIedsnLfyvIjyrCrQcrv/rd62fr8rYyE8wpglgI0xKSzp9
         3njnTgAMcyASVPxxH6qdZQc1YOnFdMeUWwowQcTHkFw1Kn2VCwBcq5ovZNLHSyVauj
         0OGSlYOWlDJtnGQeO2I8Kxl3izJDmCLxJouc+C0lI1Ix450e8NDwLCfKuPIhzAWLft
         nPY6rYOZMFQqPFUm6O2zllRUXvbAWT7oCtAhe3UvxWPVnnSw0kkGtQk14F9MIXey3t
         oa9XKOplMzdFn9vAl62Xmm5O3LMoAvttyqwR7I22a++7Q1wozjNgnx80YRORR2oiaH
         HhUOHotFhABFQ==
Received: by mail-ed1-f44.google.com with SMTP id y8so1829608ede.6;
        Wed, 10 Feb 2021 00:23:29 -0800 (PST)
X-Gm-Message-State: AOAM5330kHTI56FoC7g4og0Bma17mymD9qxwwH/hvuOmpRMhVAZucVkU
        rQ1xS4iz3qHf6akg4Tl1ElXpT2G3QccXIzqHdR8=
X-Received: by 2002:a05:6402:1484:: with SMTP id e4mr2165360edv.104.1612945407649;
 Wed, 10 Feb 2021 00:23:27 -0800 (PST)
MIME-Version: 1.0
References: <20210209230527.26712-1-r-rivera-matos@ti.com> <20210209230527.26712-2-r-rivera-matos@ti.com>
In-Reply-To: <20210209230527.26712-2-r-rivera-matos@ti.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Wed, 10 Feb 2021 09:23:15 +0100
X-Gmail-Original-Message-ID: <CAJKOXPeqd7iMU+gVC-xT-MY6YKXrB88gsCyd9M0NX=wCtyWrmA@mail.gmail.com>
Message-ID: <CAJKOXPeqd7iMU+gVC-xT-MY6YKXrB88gsCyd9M0NX=wCtyWrmA@mail.gmail.com>
Subject: Re: [PATCH 2/2] power: supply: bq25980: Moves properties from battery node
To:     Ricardo Rivera-Matos <r-rivera-matos@ti.com>
Cc:     sre@kernel.org, linux-pm@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 10 Feb 2021 at 00:52, Ricardo Rivera-Matos
<r-rivera-matos@ti.com> wrote:
>
> fix: exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT on the
>
> charger node

Why is this a fix? Why is exposing this property wrong? What is the
problem here? Why do you start sentences with a small letter? Your
commit message should answer such questions.

Best regards,
Krzysztof