Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20210210074554.81100-1-songyang@linux.alibaba.com>
References: <20210210074554.81100-1-songyang@linux.alibaba.com>
To:     Yang Song <songyang@linux.alibaba.com>
Cc:     dhowells@redhat.com, dwmw2@infradead.org, keyrings@vger.kernel.org,
        linux-kernel@vger.kernel.org, zhang.jia@linux.alibaba.com,
        tianjia.zhang@linux.alibaba.com
Subject: Re: [PATCH] sign-file: add openssl engine support
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <664915.1612945784.1@warthog.procyon.org.uk>
Content-Transfer-Encoding: quoted-printable
Date:   Wed, 10 Feb 2021 08:29:44 +0000
Message-ID: <664916.1612945784@warthog.procyon.org.uk>
Precedence: bulk

Yang Song <songyang@linux.alibaba.com> wrote:

> +		"Usage: scripts/sign-file [-edp] [<openssl engine>] <hash algo> <key>=
 <x509> <module> [<dest>]\n");

Do you mean:

		"Usage: scripts/sign-file [-dp] [-e <openssl engine>] <hash algo> <key> =
<x509> <module> [<dest>]\n");

> +		opt =3D getopt(argc, argv, "sedpk");

"se:dpk"?

> +		if (use_engine) {
> +			ossl_engine =3D argv[0];

use_engine ought to be a redundant variable.

David