Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Stefan Chulski <stefanc@marvell.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "thomas.petazzoni@bootlin.com" <thomas.petazzoni@bootlin.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Nadav Haklai <nadavh@marvell.com>,
        Yan Markman <ymarkman@marvell.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "mw@semihalf.com" <mw@semihalf.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        "atenart@kernel.org" <atenart@kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "sebastian.hesselbarth@gmail.com" <sebastian.hesselbarth@gmail.com>,
        "gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>
Subject: RE: [EXT] Re: [PATCH v11 net-next 15/15] net: mvpp2: add TX FC
 firmware check
Thread-Topic: [EXT] Re: [PATCH v11 net-next 15/15] net: mvpp2: add TX FC
 firmware check
Thread-Index: AQHW/sBBFbgpQQcn1kKFZbDyaw2oG6pQA9IAgAEWNfA=
Date:   Wed, 10 Feb 2021 09:05:24 +0000
Message-ID: <CO6PR18MB3873EB4FE57E1D35531AB5AFB08D9@CO6PR18MB3873.namprd18.prod.outlook.com>
References: <1612860151-12275-1-git-send-email-stefanc@marvell.com>
 <1612860151-12275-16-git-send-email-stefanc@marvell.com>
 <20210209162855.GQ1463@shell.armlinux.org.uk>
In-Reply-To: <20210209162855.GQ1463@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8872fd71-fc06-4c5f-b813-08d8cda3006e
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Feb 2021 09:05:24.2369
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ReLtRws93AeRGMqbaglQ2oar46976EAz8Lnx+ae0AZrdtwhB/fVOlyyk33/6zBtzTvQnLxPkw/C7SdL8PTQW+A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR18MB1216
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-10_02:2021-02-09,2021-02-10 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> >  	if (priv->global_tx_fc && priv->hw_version !=3D MVPP21) {
> > -		val =3D mvpp2_cm3_read(priv, MSS_FC_COM_REG);
> > -		val |=3D FLOW_CONTROL_ENABLE_BIT;
> > -		mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
> > +		err =3D mvpp2_enable_global_fc(priv);
> > +		if (err) {
> > +			dev_warn(&pdev->dev, "CM3 firmware not running,
> version should be higher than 18.09 ");
> > +			dev_warn(&pdev->dev, "and chip revision B0\n");
> > +			dev_warn(&pdev->dev, "Flow control not
> supported\n");
>=20
> I would much rather this was:
>=20
> 			dev_warn(&pdev->dev, "Minimum of CM3 firmware
> 18.09 and chip revision B0 required for flow control\n");
>=20
> rather than trying to split it across several kernel messages.

I would repots v12 with this change soon.

Thanks,
Stefan.