Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210208181157.1324550-1-paul@crapouillou.net> <20210208192902.GR920417@kernel.org>
In-Reply-To: <20210208192902.GR920417@kernel.org>
From:   Namhyung Kim <namhyung@kernel.org>
Date:   Wed, 10 Feb 2021 18:14:06 +0900
Message-ID: <CAM9d7ciG7p4KKTdLgHTUJHS03VpQuou8Ns3VWAZYB9S9kyr4nw@mail.gmail.com>
Subject: Re: [PATCH] perf stat: Use nftw() instead of ftw()
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Paul Cercueil <paul@crapouillou.net>, Jiri Olsa <jolsa@redhat.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        od@zcrc.me, linux-kernel <linux-kernel@vger.kernel.org>,
        "stable # 4 . 5" <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Tue, Feb 9, 2021 at 4:29 AM Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>
> Em Mon, Feb 08, 2021 at 06:11:57PM +0000, Paul Cercueil escreveu:
> > ftw() has been obsolete for about 12 years now.
> >
> > Fixes: bb1c15b60b98 ("perf stat: Support regex pattern in --for-each-cgroup")
> > CC: stable@vger.kernel.org
> > Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> > ---
> >
> > Notes:
> >     NOTE: Not runtime-tested, I have no idea what I need to do in perf
> >     to test this. But at least it compiles now with my uClibc-based
> >     toolchain.
>
> Seems safe from reading the nftw() man page, the only typeflag that this
> code is using is FTW_D and that is present in both ftw() and nftw().
>
> Applying,

Didn't notice it was obsolete.

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung