Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1195924pxb; Wed, 10 Feb 2021 02:29:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJw8BKURwvVAqH39mSQj7V/Kd1XNxqUhh726p2lYF+rn8suFQC8APRtu8iWrbmL2QAKUyp8l X-Received: by 2002:a17:907:2d92:: with SMTP id gt18mr2315431ejc.330.1612952975182; Wed, 10 Feb 2021 02:29:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612952975; cv=none; d=google.com; s=arc-20160816; b=awruoK2zBR5ZzZ+t3cHMYKct9sD67+/CTm2Aexru06RFXV5o4Nv7xydl02XHrICbSN Zkr+7K2gMqTU4WrrpG/k2xxmxuXeNsDiDfQZNRtPdkUmV4LCglIeEGqdpf8zlTlGgttA FU6pb4N4MsHOljGzvsWShicCTVKHWVd09v1RJs5EQXnG01QNZKrhGz78xD+DT73FN9yu OfRbwjqXXkFTS7r2gcGr2CDmqvMreGNC+hct/J9yebSA3DIEgDmPk4JAz8mbp45DMZUs rbpKNVFZEklmQ2hjjz0rrKgwjBVIcdwq5ggxRVvnpRJQK/OQmhRIsaAQc1JDmgOBgLDs E8LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=PVhJHa/rgaAmJAfvlPJfOaBn3MbkrcjvpDWK0tRQ/EQ=; b=q5GONWjqRgo2Ixht9CfX0j4j7GYy1sgim54JiXM7SXCJgtKGw5IPOmCXPrIeFJe24+ sW4KO81wEkdWFOqu7QRRrT1h9TmACBtcVuQLAsIcc/0+/hJO7S8O0vj/5pO3NDktJKOz 8hQfCLu7g73fpuuknVsaSCMouTAUrir1yBnRt2goXvf2XrDz3lXS35m2lBGLgkIi5176 exQVekNWm+ThiRHzpSNX5RBCfDdptNVKPdD/vjXJc/Qfn4kf5uBXUtV2FaaVmHcMFmDu Oz/NtznqFQIPJ43/8aC7GPLFnecC1KnpD4UpUc50NEU94zBNzpfj7uoszoAVbOjGoUFN tdkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DKVO8IBc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m15si1019837eje.225.2021.02.10.02.29.11; Wed, 10 Feb 2021 02:29:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=DKVO8IBc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231494AbhBJK2Q (ORCPT + 99 others); Wed, 10 Feb 2021 05:28:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbhBJKPq (ORCPT ); Wed, 10 Feb 2021 05:15:46 -0500 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF62AC061574; Wed, 10 Feb 2021 02:15:02 -0800 (PST) Received: by mail-pj1-x1031.google.com with SMTP id d2so866671pjs.4; Wed, 10 Feb 2021 02:15:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PVhJHa/rgaAmJAfvlPJfOaBn3MbkrcjvpDWK0tRQ/EQ=; b=DKVO8IBcFU2+FgXYqjp1Dx/v7yOULAP7DWqT+MrPb0vwwDnKZnpVpOQFW6DrUGyieu J5AJ6YBgBaAd6K1S3tIvKgvwcuiZMRQvS1Dh9U1x0o6HBV3UF4eLaRSE8vMDbPQgVDcD GBZnPsh4/Nqn61V4mTK+Re0yXoqs2drehzuLSzPt1HzGIa5/JiDSbzlk5ndgHz1q+hIP 0wZvxLwC3zNohGUHeqAMK88AvntasQXBOQIIOaIpm2gIbDdF4dvsgXY6ejjqMeyPI4k/ E+jI37XXHwn36BYRYziYPRxlzdwYvkL06susSE81W5TjJsmqfACEi8Hc7lI2j0cEqlwG nKOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PVhJHa/rgaAmJAfvlPJfOaBn3MbkrcjvpDWK0tRQ/EQ=; b=PcDaaDTn9gda4dR32fZW9rmXB0UMvApAWoU5Gzjx2Ux4gkVlD715dwB/4xpM++8FVq 1dQ0QLKAnxL99oYXfzfJeHQK0dNjM0zPzTKe1NWU5YiE3DL7n1zwncZK3+eH34T/qpNT l9l2fnFyAyaoJt/L7bWB1AmZXV1ceSQdYL320M4cjTV+XxJdTtLScASWsxL+TuKQaTtT YDkQdK0YqnmjJjL6MTG6XJHHQMh16KnFuBapEaTXn7bYLvRqY5kZ9zgC5yLDaXdQL/UJ kNXrcVYRj5YjjsmR7QV0xK+CofEAPbMD2R9wAvlN8N8MWQeYRT6mmXWalToEfwQqAuYB NkUA== X-Gm-Message-State: AOAM533phtzAgTmR6Hh7q+BmoZOYKWtmDVvC1KvSmZxOrhjwYxtM0h52 i0gjahTrtykNb6sLbdYGF9X4zjucadeVan2Rczo= X-Received: by 2002:a17:90a:c84:: with SMTP id v4mr2460269pja.228.1612952102177; Wed, 10 Feb 2021 02:15:02 -0800 (PST) MIME-Version: 1.0 References: <20210210074946.155417-1-drew@beagleboard.org> <20210210074946.155417-2-drew@beagleboard.org> In-Reply-To: From: Andy Shevchenko Date: Wed, 10 Feb 2021 12:14:46 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files To: Geert Uytterhoeven Cc: Drew Fustini , Linus Walleij , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Tony Lindgren , Alexandre Belloni , Pantelis Antoniou , Jason Kridner , Robert Nelson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 10:31 AM Geert Uytterhoeven wrote: > On Wed, Feb 10, 2021 at 8:50 AM Drew Fustini wrote: ... > > - debugfs_create_file("pinctrl-devices", S_IFREG | S_IRUGO, > > + debugfs_create_file("pinctrl-devices", 0400, > > What about the loss of S_IFREG? What do you mean? https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L387 -- With Best Regards, Andy Shevchenko