Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Feb 2021 10:34:41 +0000 (GMT)
From:   Alan Maguire <alan.maguire@oracle.com>
To:     Daniel Latypov <dlatypov@google.com>
cc:     brendanhiggins@google.com, davidgow@google.com,
        alan.maguire@oracle.com, linux-kernel@vger.kernel.org,
        kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
        skhan@linuxfoundation.org
Subject: Re: [PATCH v3 0/2] kunit: fail tests on UBSAN errors
In-Reply-To: <20210209221443.78812-1-dlatypov@google.com>
Message-ID: <alpine.LRH.2.23.451.2102101034050.25339@localhost>
References: <20210209221443.78812-1-dlatypov@google.com>
Content-Type: text/plain; charset=US-ASCII
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from localhost.localdomain (2a02:6900:8208:1848::16ae) by LO4P123CA0093.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:191::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17 via Frontend Transport; Wed, 10 Feb 2021 10:34:52 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d132b54b-a703-4d29-7141-08d8cdaf817b
X-MS-TrafficTypeDiagnostic: CO1PR10MB4435:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <CO1PR10MB4435D46785FA863D9C6A5C7CEF8D9@CO1PR10MB4435.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:2201;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1xY6HtWsIoc++smRY4udFEPZn1GxYTokAca0w1eOKcuMkW0IREVNn1HmLcDCv+olplK5OjO6JK713nB5SqlDAeB94CbICGOVmF1JH9jna5Uw3WZYv6lW3C5qXyHAmTRgDv9vh92SNM5P6JEAXLKzCW/zqs9Q+7GyIOOuYJiIkNnqKJMGZLwhO+0lJy+sf0klQ40D/CoXWVsklm5KyLBJeur4nCuJ5ST0jF3beFVupc7ow4p0PYS3EIho7hobAnUVIhwzXfKtremynsxBi+6tLn0MZvQy2mLXVf65PqDqs5hs/dXddTBuXPgydHXVY+9BTUARM1xHigdbmffku0dxS3zzpQshgtrXYFH8QyI8OFZRivIy5Zq4CIv8krGxJ3+n/1uw6BKGmQzs2TEqbM9/19Y03k4IuLRYeXyZNVEsFEBXgfNfZE3sUnPaek1UjmMMjE8p6CE3LzwCzWJfy/Kd27PhHOuNpwdK/eaZf7aUPNYDaHSCWlt84KKTTyvm/rvTgTf2KThrvZwOTJd4cL9yXjgYpux2FRRobVcg7AUtmyf+9roKGqBCgtp4pIrXv+2XsJXdQc5F71DHl5O0EDlKlarO+SdNzbBI+CfiNsu3obY=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CO1PR10MB4516.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(376002)(346002)(396003)(366004)(136003)(86362001)(478600001)(52116002)(66476007)(66556008)(66946007)(33716001)(83380400001)(6506007)(8936002)(16526019)(186003)(8676002)(44832011)(9686003)(6512007)(316002)(4744005)(2906002)(5660300002)(6916009)(9576002)(6666004)(6486002)(4326008)(966005);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?Ms9QxImd+jJC8As071udMGE4zFoZ1xIh166YJ/yMZOIVtV2GE1jFjL7qipKd?=
 =?us-ascii?Q?QBMVLtmdz8ssf3ynBitR2IbE5QKOotnGJP7wFLi4qxDt+TkIHzWSix59+NNX?=
 =?us-ascii?Q?2LZUZm7r0McbKb0DSnRLQEGcxlI5UtwifCK38gWN1Lz5UKTfCr4+lso+tV13?=
 =?us-ascii?Q?XEXI2D47fklVRcH6hYw79kx9C/ah9+HaTIWR7a4hzp/J/jbwnmaTaxESpayx?=
 =?us-ascii?Q?XE8R5qaUXa23SuwyuxZL/LL+tQ1UvdP5eQQAwaDogpt6FoVZFp1ml+kW72P/?=
 =?us-ascii?Q?cntq4jOHezkxmyL0n2H5STmDod6DBgmG74KJzniZqp/SG/f4uRmYD52zd/Qq?=
 =?us-ascii?Q?fKxQL+2m6Y/yKQySSMfX/+fYNjEPQpPXIjN+NaCDCjR+SiMkyuUTm34hzIqa?=
 =?us-ascii?Q?Jjpy1D+PilNfKCbr8mrHNroXsHQzDL9xTaCwZuKLjGnjRQiT/asnba2thpY/?=
 =?us-ascii?Q?3lOhJo5igN1vXQTwdvcIObo0Jp7IfaMBUzouSozozFvHvh2DX3xTl4W9XTtL?=
 =?us-ascii?Q?rZqJtFz0JW9x4Y9SI5jtoTaqiFcLjubAKTKzr755YggLBfObUmRhrTYy0kGL?=
 =?us-ascii?Q?AAk8iaeBUWQfq7kIHruYQ/Xe+2AoItaO8k2jrf1rDdogRoSLdrj+A6hy/NAJ?=
 =?us-ascii?Q?DveiO8bnarzwx9RSqa10nNHyU2G9YabuwoTILjJiw6wowYL0UMdv7hLLse10?=
 =?us-ascii?Q?7tQcJkraMhr04MdzRnrZSVateQny6/Dwl8kOvE9X2KtXQ6eELIUqj37uFT5s?=
 =?us-ascii?Q?2aBuDQr1tp+2109bS1b0EFzKEUfjjuf7H5Gtd23jJ4Y2J4TvR5cd8vAltypD?=
 =?us-ascii?Q?pF5b+VtJr7MFKVNhLw6oLf3ZnTOBWWVrqnmvwSvN939adhaeg0/CnWPog7Gp?=
 =?us-ascii?Q?QO7r5t0Boz1fO78SLJYAHkxf6mpDNT9zrqSRzhQ49RYdcZ0ykR//HPL3tEvM?=
 =?us-ascii?Q?k0D4rtOGA6iq2l+iE5LmcpLqfZKrv2BNGa6mn2JqoLcafB7pyp3unH9mVDtx?=
 =?us-ascii?Q?V8qvhd7AfMGuuKx4Q/PtkI4mn5DxVbq/N9LQVsVRTK4UjvN8YM11I+0XxSiu?=
 =?us-ascii?Q?mqIjv7n8O8u0aNQSBc1DAgK5BwUE92XdPCIYyQWEIGXj4nB1f2+zaWmLv3Dx?=
 =?us-ascii?Q?iL1VSr0Gafuu5V+s2UstBiNQEzGu01uiFspSgdvlu8sjOWKcKEm3M/CeI6fb?=
 =?us-ascii?Q?3F6q2RuWV2AnxREiFgyTiscpnHPyQ5ZTDcfQKPojGJDCaP4c40XwwZEbpFyQ?=
 =?us-ascii?Q?99h4MsAm/E0emo1irL6GlWxjv/mYizJvhRdNhOXB9hmOSWHiwjJxxgo1vCir?=
 =?us-ascii?Q?ffeFNpWy9uiPmgdl4eFbbAa5eE/WaG1trq8f4pGPokjM8rSHtxGRDSv/lS63?=
 =?us-ascii?Q?hbyUNJ8=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d132b54b-a703-4d29-7141-08d8cdaf817b
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4516.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2021 10:34:55.0128
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OqPpcy4Wp+wYG1T/73trJLFZBfCa0MNW3uux7D0UFsED4wsR+QWKWLwgIqYnhgY7YJDxkgWCQ1cYrYtd4BPq9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4435
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9890 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0
 mlxlogscore=999 malwarescore=0 bulkscore=0 phishscore=0 spamscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102100103
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9890 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 priorityscore=1501 bulkscore=0 spamscore=0 impostorscore=0 mlxscore=0
 suspectscore=0 mlxlogscore=999 adultscore=0 clxscore=1015
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2102100104
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On Tue, 9 Feb 2021, Daniel Latypov wrote:

> v1 by Uriel is here: [1].
> Since it's been a while, I've dropped the Reviewed-By's.
> 
> It depended on commit 83c4e7a0363b ("KUnit: KASAN Integration") which
> hadn't been merged yet, so that caused some kerfuffle with applying them
> previously and the series was reverted.
> 
> This revives the series but makes the kunit_fail_current_test() function
> take a format string and logs the file and line number of the failing
> code, addressing Alan Maguire's comments on the previous version.
> 
> As a result, the patch that makes UBSAN errors was tweaked slightly to
> include an error message.
> 
> v2 -> v3:
>   Fix kunit_fail_current_test() so it works w/ CONFIG_KUNIT=m
>   s/_/__ on the helper func to match others in test.c
> 
> [1] https://lore.kernel.org/linux-kselftest/20200806174326.3577537-1-urielguajardojr@gmail.com/
>

For the series:

Reviewed-by: Alan Maguire <alan.maguire@oracle.com>

Thanks!