Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dmaengine: ti: k3-udma: Fix NULL pointer dereference
 error
To:     =?UTF-8?Q?P=c3=a9ter_Ujfalusi?= <peter.ujfalusi@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Grygorii Strashko <grygorii.strashko@ti.com>,
        Vignesh Raghavendra <vigneshr@ti.com>
CC:     <dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210209120238.9476-1-kishon@ti.com>
 <8e9954cd-53fa-2c7e-2019-9821e5f9d45a@gmail.com>
From:   Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <30bfe6ef-de01-e019-d2d3-a999d6261fd8@ti.com>
Date:   Wed, 10 Feb 2021 17:04:39 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <8e9954cd-53fa-2c7e-2019-9821e5f9d45a@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Peter,

On 10/02/21 3:33 pm, Péter Ujfalusi wrote:
> Hi Kishon,
> 
> On 2/9/21 2:02 PM, Kishon Vijay Abraham I wrote:
>> bcdma_get_*() and udma_get_*() checks if bchan/rchan/tchan/rflow is
>> already allocated by checking if it has a NON NULL value. For the
>> error cases, bchan/rchan/tchan/rflow will have error value
>> and bcdma_get_*() and udma_get_*() considers this as already allocated
>> (PASS) since the error values are NON NULL. This results in
>> NULL pointer dereference error while de-referencing
>> bchan/rchan/tchan/rflow.
>>
>> Reset the value of bchan/rchan/tchan/rflow to NULL if the allocation
>> actually fails.
>>
>> Fixes: 017794739702 ("dmaengine: ti: k3-udma: Initial support for K3 BCDMA")
>> Fixes: 25dcb5dd7b7c ("dmaengine: ti: New driver for K3 UDMA")
>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> 
> Is this the same patch as the other with the similar subject?

Right, sorry for the duplicate patch (thought it didn't go out initially).

Regards
Kishon