Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Feb 2021 17:37:25 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Georgi Djakov <georgi.djakov@linaro.org>
Cc:     linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Andy Gross <agross@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Odelu Kukatla <okukatla@codeaurora.org>,
        linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT
 bindings
Message-ID: <20210210120725.GE2774@vkoul-mobl.Dlink>
References: <20210210104724.340991-1-vkoul@kernel.org>
 <30719cbd-6702-4b1e-2117-e5b8f11fd68d@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <30719cbd-6702-4b1e-2117-e5b8f11fd68d@linaro.org>
Precedence: bulk

Hi Gerogi,

On 10-02-21, 13:30, Georgi Djakov wrote:

> > +#define SM8350_MASTER_LLCC_DISP				1000
> > +#define SM8350_MASTER_MNOC_HF_MEM_NOC_DISP		1001
> > +#define SM8350_MASTER_MNOC_SF_MEM_NOC_DISP		1002
> > +#define SM8350_MASTER_MDP0_DISP				1003
> > +#define SM8350_MASTER_MDP1_DISP				1004
> > +#define SM8350_MASTER_ROTATOR_DISP			1005
> > +#define SM8350_SLAVE_EBI1_DISP				1512
> > +#define SM8350_SLAVE_LLCC_DISP				1513
> > +#define SM8350_SLAVE_MNOC_HF_MEM_NOC_DISP		1514
> > +#define SM8350_SLAVE_MNOC_SF_MEM_NOC_DISP		1515
> 
> Why are you using these big numbers? They are used as array indexes
> and we will be wasting a lot of memory for unnecessary large arrays.

Thanks for the explanation, yes that would be the case. I will split it
up and send v2

-- 
~Vinod