Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1257160pxb; Wed, 10 Feb 2021 04:15:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7EMHMmOOqDurOgP3GtoLdlwnnKJnW93SYzP7wUGv2485dsi6MeqnlMJSGl477dIG2IdIY X-Received: by 2002:a17:906:5e5a:: with SMTP id b26mr2531399eju.327.1612959334963; Wed, 10 Feb 2021 04:15:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612959334; cv=none; d=google.com; s=arc-20160816; b=kLxshFGEYutDcSG5zcfYlvZvM10m7vLw1SZX3Z7HOrlS2A0h6cqcHONCoX1c2C48Hu Ywxeml75PcFmu5212lfEmRvgvHbWGLRLOHJgt68zIN5r3w/4y6mfjsRlNmyyoEGI/Tlq lm7T3uW1+n72Uzk+Y460o5nCnt7Vdi5dSMx7So5gX3T4miISmrGlAWpg/VWW+Hj6bPGs N6SY+NIXfKYV7v0+Ar993ReEo/C23qfAHQ2084GyQsosqeplrD7nac2rxe1jAqyjLviU b2DSBj0NOj5TBDKuItsTQOAcGaO55wysC2uLxwi9V03FQgdMKFKzjYROm1Ad7TYMdYAD d8XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date; bh=mQP7U3QxeADWXw/Ee4nvazlyKRXYRAb7fDBM/svfgmk=; b=M9h0Y9miM2MsNJFNNYbDuC3MefTKHI6JZJ/8QCLu45NcEU1189Z7o8cBUIFRt3SVoG upXM1DrM9JMa1mw53T1U7JXh/sXHdeuU2Kd6kqkF+vVh+/y0h22YSFF/zuBEKJHm7Z/Q QNDuFHz5GJYfTgWcgITYOS/vJLSTqcvptv9PJVJrlDFpd6OarUGYRI/lmvgkmLqm8W3L PgRAquSi1GmSL9rojMY+X8PDxFcSjzTmsN2CXD0Qxa6d7VLTelEmcVDH3XUQRrOJ3Y/Z PVh7msWsx3Lmys+K0s1glusOLX0wRNdT+hb7FPRnPU7xXkj3L5DccI124ZdWC/KGAG5c CEqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s8si1074876ejd.111.2021.02.10.04.15.11; Wed, 10 Feb 2021 04:15:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231470AbhBJMMQ (ORCPT + 99 others); Wed, 10 Feb 2021 07:12:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:43852 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231599AbhBJMJY (ORCPT ); Wed, 10 Feb 2021 07:09:24 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 378B0AFBF; Wed, 10 Feb 2021 12:08:40 +0000 (UTC) Date: Wed, 10 Feb 2021 13:08:39 +0100 (CET) From: Miroslav Benes To: Dan Carpenter cc: Jessica Yu , Christoph Hellwig , Petr Mladek , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] module: potential uninitialized return in module_kallsyms_on_each_symbol() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Feb 2021, Dan Carpenter wrote: > Smatch complains that: > > kernel/module.c:4472 module_kallsyms_on_each_symbol() > error: uninitialized symbol 'ret'. > > This warning looks like it could be correct if the &modules list is > empty. > > Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol") > Signed-off-by: Dan Carpenter Reviewed-by: Miroslav Benes M