Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1262601pxb; Wed, 10 Feb 2021 04:23:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyrijb0tESzpZJJ2k4ox1kCLxyQP4glmXKsYxlm14xVtH1z55f+buiHSfMwmJu6Gi7RhTJ+ X-Received: by 2002:a05:6402:b86:: with SMTP id cf6mr3002788edb.66.1612959839102; Wed, 10 Feb 2021 04:23:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612959839; cv=none; d=google.com; s=arc-20160816; b=yq5ZqFIS2ETcyUzKZ1Mmo9pWPQemdMKbUj5Gq+2H+HwFXex7PpeuoD4v0PFKhjQqW6 rvu2IEXnpSUGxyjbI+pNhi/X8ph/+fGb8T3f/7d92qPq/F/GVE0aL0Pa7nmu5g39Ywxk DcVDV3IRiink5LCetrym4HFX+RuFJDi/yYgPmI+47QKZntDB0wLCtWV2+uNI/d0I+mDi 2hvTInBrr68L17kwtNIDhla6kI/CiyfjTlIgZS1H5UwYTvSUulDNrRgB6nIpcplLMl3b PU1Aj6ofCDq5Z/JvjGESjvLWcUtg3B3Sn1nGn0NJDIkjIfn2JbvNUiHdQHth8+740mmk PLUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RSSYx5ZKyLwSH2WY20S360SzVHoate5hhIssdRM7i4w=; b=IBb3LWrYS4HxqJXmm6qKl4BjcVIZPknixuGPBq7A3qZDBsybMISp0N5RTc6ap7zxBy BBh4Kl7WbB3HjHVzZEB4zqFhsHJWYAPcL8k+HzNZyPpxtxbiKjrPHci6b7ykQR8EKWrK 4vhNIhhwyKdQlGNmyZFaOk4FxoBpfDzEw54yO9krXWL8SdmX+DeqU5zgwQshO2RFqV2Z BvOK3ds/ka6FM3krlJCu5H5+S8LUDrh7zsWDQjGp16XRBLA/sdM57sc5crXp0OaWmT6T WGoG5hrotXoXTChndTxFwoi4bh6S60/da5mDHJVH5Ko/RYlr0YV4AHM2pB4QcsnXMJHj WU0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=PePQVMmU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h22si1133062eje.389.2021.02.10.04.23.35; Wed, 10 Feb 2021 04:23:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=PePQVMmU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231626AbhBJMXE (ORCPT + 99 others); Wed, 10 Feb 2021 07:23:04 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:57232 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231220AbhBJMUR (ORCPT ); Wed, 10 Feb 2021 07:20:17 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11ACFIJj117957; Wed, 10 Feb 2021 12:19:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=RSSYx5ZKyLwSH2WY20S360SzVHoate5hhIssdRM7i4w=; b=PePQVMmURpS+XLsy2yNWWMLPwxopuGErm8HDwg+7rysPqfu+Fc3eNsM8ba93ZfXUzTWT WOdg00F3KBIBf/arngjQ+PXREcvrC15p2xfBkJClXR8UhfqKO+CLCLQYiDmquMUjsura jNZkX+O8nQfmB49VMuvDch6E/irvkCBxe2s6HmS6SsEshzPpz2xerlNsq+5Y56VZNnMc 2P//T/MIqf/Oy9y6x4qYPgKP5eVcheLS3hWAn56D+k9PrzYB5xkDVbPug0c/bO/HBNbe DszITgMQe2V0NAVJNpapEiGNrxQaXQD2CPCjACbJ6GBXGFbmH2y8GZeWcJzA00tx7YMN fg== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 36m4upsnum-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Feb 2021 12:19:26 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 11ACEg1c074049; Wed, 10 Feb 2021 12:19:24 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 36j4vsqyj9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Feb 2021 12:19:24 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 11ACJNjJ008895; Wed, 10 Feb 2021 12:19:23 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 10 Feb 2021 04:19:22 -0800 Date: Wed, 10 Feb 2021 15:19:16 +0300 From: Dan Carpenter To: Aakash Hemadri Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, Shuah Khan Subject: Re: [PATCH] staging: ralink-gdma: Fix checkpatch.pl CHECK Message-ID: <20210210121915.GX2696@kadam> References: <20210210120348.262328-1-aakashhemadri123@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210120348.262328-1-aakashhemadri123@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9890 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 mlxlogscore=999 mlxscore=0 suspectscore=0 malwarescore=0 phishscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102100120 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9890 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 mlxscore=0 mlxlogscore=999 spamscore=0 impostorscore=0 malwarescore=0 clxscore=1011 suspectscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102100120 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 05:33:48PM +0530, Aakash Hemadri wrote: > Remove CHECK: Lines should not end with a '(' > > Signed-off-by: Aakash Hemadri > --- > > drivers/staging/ralink-gdma/ralink-gdma.c | 28 ++++++++++++----------- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c > index 655df317d0ee..a11f915f3308 100644 > --- a/drivers/staging/ralink-gdma/ralink-gdma.c > +++ b/drivers/staging/ralink-gdma/ralink-gdma.c > @@ -135,8 +135,7 @@ struct gdma_data { > int (*start_transfer)(struct gdma_dmaengine_chan *chan); > }; > > -static struct gdma_dma_dev *gdma_dma_chan_get_dev( > - struct gdma_dmaengine_chan *chan) > +static struct gdma_dma_dev *gdma_dma_chan_get_dev(struct gdma_dmaengine_chan *chan) > { > return container_of(chan->vchan.chan.device, struct gdma_dma_dev, > ddev); > @@ -510,10 +509,11 @@ static void gdma_dma_issue_pending(struct dma_chan *c) > spin_unlock_irqrestore(&chan->vchan.lock, flags); > } > > -static struct dma_async_tx_descriptor *gdma_dma_prep_slave_sg( > - struct dma_chan *c, struct scatterlist *sgl, > - unsigned int sg_len, enum dma_transfer_direction direction, > - unsigned long flags, void *context) > +static struct dma_async_tx_descriptor > + *gdma_dma_prep_slave_sg(struct dma_chan *c, struct scatterlist *sgl, Don't do it like this... The original code is better so, I guess, lets leave it as is. There are two accepted ways to start a function in the kernel: ONE: static type function_name(paramenters) TWO static type function_name(paramenters) Either option will let you grep for the names of the functions: egrep "^[a-zA-Z]" dir/file.c | grep '(' regards, dan carpenter