Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Schwab <schwab@linux-m68k.org>
To:     Palmer Dabbelt <palmer@dabbelt.com>
Cc:     devicetree@vger.kernel.org, aou@eecs.berkeley.edu,
        anup@brainfault.org, Palmer Dabbelt <palmerdabbelt@google.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        yash.shah@sifive.com, robh+dt@kernel.org, sagar.kadam@sifive.com,
        Paul Walmsley <paul.walmsley@sifive.com>,
        linux-riscv@lists.infradead.org, kernel-team@android.com
Subject: Re: [PATCH] Revert "dts: phy: add GPIO number and active state used
 for phy reset"
References: <20210205034112.2147142-1-palmer@dabbelt.com>
Date:   Wed, 10 Feb 2021 13:47:34 +0100
In-Reply-To: <20210205034112.2147142-1-palmer@dabbelt.com> (Palmer Dabbelt's
        message of "Thu, 4 Feb 2021 19:41:12 -0800")
Message-ID: <877dngjdi1.fsf@igel.home>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.91 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Feb 04 2021, Palmer Dabbelt wrote:

> From: Palmer Dabbelt <palmerdabbelt@google.com>
>
> VSC8541 phys need a special reset sequence, which the driver doesn't
> currentlny support.  As a result enabling the reset via GPIO essentially
> guarnteees that the device won't work correctly.
>
> This reverts commit a0fa9d727043da2238432471e85de0bdb8a8df65.
>
> Fixes: a0fa9d727043 ("dts: phy: add GPIO number and active state used for phy reset")
> Cc: stable@vger.kernel.org
> Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>

This fixes ethernet on the HiFive Unleashed with 5.10.12.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."