Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1281999pxb; Wed, 10 Feb 2021 04:58:39 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwWZMznilif5CqijObj4nZf+mqihLz57VqgYiF+hBK9j0EbI2UWPfZ68h0zS8Zp+qs8YmH X-Received: by 2002:a17:906:f0d0:: with SMTP id dk16mr2762095ejb.533.1612961919305; Wed, 10 Feb 2021 04:58:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612961919; cv=none; d=google.com; s=arc-20160816; b=zMjqcWUFAqp316QzRV4mneL0zJg1Vg1876CiI0O+QaXzxdxp9+aslgfxOT1Juf74Ni RifurugLeuxqZ3kou7+hsY8/tXa7aHsmrVoLLU+/j/strgq9WivX52Xa7ZWodErEIfnL VBCK80pr/1Seg5DOlqxJ5v05JZfDPu0U1u0igtm65HOj1WbiyvuUMKD7C/LDcfZlK54g G6/Q13rSFgp0mfFNXjgCslAxKUifDM0wdcQvzfpYpeiraWZfPx+Wo6P8jh8MAN1PePEr b8+cCixamV1aCTQAc2lPsH5xG6le8PosxpqzYfj5k22GUabIFV/Us5uXv4vQ9zjl+G8S pKOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=InazGvHrAmHBOnyPWm5jXswJnvdDfNBNTEI6Fmej6wM=; b=xy7+/O0ExzqeUie6XG778kBKr9JpQWT++jubtEXMM6qVrCg30W+CLqTHc7np7zcJ9/ NklD0iRi7auGs6rN2tWbekXY+izSzRjX8Db1cUpwabCXGmx6mb1gPraYpBsAxDkIs7wR JDvNCZKtX1IiKPMDoH9fPSXglXmTL5LBnThpZUAMamvyjkJfBqL0j3qH0mlGWkhN9t3e 5gIEJwD0IHM8YSvz9zUGds7tLjJ9FZ/GHIkPdknBtO6ekV+5idcga8AL4pJXlWhlivb7 kqkBEdGha5Z+R3bm95CDe4yq9J5f/sR2QN039gMxa+MoYtB5PbNQfFp1dSDu61XhJBQv bTjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=uCXRc4gQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q10si1266099edb.606.2021.02.10.04.58.15; Wed, 10 Feb 2021 04:58:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=uCXRc4gQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230489AbhBJM4Y (ORCPT + 99 others); Wed, 10 Feb 2021 07:56:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231253AbhBJMzv (ORCPT ); Wed, 10 Feb 2021 07:55:51 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF229C061574; Wed, 10 Feb 2021 04:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=InazGvHrAmHBOnyPWm5jXswJnvdDfNBNTEI6Fmej6wM=; b=uCXRc4gQuDm+LXMV2yoxL5+31M R/7zP8DbLcxMmV4BnIF5NEohwBzFUR0YWPm0ndnIOTfFQkNWiYHVr1Eo6AHiPgi3+K21vdyQ3ioyN Q0nTY6VqjC7tTavy3mLL2dlJZEaOBCiQ4YBKl3OjqQPP1DddjTPTsZYIoveuZgDQH9LpRAuOlxMPW wxxRYbnpWJBCBcOcBztiaEivp+t7LcCdfGCAfQgcGgvKdW3hLs3GPqlGHi2HLQvCt92e2pvSgMFUU Kb9Iq9vPqxm5cG2UukCMfUD27tJCsTUrCbYS4dFGhhvTrZb4ZYefuy4uoXJ5SuTDWCKnPaS6J7XYE AFKATlAg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l9p1K-008rWU-Iz; Wed, 10 Feb 2021 12:55:02 +0000 Date: Wed, 10 Feb 2021 12:55:02 +0000 From: Christoph Hellwig To: ira.weiny@intel.com Cc: Andrew Morton , David Sterba , Christoph Hellwig , Matthew Wilcox , clm@fb.com, josef@toxicpanda.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls Message-ID: <20210210125502.GD2111784@infradead.org> References: <20210210062221.3023586-1-ira.weiny@intel.com> <20210210062221.3023586-5-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210062221.3023586-5-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 10:22:17PM -0800, ira.weiny@intel.com wrote: > From: Ira Weiny > > Add VM_BUG_ON bounds checks to ensure the newly lifted and created page > memory operations do not result in corrupted data in neighbor pages and > to make them consistent with zero_user().[1][2] s/VM_BUG_ON/BUG_ON/g ? Otherwise looks good: Reviewed-by: Christoph Hellwig