Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1283995pxb; Wed, 10 Feb 2021 05:01:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwiscKbl1SKmGNiOgvtRPoX7ZkkKCcqWFZTBlk1TOGzprrA+IXnXJ/Q93XXqwwa56afpizx X-Received: by 2002:aa7:c901:: with SMTP id b1mr2995406edt.329.1612962108179; Wed, 10 Feb 2021 05:01:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612962108; cv=none; d=google.com; s=arc-20160816; b=QdDYCMkDKA7Z08HEcD4O0DVW3IAfjuUmVmSyKqh95M47fowyX2KJArM0XudN/G+jXw rUj6zYbP+LeSNEA4jDYU0pdShaZBRg/nt9PM017OP1qP7fwR4Y1RVuAkeiHX8YZx9ttH C9Wwpqy6f9SYpnQrrjAmh+MYJHyYiY29efxTV0bgKmjDssRJyAa051aEET4rEjhnvTLm h4dckcMCgcLH9ywWQrTAhVWvrfK+pq7X+PfvXu+yGdX8oEeMkysWZF3qh6n8uJAUH25W CFOsq9lEObxYv/sVcdj1YXL6JXF6gBv0eIvH6QjodchOBryKo1AYxJPH0WqX+BmOTzUr hzIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SGAIOBNUj9OSbPY+0bXagC3zuJ1Bdm0CDwlnEQirSc8=; b=g/DrEaYnGKPu3VVcQAfxlRSd+DSO9clmLO/FIZSaI9DLFOoxCTN8rX32C7ms9OVVxb WDeKTxeoInM/PxyQT7PTV+Qz17BckjD53sBNqrSv7XIRjrBI0psxc0rM4DzkFK0dWcIf kHH8bS3frhaHT5QLTxUurtUsfls/oA3LMzX1M4V6nc9AoXi6YZx2ygv2qkljT0qaO4Bd pga3R1qP0/bAaTqwk5oiinvFsgLYIxoVakyvsEA1Pler+ZfQcD4Hg3oFN50QcADEURTP syK8t52h5zjDsdzy7SgJFwONTC3P4m/lCiozEx4QYt8a7akF1UTbFkAXswYtczspO+k6 eNcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dTyIUjcN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ly19si1225617ejb.16.2021.02.10.05.01.23; Wed, 10 Feb 2021 05:01:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=dTyIUjcN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231569AbhBJNAx (ORCPT + 99 others); Wed, 10 Feb 2021 08:00:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231580AbhBJM5n (ORCPT ); Wed, 10 Feb 2021 07:57:43 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31DD8C0613D6; Wed, 10 Feb 2021 04:55:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=SGAIOBNUj9OSbPY+0bXagC3zuJ1Bdm0CDwlnEQirSc8=; b=dTyIUjcND5JzcCbae6DADZuxLV YRHONEqUMaoeAue709YkIlt0BqtQBFeTVJ09TUmIqwsOu3NKdS5w9PaeQr6CdCBMIronvbntDra2+ a+yCx0+cEmW7KJhE10v2CiN2VejC1AYdJk4/o4iATgZPxMe+Xh0XlmuivMZdsvvTiTrn8tp6EerkN i68GQBrxVqh9Abuw+LuqRuazFxlfeEWEDwDUywaULX4/u1N69b07WBjw0RX07KGcPZwOD8Q1NTF4y BEqtP7Hx7wqSRMa24LEafRkG6nNJeUoszR48Rbhj71Ld2t9i6AJcYRi2Na3Ilj6R4fnR0abjfTcqI JdOrfKnA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l9p1p-008rZB-US; Wed, 10 Feb 2021 12:55:34 +0000 Date: Wed, 10 Feb 2021 12:55:33 +0000 From: Christoph Hellwig To: ira.weiny@intel.com Cc: Andrew Morton , David Sterba , Christoph Hellwig , clm@fb.com, josef@toxicpanda.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V2 5/8] iov_iter: Remove memzero_page() in favor of zero_user() Message-ID: <20210210125533.GE2111784@infradead.org> References: <20210210062221.3023586-1-ira.weiny@intel.com> <20210210062221.3023586-6-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210062221.3023586-6-ira.weiny@intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 10:22:18PM -0800, ira.weiny@intel.com wrote: > From: Ira Weiny > > zero_user() is already defined with the same interface and contains the > same code pattern as memzero_page(). Remove memzero_page() and use the > already defined common function zero_user() Looks good, Reviewed-by: Christoph Hellwig