Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1292553pxb; Wed, 10 Feb 2021 05:13:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOh2j2I/BpGgecrKpteW6GKkiA/x77KbyJa6Lzr6xN9MYZeGM8GZzYCO7UTWmX3Kuq1nfi X-Received: by 2002:a17:906:35d9:: with SMTP id p25mr2877621ejb.398.1612962784190; Wed, 10 Feb 2021 05:13:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612962784; cv=none; d=google.com; s=arc-20160816; b=skOrnFGTtHMXpry6BqAc3LlLD3nR4nagEr8ZerFqTZCAaHHDfV3ukS0FtU6ehS6/jd GyHcwaoxOXT0bGZMZLIAsZopFsvLoqOl92/O+AZrQ3N9X55s8y02wAXVEety44wFOQsG OtV6LSgMN29ZrV5B5+QnjhSJ+kYX5sdxLKeQGVlNrCnikZrltLZpSxADgtX4GNUqphn/ rw5tjz3bMzBm5ILr9/3XFL40SfcQB1XINNMbgsq03smlkxTGc898jyvUVkVIGZ3r2He0 vQUbX442GMLs7+QocVeS2CNdj47hd2QyTUtEJ7lka+ZGHfDX1nozQfMf7+jnFgILaHiM hWwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:mail-followup-to:message-id:subject:cc:to:from:date :dkim-signature; bh=s03sQ832SgXdiNDUmP03CTP+mq4NdcSn/+dYlfQmwcc=; b=fKs+/h0w1b0IzonK19O6GbdW5bGzZ+2ZFDU7yWnEWG+eTV7prJ674+8MtSQShYBw9T gmD1dz2MkL8GdF2aRHf6gyOoKUu0oX2V1gRi/Ix+T1S/jkKEowccDgaW66588eOjoywV DA0NZ9Uak2oOfMhzi1mFS4wDgtMyTGozkXM/VGlJKa87t9SUjLBPoyIdoJuvEzK6snM+ LtDrewe7aDvN4OmOUtl7LM6YWmTvfQ94AIVJ2NdGrBkNV07MiIz6YHHx+HQejCK+uUzY R5EPxB3kyjeAVbcwpqaPkxAH9qK7ps/RmLcjOarVp5Gp4RIUfrDwQlYnnlvKeSVLSkmv WdVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=PxY1Itij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si1219620ejt.469.2021.02.10.05.12.39; Wed, 10 Feb 2021 05:13:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ffwll.ch header.s=google header.b=PxY1Itij; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229651AbhBJNMD (ORCPT + 99 others); Wed, 10 Feb 2021 08:12:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229610AbhBJNMA (ORCPT ); Wed, 10 Feb 2021 08:12:00 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2E5AC061574 for ; Wed, 10 Feb 2021 05:11:18 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id h12so2473664wrw.6 for ; Wed, 10 Feb 2021 05:11:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=s03sQ832SgXdiNDUmP03CTP+mq4NdcSn/+dYlfQmwcc=; b=PxY1ItijCBx9yZt9GDoetR+Op0lQC/DWXgC1sXU8fsSETfJLCku2M5hbsJux72ypT5 68s4xbs4GCHobFHT7aJxRgV07aKZpAXtydg1v/Qes/K+Ik5pM7mCeU3qwizOHDmmyIYp 9SV2Ipl+/MBK+WwF1Bx5MDU8zdm3twTWHnTQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=s03sQ832SgXdiNDUmP03CTP+mq4NdcSn/+dYlfQmwcc=; b=gGFvu57LrvKDMvt5dnYtu8y5DeUkbCk+aox+E6OXcqA2t0Mb5zsRUQVry9NFng2v7V i5i3XbjAslXNK5JEfUSqdAd0XzpGr/FqwmDyymDUec9ufaSmH+cBGD4z5cTvd/w+e+PO t8ChcFWrEzzI+n14infLEqMTGNjAIAU378YREdugSxS7YnenjI6K1qHZ97bqGJkAvpXN WTTMRHTLiURitkVZgN4oxvVsX9MoLdP0t1/vLzl9UmSRPL27DAvsDazJDfREQNue1Lho n5B9tfpFb1GJNMzJC++KALl/flQJtpxjAhDv4rkM/ffpxG4dUGRvzKIWHwj0YrZSJ38B QgJg== X-Gm-Message-State: AOAM531CQwMqQIyB7fS/a/OnX9idQFAQ+GZnzOEfzF7szxhxydQa7bxX A0PS/+sfI4TmJ+UrQ5uWtY/gHg== X-Received: by 2002:adf:dd92:: with SMTP id x18mr3686880wrl.4.1612962677521; Wed, 10 Feb 2021 05:11:17 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id a84sm2430371wme.12.2021.02.10.05.11.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Feb 2021 05:11:16 -0800 (PST) Date: Wed, 10 Feb 2021 14:11:14 +0100 From: Daniel Vetter To: Julia Lawall Cc: David Airlie , kernel-janitors@vger.kernel.org, Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Andrzej Hajda , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Heiko =?iso-8859-1?Q?St=FCbner?= , Sandy Huang , Thierry Reding , Sam Ravnborg , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joel Stanley , Andrew Jeffery , linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH] drm: use getter/setter functions Message-ID: Mail-Followup-To: Julia Lawall , David Airlie , kernel-janitors@vger.kernel.org, Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Neil Armstrong , Andrzej Hajda , linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Heiko =?iso-8859-1?Q?St=FCbner?= , Sandy Huang , Thierry Reding , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Joel Stanley , Andrew Jeffery , linux-aspeed@lists.ozlabs.org References: <20210209211304.1261740-1-Julia.Lawall@inria.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209211304.1261740-1-Julia.Lawall@inria.fr> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 10:13:04PM +0100, Julia Lawall wrote: > Use getter and setter functions, for platform_device structures and a > mipi_dsi_device structure. > > Signed-off-by: Julia Lawall Applied to drm-misc-next, thanks for the patch. -Daniel > > --- > drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 2 +- > drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c | 2 +- > drivers/gpu/drm/panel/panel-lvds.c | 2 +- > drivers/gpu/drm/panel/panel-seiko-43wvf1g.c | 4 ++-- > drivers/gpu/drm/panel/panel-simple.c | 2 +- > drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +- > 6 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 4e2dad314c79..9858079f9e14 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -4800,7 +4800,7 @@ static int panel_simple_dsi_probe(struct mipi_dsi_device *dsi) > > err = mipi_dsi_attach(dsi); > if (err) { > - struct panel_simple *panel = dev_get_drvdata(&dsi->dev); > + struct panel_simple *panel = mipi_dsi_get_drvdata(dsi); > > drm_panel_remove(&panel->base); > } > diff --git a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > index 0ee508576231..3939b25e6666 100644 > --- a/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > +++ b/drivers/gpu/drm/panel/panel-seiko-43wvf1g.c > @@ -267,7 +267,7 @@ static int seiko_panel_probe(struct device *dev, > > static int seiko_panel_remove(struct platform_device *pdev) > { > - struct seiko_panel *panel = dev_get_drvdata(&pdev->dev); > + struct seiko_panel *panel = platform_get_drvdata(pdev); > > drm_panel_remove(&panel->base); > drm_panel_disable(&panel->base); > @@ -277,7 +277,7 @@ static int seiko_panel_remove(struct platform_device *pdev) > > static void seiko_panel_shutdown(struct platform_device *pdev) > { > - struct seiko_panel *panel = dev_get_drvdata(&pdev->dev); > + struct seiko_panel *panel = platform_get_drvdata(pdev); > > drm_panel_disable(&panel->base); > } > diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c > index 654bc52d9ff3..bd5ba10822c2 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c > +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c > @@ -725,7 +725,7 @@ static int rockchip_lvds_probe(struct platform_device *pdev) > > static int rockchip_lvds_remove(struct platform_device *pdev) > { > - struct rockchip_lvds *lvds = dev_get_drvdata(&pdev->dev); > + struct rockchip_lvds *lvds = platform_get_drvdata(pdev); > > component_del(&pdev->dev, &rockchip_lvds_component_ops); > clk_unprepare(lvds->pclk); > diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > index 457ec04950f7..c7707338bfdb 100644 > --- a/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > +++ b/drivers/gpu/drm/aspeed/aspeed_gfx_drv.c > @@ -284,7 +284,7 @@ static int aspeed_gfx_probe(struct platform_device *pdev) > if (ret) > return ret; > > - dev_set_drvdata(&pdev->dev, priv); > + platform_set_drvdata(pdev, priv); > > ret = sysfs_create_group(&pdev->dev.kobj, &aspeed_sysfs_attr_group); > if (ret) > diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > index d0c65610ebb5..989a05bc8197 100644 > --- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > +++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c > @@ -2457,7 +2457,7 @@ static int cdns_mhdp_probe(struct platform_device *pdev) > > static int cdns_mhdp_remove(struct platform_device *pdev) > { > - struct cdns_mhdp_device *mhdp = dev_get_drvdata(&pdev->dev); > + struct cdns_mhdp_device *mhdp = platform_get_drvdata(pdev); > unsigned long timeout = msecs_to_jiffies(100); > bool stop_fw = false; > int ret; > diff --git a/drivers/gpu/drm/panel/panel-lvds.c b/drivers/gpu/drm/panel/panel-lvds.c > index 66c7d765b8f7..59a8d99e777d 100644 > --- a/drivers/gpu/drm/panel/panel-lvds.c > +++ b/drivers/gpu/drm/panel/panel-lvds.c > @@ -244,7 +244,7 @@ static int panel_lvds_probe(struct platform_device *pdev) > > static int panel_lvds_remove(struct platform_device *pdev) > { > - struct panel_lvds *lvds = dev_get_drvdata(&pdev->dev); > + struct panel_lvds *lvds = platform_get_drvdata(pdev); > > drm_panel_remove(&lvds->panel); > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch