Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1296302pxb; Wed, 10 Feb 2021 05:18:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzi6hvT30CEd/JKmNtCKs0nLxGWNSVwS64eiQceumitvpBtVpOKOcfCOxM/95HZOzQC5A8f X-Received: by 2002:a05:6402:105a:: with SMTP id e26mr3031359edu.60.1612963123294; Wed, 10 Feb 2021 05:18:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612963123; cv=none; d=google.com; s=arc-20160816; b=08pDP4Gb8wppg0Gwt0M2aDGhWL8TyfQM0uM+6+RExA4g6i5VQKD2WAjXHNks94FOAc ouQEfPoHtEcRnD2h/YDJSoNzdTD3hOocXr2sTOanTN+W0y2fGG52tGBbf9EhZENTdYcP 8rY0Vi4LEHUhsZypui8LTw7s9gzDYFwRlDgaIozr9N9fNYP8nSrC2FvFaZ9llV5ORJyv QlvwhlgT+nJwM/5b/ElVnQxLB8aN2EJCAZT6SS8KLzSG4+cyuJ4d21jV2zAEo2PHlzS1 TOAN0rIKAiNLHrKOxZAgBbTHX1esXoveLES0WyWrvS4FQ/ySAOrgOcyYhJv6F92brTTQ FXyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=dYBO47CK0P7YssvTaOnPb+SAZkTmMcdi2g8ISe1WS+0=; b=dC0D+LohXF/bojR9sY4mdPcQG5EtBEcj6NU0EuOMdf5itWDVpN31CSre3MIC7pGCMw atKyGeHJjqD27Rf++hCbc2ZYck9B9NudGC4w0m52uyecSoZEUnXtVwXfbsHN19urZM0L Sn8njJWVGkJ9bDSRSfXaMBDDwdTXMlwfvDIhOlGpH6x6rGf8ZHtQsbVfSouVPC+SK276 0DDYPA6V4jkWtiMgof+JFrjJt5uShZBrSB3ByNFnDrUNnjdaXXsdwUpb9UZwQiUssKXH bWpeMq0Ds1Mubozo48IHTM1fo9LiPLpmpxIyquRPBDiJm+ndJ1pWqTZ+cSs9LKlX+PAD 8P2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si1341038eja.248.2021.02.10.05.18.20; Wed, 10 Feb 2021 05:18:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231663AbhBJNRS (ORCPT + 99 others); Wed, 10 Feb 2021 08:17:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231626AbhBJNRM (ORCPT ); Wed, 10 Feb 2021 08:17:12 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B99EC061574; Wed, 10 Feb 2021 05:16:31 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1l9pLY-00054L-Pl; Wed, 10 Feb 2021 14:15:56 +0100 Date: Wed, 10 Feb 2021 14:15:56 +0100 From: Florian Westphal To: Alexander Lobakin Cc: "David S. Miller" , Jakub Kicinski , Jonathan Lemon , Eric Dumazet , Dmitry Vyukov , Willem de Bruijn , Randy Dunlap , Kevin Hao , Pablo Neira Ayuso , Jakub Sitnicki , Marco Elver , Dexuan Cui , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Taehee Yoo , Cong Wang , =?iso-8859-15?Q?Bj=F6rn_T=F6pel?= , Miaohe Lin , Guillaume Nault , Yonghong Song , zhudi , Michal Kubecek , Marcelo Ricardo Leitner , Dmitry Safonov <0x7f454c46@gmail.com>, Yang Yingliang , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Edward Cree Subject: Re: [v3 net-next 08/10] skbuff: reuse NAPI skb cache on allocation path (__build_skb()) Message-ID: <20210210131556.GA2766@breakpoint.cc> References: <20210209204533.327360-1-alobakin@pm.me> <20210209204533.327360-9-alobakin@pm.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209204533.327360-9-alobakin@pm.me> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Alexander Lobakin wrote: > we're in such context. This includes: build_skb() (called only > from NIC drivers in NAPI Rx context) and {,__}napi_alloc_skb() > (called from the same place or from kernel network softirq > functions). build_skb is called from sleepable context in drivers/net/tun.c . Perhaps there are other cases.