Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Feb 2021 14:27:39 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Ian Rogers <irogers@google.com>,
        Alexei Budankov <abudankov@huawei.com>
Subject: Re: [PATCH 15/24] perf daemon: Add ping command
Message-ID: <YCPfS91fbj3XyH/v@krava>
References: <20210208200908.1019149-1-jolsa@kernel.org>
 <20210208200908.1019149-16-jolsa@kernel.org>
 <20210210125146.GD1018564@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210210125146.GD1018564@kernel.org>
Precedence: bulk

On Wed, Feb 10, 2021 at 09:51:46AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Feb 08, 2021 at 09:08:59PM +0100, Jiri Olsa escreveu:
> > +
> > +	if (!pollfd.revents & POLLIN) {
> > +		pr_err("failed: did not received an ack\n");
> > +		goto out;
> > +	}
> > +
> 
> Fixed up this, pointed out by clang on many build containers, including
> fedora:34:
> 
> Committer notes:
> 
> Fixed up bug pointed by clang:
> 
> Buggy:
> 
>   if (!pollfd.revents & POLLIN)
> 
> Correct code:
> 
>   if (!(pollfd.revents & POLLIN))
> 
> clang warning:
> 
>   builtin-daemon.c:560:6: error: logical not is only applied to the left hand side of this bitwise operator [-Werror,-Wlogical-not-parentheses]
>           if (!pollfd.revents & POLLIN) {
>               ^               ~
>   builtin-daemon.c:560:6: note: add parentheses after the '!' to evaluate the bitwise operator first

oops, thanks

jirka