Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0YM2d3k1fC5uD+d18/ORVHjsexLnkcU6bWKJubDijtuma1EpLElYgzgyBJqZ6bJseDv/VthiXn
 guCoa1Eh4gUaz7c/oZrloXPJH8FoS/lrz6wQqXwcHEsfM0ixnXx45amA4hyoL/KGmI1SjJnuAK
 k/OOWl/mTLMR6v5GXPbVi+RfEF+WeW4giC3X04RJT2i5zkn0uwu6+muiPLKOCYtUdwhKFA7t04
 CFv2RCDEu7QJCMZXPdrdg9xmZUaIcA9QR6blI4TdW25E3FIRT5mXlOIwkCzjAB5HIfwrUR20xf
 LEc=
References: <20210210132751.1422386-1-geert+renesas@glider.be>
User-agent: mu4e 1.2.0; emacs 26.3
From:   Lars Povlsen <lars.povlsen@microchip.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
CC:     Linus Walleij <linus.walleij@linaro.org>,
        Lars Povlsen <lars.povlsen@microchip.com>,
        Steen Hegelund <Steen.Hegelund@microchip.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        <UNGLinuxDriver@microchip.com>, <linux-gpio@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-mips@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII
In-Reply-To: <20210210132751.1422386-1-geert+renesas@glider.be>
Date:   Wed, 10 Feb 2021 14:45:31 +0100
Message-ID: <87mtwcujd0.fsf@microchip.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk


Geert Uytterhoeven writes:

> the Microsemi/Microchip Serial GPIO device is present only Microsemi
> VCore III and Microchip Sparx5 SoCs.  Hence add a dependency on
> ARCH_SPARX5 || SOC_VCOREIII, to prevent asking the user about this
> driver when configuring a kernel without support for these SoCs.
>
> Fixes: 7e5ea974e61c8dd0 ("pinctrl: pinctrl-microchip-sgpio: Add pinctrl driver for Microsemi Serial GPIO")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/pinctrl/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index 113073d5f89bbf70..3b75b1d7d3d1f1b0 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -353,8 +353,8 @@ config PINCTRL_OCELOT
>
>  config PINCTRL_MICROCHIP_SGPIO
>         bool "Pinctrl driver for Microsemi/Microchip Serial GPIO"
> -       depends on OF
> -       depends on HAS_IOMEM
> +       depends on OF && HAS_IOMEM
> +       depends on ARCH_SPARX5 || SOC_VCOREIII || COMPILE_TEST
>         select GPIOLIB
>         select GPIOLIB_IRQCHIP
>         select GENERIC_PINCONF

Geert,

Thank you for your patch. Unfortunately, it makes it impossible to use
the driver across PCIe - which is a specifically desired configuration.

Could you add CONFIG_PCI to the || chain?

Cheers,

-- 
Lars Povlsen,
Microchip