Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [next] [mips] spinlock.h:17:28: error: redefinition of
 'queued_spin_unlock'
To:     Naresh Kamboju <naresh.kamboju@linaro.org>,
        linux-mips@vger.kernel.org,
        Linux-Next Mailing List <linux-next@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        lkft-triage@lists.linaro.org
Cc:     Paul Burton <paul.burton@mips.com>, Will Deacon <will@kernel.org>,
        Will Deacon <will.deacon@arm.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Boqun Feng <boqun.feng@gmail.com>
References: <CA+G9fYtkWdeL7-nfXW8+VbaCK7swinU_Ksn67RW4FFD+cx8VYg@mail.gmail.com>
From:   Waiman Long <longman@redhat.com>
Organization: Red Hat
Message-ID: <8e1322cf-4498-43b6-1dbd-665b7f016815@redhat.com>
Date:   Wed, 10 Feb 2021 10:02:40 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.1
MIME-Version: 1.0
In-Reply-To: <CA+G9fYtkWdeL7-nfXW8+VbaCK7swinU_Ksn67RW4FFD+cx8VYg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 2/10/21 12:30 AM, Naresh Kamboju wrote:
> While building Linux next tag 20210209 mips uImage.gz failed with below configs
>
>    - mips (cavium_octeon_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (malta_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (nlm_xlp_defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>    - mips (defconfig) with gcc-8, gcc-9 and gcc-10 - FAILED
>
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/tmp ARCH=mips
> CROSS_COMPILE=mips-linux-gnu- 'CC=sccache mips-linux-gnu-gcc'
> 'HOSTCC=sccache gcc' uImage.gz
> In file included from /include/linux/spinlock.h:90,
>                   from /include/linux/ipc.h:5,
>                   from /include/uapi/linux/sem.h:5,
>                   from /include/linux/sem.h:5,
>                   from /include/linux/compat.h:14,
>                   from /arch/mips/kernel/asm-offsets.c:12:
> /arch/mips/include/asm/spinlock.h:17:28: error: redefinition of
> 'queued_spin_unlock'
>     17 | #define queued_spin_unlock queued_spin_unlock
>        |                            ^~~~~~~~~~~~~~~~~~
>
> Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
>
> build link,
> https://builds.tuxbuild.com/1oF9lkBAeWM2WvR11O2Yun8ERNT/
>
I have just posted a patch to reorder qspinlock.h and qrwlock.h include 
ordering. Hopefully that can fix the compilation problem though I don't 
have a mips building environment to verify that.

Cheers,
Longman