Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210210141140.1506212-1-geert+renesas@glider.be> <20210210141140.1506212-4-geert+renesas@glider.be>
In-Reply-To: <20210210141140.1506212-4-geert+renesas@glider.be>
From:   Arnd Bergmann <arnd@kernel.org>
Date:   Wed, 10 Feb 2021 16:11:17 +0100
Message-ID: <CAK8P3a2qt0CpQ+o36Zz73_uap4ms8W0UAXS8Cd9BRoKMTCGL_A@mail.gmail.com>
Subject: Re: [PATCH 3/4] asm-generic: div64: Remove always-true __div64_const32_is_OK()
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Russell King <linux@armlinux.org.uk>,
        Michal Simek <monstr@monstr.eu>, Arnd Bergmann <arnd@arndb.de>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Feb 10, 2021 at 3:11 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Since commit cafa0010cd51fb71 ("Raise the minimum required gcc version
> to 4.6"), the kernel can no longer be compiled using gcc-3.
> Hence __div64_const32_is_OK() is always true, and the corresponding
> check can thus be removed.
>
> While at it, remove the whitespace error that hurts my eyes, and add the
> missing curly braces for the final else statement, as per coding style.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  include/asm-generic/div64.h | 14 ++++----------

Acked-by: Arnd Bergmann <arnd@arndb.de>