Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/2] bfq: remove some useless logic of
 bfq_update_next_in_service()
To:     Oleksandr Natalenko <oleksandr@natalenko.name>,
        Paolo Valente <paolo.valente@linaro.org>
Cc:     Chunguang Xu <brookxu.cn@gmail.com>, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <1611917485-584-1-git-send-email-brookxu@tencent.com>
 <B4751549-78D9-4A84-8FB2-5DAA86ED39C8@linaro.org>
 <20210210152034.puimoewzgtnnp2zl@spock.localdomain>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <bc39aeb5-4fb6-db15-3ad5-b310f5d5b486@kernel.dk>
Date:   Wed, 10 Feb 2021 08:21:56 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210210152034.puimoewzgtnnp2zl@spock.localdomain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/10/21 8:20 AM, Oleksandr Natalenko wrote:
> On Wed, Feb 10, 2021 at 12:13:29PM +0100, Paolo Valente wrote:
>>
>>
>>> Il giorno 29 gen 2021, alle ore 11:51, Chunguang Xu <brookxu.cn@gmail.com> ha scritto:
>>>
>>> From: Chunguang Xu <brookxu@tencent.com>
>>>
>>> The if statement at the end of the function is obviously useless,
>>> maybe we can delete it.
>>>
>>
>> Thanks for spotting this mistake.
>>
>> Acked-by: Paolo Valente <paolo.valente@linaro.org>
>>
>>> Signed-off-by: Chunguang Xu <brookxu@tencent.com>
>>> ---
>>> block/bfq-wf2q.c | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/block/bfq-wf2q.c b/block/bfq-wf2q.c
>>> index 26776bd..070e34a 100644
>>> --- a/block/bfq-wf2q.c
>>> +++ b/block/bfq-wf2q.c
>>> @@ -137,9 +137,6 @@ static bool bfq_update_next_in_service(struct bfq_sched_data *sd,
>>>
>>> 	sd->next_in_service = next_in_service;
>>>
>>> -	if (!next_in_service)
>>> -		return parent_sched_may_change;
>>> -
> 
> Unless I'm missing something, this has already been fixed here:
> 
> https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.12/block&id=1a23e06cdab2be07cbda460c6417d7de564c48e6

Yep indeed.

-- 
Jens Axboe