Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1392263pxb; Wed, 10 Feb 2021 07:25:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJy9u9VTi93q0YBNh1O98NIvpn6EyGqKnhVll5Gf2dshwLartEe7deqTlcVh+G3gz4zWPr9A X-Received: by 2002:a05:6402:4d3:: with SMTP id n19mr3615523edw.2.1612970736081; Wed, 10 Feb 2021 07:25:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612970736; cv=none; d=google.com; s=arc-20160816; b=eSBJtTgj1oo3q04nu3LCoX/aTINIID3ZOegpm+jyuEBS6Y766UMhL5gdvj44B+U+ek WunxkqAcgSqwx+8wvRAcTaFFfnSrdfyRxwwnjU+w8fs9ZmZT0CnCZM449dPZSdk3Gcpe NHISTu2hxiSaw5T4rSOooWATBeqNxSv3EFDjTUZapniNB1c7GhRBbk4YNK7nq+6kfUqx utwW/40lHINiwMxe45cOwV3owS5VfGW32VrCatcPLCU7/874gfHShAum32o4tgHLhMI/ A3QRI66KtwCXvE03ywt5PE54rg6692yi2/aHb3izXEDH0JdwRXZR+KWts++bv2KEE4zw rLvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=SVhxUyBWxq4VC4XO9wmAJiQeUw+uaZsK75VqrPAwCDA=; b=QRwQfkIK0KAU4xTRQnW+lcDiXgFXqdJunpqo2li6jxmw9b7mGzxJTmHIUYhVLtf5Bd DRYiPK/F7lLTVESG7VEG0sjndPF2S6oL7JIPLkfQp2XBERrOX7NdFLZLPTLhYVH/SW2I Xj/L8bM/a4RnIL2fbRBtANQ1XRtMU34++gJ1YzCkpLq4zDuEf5YTGrSTkZG69Y0mC3XQ O60tJz8Ek7Sm4/qfOLfc+kp8IZpsGOhrb0KCHm/fWpZ/CtivUFezdRholCop12c4vei2 Re1WCRCAJS4wnRXJs58C5qtyW9DS/WoBHYl9qZrl9NAM2j/b6uyAuWkTY9gHz+0tSxgy TrDw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j22si1462224edh.496.2021.02.10.07.25.11; Wed, 10 Feb 2021 07:25:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231186AbhBJPW6 (ORCPT + 99 others); Wed, 10 Feb 2021 10:22:58 -0500 Received: from mga14.intel.com ([192.55.52.115]:50365 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbhBJPWs (ORCPT ); Wed, 10 Feb 2021 10:22:48 -0500 IronPort-SDR: uRlPqm5Cz6MsYpyeuSDGW3aDrLYXaEYrFuvBUWqHQKO+JyhqF3sJt94Ui9Z5EVBJDhVojleC2o Mja/toY5BKTg== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="181315852" X-IronPort-AV: E=Sophos;i="5.81,168,1610438400"; d="scan'208";a="181315852" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 07:22:05 -0800 IronPort-SDR: ecCbGYn/Lv2+PsJiYCla/4ix7kx0ByxM3XbjCyxEzzx+lQlLqxHT5X6iZb/YsXK68fe/2SkKsp rdtN/msbIGmQ== X-IronPort-AV: E=Sophos;i="5.81,168,1610438400"; d="scan'208";a="488779012" Received: from tryu-mobl2.amr.corp.intel.com (HELO [10.209.100.152]) ([10.209.100.152]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 07:22:04 -0800 Subject: Re: [PATCH] x86, sched: Allow NUMA nodes to share an LLC on Intel platforms To: Peter Zijlstra , Alison Schofield Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org, Dave Hansen , Tony Luck , Tim Chen , "H. Peter Anvin" , David Rientjes , Igor Mammedov , Prarit Bhargava , brice.goglin@gmail.com References: <20210209223943.9834-1-alison.schofield@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Wed, 10 Feb 2021 07:22:03 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/21 12:05 AM, Peter Zijlstra wrote: >> + if (IS_ENABLED(CONFIG_NUMA)) >> + set_cpu_bug(c, X86_BUG_NUMA_SHARES_LLC); >> } > This seens wrong too, it shouldn't be allowed pre SKX. And ideally only > be allowed when SNC is enabled. Originally, this just added a few more models to the list of CPUs with SNC. I was hoping for something a bit more durable that we wouldn't have to go back and poke at every year or two. > Please make this more specific than: all Intel CPUs. Ofcourse, since you > all knew this was an issue, you could've made it discoverable > _somewhere_ :-( You're totally right, of course. The hardware could enumerate SNC as a feature explicitly somewhere. But, that's a little silly because all of the information that it's enumerating about the CPU caches and NUMA nodes present and correct is *correct*. The secondary information would only be for the CPU to say, "yeah, I'm really sure about that other stuff". I think this sanity check has outlived its usefulness.