Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210210142525.2876648-1-daniel.thompson@linaro.org>
In-Reply-To: <20210210142525.2876648-1-daniel.thompson@linaro.org>
From:   Doug Anderson <dianders@chromium.org>
Date:   Wed, 10 Feb 2021 07:57:12 -0800
Message-ID: <CAD=FV=W9MUKYMusgUbq9RW8Hm9b+TtEMyrj6jfHrpe9twy5tvA@mail.gmail.com>
Subject: Re: [PATCH] kgdb: Remove kgdb_schedule_breakpoint()
To:     Daniel Thompson <daniel.thompson@linaro.org>
Cc:     Jason Wessel <jason.wessel@windriver.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Emil Renner Berthing <kernel@esmil.dk>,
        kgdb-bugreport@liss.sourceforge.net,
        LKML <linux-kernel@vger.kernel.org>,
        Patch Tracking <patches@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi,

On Wed, Feb 10, 2021 at 6:25 AM Daniel Thompson
<daniel.thompson@linaro.org> wrote:
>
> To the very best of my knowledge there has never been any in-tree
> code that calls this function. It exists largely to support an
> out-of-tree driver that provides kgdb-over-ethernet using the
> netpoll API.
>
> kgdboe has been out-of-tree for more than 10 years and I don't
> recall any serious attempt to upstream it at any point in the last
> five. At this stage it looks better to stop carrying this code in
> the kernel and integrate the code into the out-of-tree driver
> instead.
>
> The long term trajectory for the kernel looks likely to include
> effort to remove or reduce the use of tasklets (something that has
> also been true for the last 10 years). Thus the main real reason
> for this patch is to make explicit that the in-tree kgdb features
> do not require tasklets.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
>
> Notes:
>     During this cycle two developers have proposed tidying up the
>     DECLARE_TASKLET_OLD() in the debug core. Both threads ended with a
>     suggestion to remove kgdb_schedule_breakpoint() but I don't recall
>     seeing a follow up patch for either thread... so I wrote it myself.
>
>  include/linux/kgdb.h      |  1 -
>  kernel/debug/debug_core.c | 26 --------------------------
>  2 files changed, 27 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>