Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1439246pxb;
        Wed, 10 Feb 2021 08:22:36 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzR9qdbU7KYNy6v6Mb4n0Q/mk9puQ6pKMy5+rYZNEHfjUOKJCzdE4BKAcHveCJECt+TVviV
X-Received: by 2002:a50:fe02:: with SMTP id f2mr3747319edt.195.1612974156750;
        Wed, 10 Feb 2021 08:22:36 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612974156; cv=none;
        d=google.com; s=arc-20160816;
        b=wwcEY0hW/aW5JqeL07yTSz13vo/hCYefZBRZG7rK6jBbBTaNkFDHq/AJ53yw+HKe15
         yTray6j8y0YBzQMFJmhNUtoB0TOX3LQzdrzyUau/RypKGIRhtZFMr6vKsLYZrA6WwDLq
         HTEYb2CcT5jaGX4XRxBy2kw0L8G1zGiNHVtswjkuhOuO5k7+z9FHZtIUd+MEPBzOn6ZC
         qS22VItzgEmgzQ7seC3vXw+YvIAdZSv9sE+XCFROi2ZBkGP9udhWGD57mzgZaPRX+/X1
         IxB8maE+DN7mUmaoI46DAP78F82Es556ooNGbyzME042tiFN7jbhRNFeFAJciZsM3pvF
         FSLw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=mvoliNocsaPNjIocDiS0cy0Zl/y2oFsVOa4DofuNVFE=;
        b=Yt78UqW1ikmT4zTiP+0or2ulolTYoxNFMnQqlSmrGebH2703DqykA/HcoiHXbFfiuh
         LcvJbR1oFsTYMnCYhdUm+aZInzvtmwC8P/AFOjVwTWLPSNRx1l//waxZuv7YS63l2rie
         AMME6sVyxQFDYYMxz/mJoY26i9WbJN+GuydxDJmNrn4G9OGJGs6ykg24JiS222WeQC+1
         UsdF4CD0ozNQ3M675xEwI1uYFgCvUHmJ8QqiCS9eDZXZNQlgfJoHjQTCdw/djI+fG3s8
         sVo/XcpQIienLwaZtV9SKwVKYVCo8otraHBm6xUiE4BMmI3zEn4MaOaLDjw/MEzCjsH+
         o5Qw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Elq8p36W;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id b11si1760533edz.246.2021.02.10.08.22.08;
        Wed, 10 Feb 2021 08:22:36 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Elq8p36W;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232248AbhBJQSp (ORCPT <rfc822;loic.yhuel@gmail.com> + 99 others);
        Wed, 10 Feb 2021 11:18:45 -0500
Received: from mail.kernel.org ([198.145.29.99]:56174 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S232062AbhBJQSl (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 10 Feb 2021 11:18:41 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D5BE64E76;
        Wed, 10 Feb 2021 16:17:59 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1612973880;
        bh=z11X40ByBwLWoBHw1+NfChx4CZeIHFtuXrvlkGJQ3Ys=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=Elq8p36WSo3O9tH0kKFOe6CvIQ9iHj6UkuGTWwI2LlVyzXqa5v02hTGBeqbZkNzRG
         2Pcpf1aYrNXOPOTPhrfdc9Z9JArg9Icx5yg+4Mua8Qbo5R7AmaoGRn9W0ZC0E3M9Oc
         oaYs8KWoTjp/AVcH6WhlXg1sgLSiVj+VMURLENI3SHb0sx2L4t6xYaHddcbxzxODn5
         L2qBgs6yk+tKh/ShCvryuQrA19piAZA8N43oKyHwXWgk+nF9vIRN62hlr/YwpACF84
         k5WYJUbYLdicclku6tU8UMv3j9jciAgFE4KJwFcxApvij1BRJhbekaI+P179/6c0MJ
         yHZJU3z7aklMQ==
Date:   Wed, 10 Feb 2021 17:17:56 +0100
From:   Jessica Yu <jeyu@kernel.org>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Christoph Hellwig <hch@lst.de>, Petr Mladek <pmladek@suse.com>,
        Miroslav Benes <mbenes@suse.cz>, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] module: potential uninitialized return in
 module_kallsyms_on_each_symbol()
Message-ID: <YCQHNI3bowhhnRD+@gunter>
References: <YCO8AwE57IzaMamG@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <YCO8AwE57IzaMamG@mwanda>
X-OS:   Linux gunter 5.10.12-1-default x86_64
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

+++ Dan Carpenter [10/02/21 13:57 +0300]:
>Smatch complains that:
>
>	kernel/module.c:4472 module_kallsyms_on_each_symbol()
>        error: uninitialized symbol 'ret'.
>
>This warning looks like it could be correct if the &modules list is
>empty.
>
>Fixes: 013c1667cf78 ("kallsyms: refactor {,module_}kallsyms_on_each_symbol")
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied, thanks!

Jessica