Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1458535pxb; Wed, 10 Feb 2021 08:46:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJyY+fUvAd8q+e49m26Jm76NkE5/ZT69Lrzm4JpXePgd8E/fg++psrZeUOrfllVXlIh4t1wH X-Received: by 2002:a05:6402:1589:: with SMTP id c9mr4076381edv.282.1612975608032; Wed, 10 Feb 2021 08:46:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612975608; cv=none; d=google.com; s=arc-20160816; b=QJnlIIWNxhmlwNGj2E68E/dVzvhCDxLJ5VFIflnAqyYEtnozkiKvAJoOhYGkasDWwu AeQFg3BNFEMc7H51mVyIkBDPN5ersz1YUMHwirb0LIIEkb1BTbIA3eOKVTpg1aZQkT9f 7Z1AqKb376S4zRyNB+v95DahVALc4eYZkspAFzdUoAGSuLfrxlwYwngugRc4CpBDxV2j LxWzpx1yCwjmT0SxVf8WwPriRoA0JWCGmsTVIb1tD2GKMRq45Rz9BlfGjZKs2AOQLZxU cU2JeOEwajpDt37WAY2EgzvyrBty6FTbVPgN3923GeugKzeqnL7k2b8pcFytftty8VZb 3APA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=v9yRMlvHCXlBWJoLZkr6GmF3X21NdcNOdmmcwmQ1wz4=; b=XtE64/858iCMmPclj0xwd9ueTg9bGOeY3C0woDGVp5DPYYW2b8Jdcm8Ak5anNqH55R K8tbCRoZLPNDQF+SaYV+WPSvfTb5RTeavoAAVW6Zv4ETyQzGpEP+5G0xrCRQ1YzX+Izm VYqhyzhGuzYtf1QWdQ8cgYxawH1ejXTcfSO26Ndiibg2SVU/8eN2UElAZ/MQJzFHgLKy Ot2JHZa0/G9jXD5ytKSFDUdG4szvB8IGhOiyEX1bK+WB7UVyFdfHNrr8avdsyNNe4Wm4 iw4eKvJwOgyCOKVwxZhhFL1jbG6HRofzFL2w7naQc97H10GJq2cOdMaXVAGPS9RjFX32 76dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZOlYhvxC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l3si1608130edr.604.2021.02.10.08.46.24; Wed, 10 Feb 2021 08:46:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ZOlYhvxC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233148AbhBJQp2 (ORCPT + 99 others); Wed, 10 Feb 2021 11:45:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232990AbhBJQm1 (ORCPT ); Wed, 10 Feb 2021 11:42:27 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02CA0C06174A; Wed, 10 Feb 2021 08:41:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=v9yRMlvHCXlBWJoLZkr6GmF3X21NdcNOdmmcwmQ1wz4=; b=ZOlYhvxCmn92QujUmMYgBIPZVP 5YxBTBFobbzdLHFwIbywWhaip4VxFsEGHF0391VEjMt88YoFxNGZb6WB1e/60S+AFzJ5Dspc1fC9b GW+BvuLwQMhhHN8spE3w3mzx2syXtq6Q6qvn6PFvS/5yNFAlYEBynuRYF9hnsrPR361M7LAPidXaP P5roLkekwQssjJ1dZ6D+AbruBWdDQA8uUQgeg7E2MjRRRDkW8P8Yel7GKRkSlA8GjBbYq+gPY3NQJ wAi+uYbXy22iC0cXqPPHuxKILei5ja+m4VfsA/c+sc+gbtIj3smmZywjjyl17uuXq3wBryTPXq/1J RGEcobmA==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l9sYY-0096RT-83; Wed, 10 Feb 2021 16:41:34 +0000 Date: Wed, 10 Feb 2021 16:41:34 +0000 From: Christoph Hellwig To: Ira Weiny Cc: Christoph Hellwig , Andrew Morton , David Sterba , Matthew Wilcox , clm@fb.com, josef@toxicpanda.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls Message-ID: <20210210164134.GA2169678@infradead.org> References: <20210210062221.3023586-1-ira.weiny@intel.com> <20210210062221.3023586-5-ira.weiny@intel.com> <20210210125502.GD2111784@infradead.org> <20210210162901.GB3014244@iweiny-DESK2.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210162901.GB3014244@iweiny-DESK2.sc.intel.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 08:29:01AM -0800, Ira Weiny wrote: > On Wed, Feb 10, 2021 at 12:55:02PM +0000, Christoph Hellwig wrote: > > On Tue, Feb 09, 2021 at 10:22:17PM -0800, ira.weiny@intel.com wrote: > > > From: Ira Weiny > > > > > > Add VM_BUG_ON bounds checks to ensure the newly lifted and created page > > > memory operations do not result in corrupted data in neighbor pages and > > > to make them consistent with zero_user().[1][2] > > > > s/VM_BUG_ON/BUG_ON/g ? > > Andrew wanted VM_BUG_ON.[1] I don't care either way, but the patch uses BUG_ON, so the description should match.