Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1473504pxb; Wed, 10 Feb 2021 09:06:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1ZtXGF5NzpsMLlkD32sCWxmZwsq1zxbzww1CcGc4eVkglh3fLiWhKXuurgcT+SrJ0GCt7 X-Received: by 2002:a17:906:a448:: with SMTP id cb8mr3864429ejb.174.1612976790811; Wed, 10 Feb 2021 09:06:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612976790; cv=none; d=google.com; s=arc-20160816; b=Co1m+a6HCy4kAleiyU62mc60VQM34XMYUVYCKYVTM7FVv55xTq9Q9snaexGxya4UF3 /oPWYwv4ULGxJGBXKkDCNKJDEtSHLmY2LZd1j/fnlps8wccW8E7bAYbyBUkDgPK48i6E D6Zr3kAXpo7DexhW/wBRsfaTfqVfJeWEcR7zJEMF5cK1ggszRJxHA8gavz7dnx8liT9j LNvroXUEPIj+t8QorcLl9M5NHefZhXEtRqUFBN5BDPN3krQLxxmkwCL35Z1yQSpYWB/p I7vkcW0ZW5OQC9qt6TYVmzOhNYhRMU1QQ0xhJz6eULyNUcMzDPsotFLIuiolckTtMJpE GK9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=/ZHXpSJNTScpY4lOX/ufHr5KYF+qluP2wFIBlbFwGkI=; b=jTwCEmTzrG4A2v8Wp/T+JrdRMudfkHc6QoGxn1aW8u/Deiuxx64wxVrBQe4hsM22Qq Lb3POUcoCjV7bxoPskzrmMfnn1LiKv7slc7VNYEvk/2HTQGZAdTd1YweYW5V673ggbhL 67eZhjNvM5llwNvatyth1bbVyyNUiesxAb4SiKdp2AZHnnfUfmdy5feCghLI58xH27Hf 7HDbxIsS1zOJkNOVymkf2g6AqdpzKIOVDXiB5Kcbhfq0f0WONwFszclkJ723vQqcAegY vgfzHpzY8CG63FN9mlP+fFuoKFwWNCnFmW4YezmQxsJhFuYvGPJ4smODnB5kIrDaLUq6 qxHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e22si2100427edu.45.2021.02.10.09.06.00; Wed, 10 Feb 2021 09:06:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230245AbhBJRFT (ORCPT + 99 others); Wed, 10 Feb 2021 12:05:19 -0500 Received: from mga02.intel.com ([134.134.136.20]:56432 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbhBJRFR (ORCPT ); Wed, 10 Feb 2021 12:05:17 -0500 IronPort-SDR: kcIJxSSWbROliXwDaDrk3Aq4jOvnSoA/ZIpNhN9+PsumTExoXzrYgnf9GCpgb6fuPCg/CMFetC 8spyDaR4DgMQ== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="169237408" X-IronPort-AV: E=Sophos;i="5.81,168,1610438400"; d="scan'208";a="169237408" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 09:04:02 -0800 IronPort-SDR: HxNZpxNQ3qg3nwq2kHejEo/ncl/66S8VQBIO5yDxjf9tyzYx3jacQ7VwtkZXn+sQc+D6qeKSy9 cgAXbTMBmNQA== X-IronPort-AV: E=Sophos;i="5.81,168,1610438400"; d="scan'208";a="420603585" Received: from iweiny-desk2.sc.intel.com (HELO localhost) ([10.3.52.147]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 09:04:01 -0800 Date: Wed, 10 Feb 2021 09:04:01 -0800 From: Ira Weiny To: Christoph Hellwig Cc: Andrew Morton , David Sterba , Matthew Wilcox , clm@fb.com, josef@toxicpanda.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls Message-ID: <20210210170401.GE3014244@iweiny-DESK2.sc.intel.com> References: <20210210062221.3023586-1-ira.weiny@intel.com> <20210210062221.3023586-5-ira.weiny@intel.com> <20210210125502.GD2111784@infradead.org> <20210210162901.GB3014244@iweiny-DESK2.sc.intel.com> <20210210164134.GA2169678@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210164134.GA2169678@infradead.org> User-Agent: Mutt/1.11.1 (2018-12-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 04:41:34PM +0000, Christoph Hellwig wrote: > On Wed, Feb 10, 2021 at 08:29:01AM -0800, Ira Weiny wrote: > > On Wed, Feb 10, 2021 at 12:55:02PM +0000, Christoph Hellwig wrote: > > > On Tue, Feb 09, 2021 at 10:22:17PM -0800, ira.weiny@intel.com wrote: > > > > From: Ira Weiny > > > > > > > > Add VM_BUG_ON bounds checks to ensure the newly lifted and created page > > > > memory operations do not result in corrupted data in neighbor pages and > > > > to make them consistent with zero_user().[1][2] > > > > > > s/VM_BUG_ON/BUG_ON/g ? > > > > Andrew wanted VM_BUG_ON.[1] > > I don't care either way, but the patch uses BUG_ON, so the description > should match. Oh man... I changed the commit message after spliting the patch and forgot to change the code... Thanks, Ira