Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1481417pxb; Wed, 10 Feb 2021 09:15:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3Np/AeWd3esT5ES1MWMzSJKZzXUwfmNu4nFLFoWTLU0hE5pdrNgpP4VawN1NTYyHSgk4t X-Received: by 2002:a17:906:384c:: with SMTP id w12mr3990608ejc.140.1612977355340; Wed, 10 Feb 2021 09:15:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612977355; cv=none; d=google.com; s=arc-20160816; b=oZ16A8ulnnl5QHxiulHurrWEoFBj6Nw4IBc5/+pSccGoGshTdVTYroDvtG5RHv37xl gcAG+td1rNfVA4TfcTVMipVTJzGIG+ZvJt2zSG/RJNOo850j4l8M+Wsg3JXPXy15d5zY 9kn3+lzr4NkVaGB+teqARhgfcUZOkkopaMD7ihAiljpUyooF73Qz3LNtonAEBAD2zIWY uJVKeWtQac0zdbSSaU1Ld3ua+PWZfsjuSBpAgI4wLM2x1N9efcA9Lt+QFQfqZW9kuGMI O/xPdDVZPz9HRGEmLBTgfGIQTTdW8V8LUfa1/vwa/TTWIxczsRihap1ANNzi3Q8N4OhC 4WQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=MynKB3zDxo9w9UYnw53HrNYGxhUpC6ssOT3SyYd0CAw=; b=GQhWWiSs7fUul+L0KhN2pB63N6mDQLvVK/9LnG6VGa6uqGwrhLDTWVMxUS95huhNFj vhCfkaj5zLEtQzHOcXYPXiEe3ILLVcpGXpAf6U5Co1OyLvlcKoDXOZCLdy3ct6vBwcxI FjYKQ4Sps3iFU963euRAQ2g1Y61Urr0yo95AoMExIWr8krmkjVjsGeJnl82XgYN4Y+Oe YK665FGgEVDUy+SZb7qotU6xdjIH9EDYWx892nSkRzM63EVGL1V5QOTHOYx67cU9ix+j kdtQA54xTdvOrCUKLgP5/M5IcLzbH6jfSunoYKNRRt35uTbyzm0T/w3s5Q8l8SfvwDJ6 vVWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eYr8ih6o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ji19si1745399ejc.358.2021.02.10.09.15.31; Wed, 10 Feb 2021 09:15:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=eYr8ih6o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232342AbhBJRNR (ORCPT + 99 others); Wed, 10 Feb 2021 12:13:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232286AbhBJRMR (ORCPT ); Wed, 10 Feb 2021 12:12:17 -0500 Received: from mail-pf1-x433.google.com (mail-pf1-x433.google.com [IPv6:2607:f8b0:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38848C0617AB for ; Wed, 10 Feb 2021 09:11:01 -0800 (PST) Received: by mail-pf1-x433.google.com with SMTP id q20so1667425pfu.8 for ; Wed, 10 Feb 2021 09:11:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MynKB3zDxo9w9UYnw53HrNYGxhUpC6ssOT3SyYd0CAw=; b=eYr8ih6o7frG1XMugs8uK4ByheSMHVR7LYRs7DXFJXZBzgdn3ltV+2NCmCvv6lGqYZ 1WU+vkGNp9J02UFmdpuS9qPlGswJO3STHx2Nit5AZJHSa3s1RBLoAwCSRaIY8O1JBOcd 3D6vrgUxvEDDiCjLyU42/Bxdeqkibq3vA3oeI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MynKB3zDxo9w9UYnw53HrNYGxhUpC6ssOT3SyYd0CAw=; b=CmSdiTqRf+ZfKO11ZXTqccOrQ4r7FlVF9twojB/qfoi2IWXacj8e7lreiJ4Q+YLd7y jru8QraSyIwHABfo2G0Q8dMEH0clcn2n74l38yoBQHtRNasUUBNaRTQypUcwVMlhAqrM +SNtBSPNOxLo5RsXzc55NRoGQCV7bgOYW3DgeBbVrdFXOuPgqZRjVbzYYOhOS9DrbrF6 PHh3cRo43hnDdCdj1OZLwGbWluIL3xBfZrCMhUFTFi6jKBodjJ2xzYoG4+UOeyKeDa3H XGX6YzkVb5D6fnCMIVFzbP+/5XhzaQ3jVURLmMIkYSiYgVGVyVnckBdmCo14sxhQrttB +Mxw== X-Gm-Message-State: AOAM53376NiLTac42+/9JPfQC1X10dSDKZVhhkYcDcPZ/qmFxV5gcV5w rVkyYygA4mZttIfmFU4AirGKdQ== X-Received: by 2002:aa7:80ca:0:b029:1c1:b636:ecc2 with SMTP id a10-20020aa780ca0000b02901c1b636ecc2mr4160844pfn.20.1612977060750; Wed, 10 Feb 2021 09:11:00 -0800 (PST) Received: from localhost ([2620:15c:202:1:d8e6:826a:fc50:2158]) by smtp.gmail.com with UTF8SMTPSA id f3sm2977494pgh.75.2021.02.10.09.10.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Feb 2021 09:10:58 -0800 (PST) From: Matthias Kaehlcke To: Greg Kroah-Hartman , Rob Herring , Frank Rowand Cc: devicetree@vger.kernel.org, Peter Chen , Stephen Boyd , Alan Stern , Ravi Chandra Sadineni , Bastien Nocera , linux-kernel@vger.kernel.org, Douglas Anderson , linux-usb@vger.kernel.org, Krzysztof Kozlowski , Matthias Kaehlcke , Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org Subject: [PATCH v5 4/4] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Date: Wed, 10 Feb 2021 09:10:39 -0800 Message-Id: <20210210091015.v5.4.Ie0d2c1214b767bb5551dd4cad38398bd40e4466f@changeid> X-Mailer: git-send-email 2.30.0.478.g8a0d178c01-goog In-Reply-To: <20210210171040.684659-1-mka@chromium.org> References: <20210210171040.684659-1-mka@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add nodes for the onboard USB hub on trogdor devices. Remove the 'always-on' and 'boot-on' properties from the hub regulator, since the regulator is now managed by the onboard_usb_hub driver. Signed-off-by: Matthias Kaehlcke --- Changes in v5: - patch added to the series .../boot/dts/qcom/sc7180-trogdor-lazor-r0.dts | 15 ++++----------- .../boot/dts/qcom/sc7180-trogdor-lazor-r1.dts | 11 ++--------- arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts | 15 ++++----------- arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi | 18 +++++++++++++++--- 4 files changed, 25 insertions(+), 34 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts index 30e3e769d2b4..a557c269b998 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r0.dts @@ -14,17 +14,6 @@ / { compatible = "google,lazor-rev0", "qcom,sc7180"; }; -&pp3300_hub { - /* pp3300_l7c is used to power the USB hub */ - /delete-property/regulator-always-on; - /delete-property/regulator-boot-on; -}; - -&pp3300_l7c { - regulator-always-on; - regulator-boot-on; -}; - &sn65dsi86_out { /* * Lane 0 was incorrectly mapped on the cable, but we've now decided @@ -33,3 +22,7 @@ &sn65dsi86_out { */ lane-polarities = <1 0>; }; + +&usb_hub_2_0 { + vdd-supply = <&pp3300_l7c>; +}; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts index c2ef06367baf..d182b7a231f4 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor-r1.dts @@ -14,13 +14,6 @@ / { compatible = "google,lazor-rev1", "google,lazor-rev2", "qcom,sc7180"; }; -&pp3300_hub { - /* pp3300_l7c is used to power the USB hub */ - /delete-property/regulator-always-on; - /delete-property/regulator-boot-on; -}; - -&pp3300_l7c { - regulator-always-on; - regulator-boot-on; +&usb_hub_2_0 { + vdd-supply = <&pp3300_l7c>; }; diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts index 2cb522d6962e..699e7815697a 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-r1.dts @@ -53,21 +53,14 @@ ap_ts: touchscreen@10 { }; }; -&pp3300_hub { - /* pp3300_l7c is used to power the USB hub */ - /delete-property/regulator-always-on; - /delete-property/regulator-boot-on; -}; - -&pp3300_l7c { - regulator-always-on; - regulator-boot-on; -}; - &sdhc_2 { status = "okay"; }; +&usb_hub_2_0 { + vdd-supply = <&pp3300_l7c>; +}; + /* PINCTRL - board-specific pinctrl */ &tlmm { diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi index 8ed7dd39f6e3..9add00cc32a5 100644 --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi @@ -203,9 +203,6 @@ pp3300_hub: pp3300-hub { pinctrl-names = "default"; pinctrl-0 = <&en_pp3300_hub>; - regulator-always-on; - regulator-boot-on; - vin-supply = <&pp3300_a>; }; @@ -894,6 +891,21 @@ &usb_1 { &usb_1_dwc3 { dr_mode = "host"; + #address-cells = <1>; + #size-cells = <0>; + + /* 2.0 hub on port 1 */ + usb_hub_2_0: hub@1 { + compatible = "usbbda,5411"; + reg = <1>; + vdd-supply = <&pp3300_hub>; + }; + + /* 3.0 hub on port 2 */ + usb_hub_3_0: hub@2 { + compatible = "usbbda,411"; + reg = <2>; + }; }; &usb_1_hsphy { -- 2.30.0.478.g8a0d178c01-goog