Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1751391AbWIWSLF@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751391AbWIWSLF (ORCPT <rfc822;willy@w.ods.org>);
	Sat, 23 Sep 2006 14:11:05 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751393AbWIWSLF
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Sat, 23 Sep 2006 14:11:05 -0400
Received: from mx1.redhat.com ([66.187.233.31]:57000 "EHLO mx1.redhat.com")
	by vger.kernel.org with ESMTP id S1751391AbWIWSLC (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sat, 23 Sep 2006 14:11:02 -0400
Date: Sat, 23 Sep 2006 14:10:58 -0400
From: Dave Jones <davej@redhat.com>
To: =?utf-8?B?Uy7Dh2HEn2xhcg==?= Onur <caglar@pardus.org.tr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG] warning at kernel/cpu.c:38/lock_cpu_hotplug()
Message-ID: <20060923181058.GA23071@redhat.com>
Mail-Followup-To: Dave Jones <davej@redhat.com>,
	=?utf-8?B?Uy7Dh2HEn2xhcg==?= Onur <caglar@pardus.org.tr>,
	linux-kernel@vger.kernel.org
References: <200609230145.21997.caglar@pardus.org.tr> <20060922231342.GA8414@redhat.com> <200609231236.40547.caglar@pardus.org.tr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <200609231236.40547.caglar@pardus.org.tr>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1599
Lines: 38

On Sat, Sep 23, 2006 at 12:36:34PM +0300, S.Çağlar Onur wrote:
 > 23 Eyl 2006 Cts 02:13 tarihinde, Dave Jones şunları yazmıştı: 
 > > On Sat, Sep 23, 2006 at 01:45:16AM +0300, S.Çağlar Onur wrote:
 > >  > Hi;
 > >  >
 > >  > With kernel-2.6.18, "modprobe cpufreq_stats" always (i can reproduce)
 > >  > gaves following;
 > >  >
 > >  > ...
 > >  > Lukewarm IQ detected in hotplug locking
 > >  > BUG: warning at kernel/cpu.c:38/lock_cpu_hotplug()
 > >  >  [<b0134a42>] lock_cpu_hotplug+0x42/0x65
 > >  >  [<b02f8af1>] cpufreq_update_policy+0x25/0xad
 > >  >  [<b0358756>] kprobe_flush_task+0x18/0x40
 > >  >  [<b0355aab>] schedule+0x63f/0x68b
 > >  >  [<b01377c2>] __link_module+0x0/0x1f
 > >  >  [<b0119e7d>] __cond_resched+0x16/0x34
 > >  >  [<b03560bf>] cond_resched+0x26/0x31
 > >  >  [<b0355b0e>] wait_for_completion+0x17/0xb1
 > >  >  [<f965c547>] cpufreq_stat_cpu_callback+0x13/0x20 [cpufreq_stats]
 > >  >  [<f9670074>] cpufreq_stats_init+0x74/0x8b [cpufreq_stats]
 > >  >  [<b0137872>] sys_init_module+0x91/0x174
 > >  >  [<b0102c81>] sysenter_past_esp+0x56/0x79
 > >
 > > This should do the trick.
 > > I'll merge the same patch into cpufreq.git
 > 
 > What about cpufreq_stats_exit, it has same locking? Seems like rmmod may cause 
 > same problem or im totaly wrong?

The CPU_DEAD notifier doesn't take the lock, so it's safe.

	Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/