Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Minchan Kim <minchan.kim@gmail.com>
Date:   Wed, 10 Feb 2021 09:41:26 -0800
From:   Minchan Kim <minchan@kernel.org>
To:     Suren Baghdasaryan <surenb@google.com>
Cc:     Sumit Semwal <sumit.semwal@linaro.org>,
        John Stultz <john.stultz@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Hridya Valsaraju <hridya@google.com>,
        John Dias <joaodias@google.com>
Subject: Re: [PATCH] dma-buf: system_heap: do not warn for costly allocation
Message-ID: <YCQaxiaiJ8Ps8IkB@google.com>
References: <20210210162632.3903128-1-minchan@kernel.org>
 <CAJuCfpER=nbfY93CPf3Lz+bJcvAN8Vuqy6ZWZg12HnRGvznm+A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJuCfpER=nbfY93CPf3Lz+bJcvAN8Vuqy6ZWZg12HnRGvznm+A@mail.gmail.com>
Precedence: bulk

On Wed, Feb 10, 2021 at 09:24:52AM -0800, Suren Baghdasaryan wrote:
> The code looks fine to me. Description needs a bit polishing :)
> 
> On Wed, Feb 10, 2021 at 8:26 AM Minchan Kim <minchan@kernel.org> wrote:
> >
> > Linux VM is not hard to support PAGE_ALLOC_COSTLY_ODER allocation
> > so normally expects driver passes __GFP_NOWARN in that case
> > if they has fallback options.
> >
> > system_heap in dmabuf is the case so do not flood into demsg
> > with the warning for recording more precious information logs.
> > (below is ION warning example I got but dmabuf system heap is
> > nothing different).
> 
> Suggestion:
> Dmabuf system_heap allocation logic starts with the highest necessary
> allocation order before falling back to lower orders. The requested
> order can be higher than PAGE_ALLOC_COSTLY_ODER and failures to
> allocate will flood dmesg with warnings. Such high-order allocations
> are not unexpected and are handled by the system_heap's allocation
> fallback mechanism.
> Prevent these warnings when allocating higher than
> PAGE_ALLOC_COSTLY_ODER pages using __GFP_NOWARN flag.
> 
> Below is ION warning example I got but dmabuf system heap is nothing different:

I will take it.
Thanks, Suren!