Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1520466pxb; Wed, 10 Feb 2021 10:10:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzXPgI+gWSt+h4QGi4Sv+hMd4n54oSGySddwAa0rzhSRziSe1id/ANIDNUkWlKgq2+ZAkDd X-Received: by 2002:a17:906:1613:: with SMTP id m19mr4213068ejd.344.1612980606584; Wed, 10 Feb 2021 10:10:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612980606; cv=none; d=google.com; s=arc-20160816; b=YZByhTdypkUvduLiExKV+JTN0ZRyXDZ6hYQIlcpj710RMr+xQFoKh5GbRIvWhPX8a5 FcvkQYEwrZOzBH69fdpX1QVEQNdXzGyXZSLX46onO+77qtNQ1TJmefu7OZ1DjciqmHnJ qelHEIIRPWmlcEVwxRvYdHpE52kAqZQhwXANkZFfmEo/2oaIViD+9ur9f4vuua4Pi0Jw O+6Ub702OucAMQa5Qacns6sbPA49qzlXUzLu4Po2ZAOsmg69vgvWDfMq2ItONfxcjXaA HEi/33a/SVaoCSOAQWTJXX1kdp4woGn8emjcECVqLdKC7HcA1ys+MO4xEliwsJavn3E9 38BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:dkim-signature:dkim-signature:from; bh=VVaz0IfL2E09co0Q9gha9+MbY3zsBtFKkJzzyGGZ4ck=; b=PP+0llBWCICrrHchftjZeoHSHHLjFc2jsjrDDdxe7GcQ4/L6vGA0T7z8Y2r1xtoM/A OZ7nQnblEV+B2rVD5cVwReO8eSJvQMY67iUoGd0EKKJAgbAduzURuV4KOV09dJYezozq h6EtR85JpukZ5memEcbKadnOdpod0M9my83SXBKfWMxvhVm11TzNkTWqroc/tn/0JnaY 98obyvVohJtfXErZ8czKG3C6l1OM6lHkusBQCokmAOEYaMa0K/MtllDfBi9pXMX1o2Rw jyMDUSKf2Dgy2a5RQ8yIOtoJv31oV8tdzFW/deiDBOiZJaa/wIMocwm2fbZ24SO3e6cq BIyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=lnXI4mqt; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i26si1712766edu.267.2021.02.10.10.09.42; Wed, 10 Feb 2021 10:10:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linutronix.de header.s=2020 header.b=lnXI4mqt; dkim=neutral (no key) header.i=@linutronix.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=linutronix.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233326AbhBJSGj (ORCPT + 99 others); Wed, 10 Feb 2021 13:06:39 -0500 Received: from Galois.linutronix.de ([193.142.43.55]:33286 "EHLO galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231596AbhBJSAt (ORCPT ); Wed, 10 Feb 2021 13:00:49 -0500 From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1612980007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VVaz0IfL2E09co0Q9gha9+MbY3zsBtFKkJzzyGGZ4ck=; b=lnXI4mqtiZKe/PSZaFirN123iMcJeSpQSmS1r1VGQkTwJK/fbz82IxKWOc5N909VzZM4m0 Gtz/PXavtRcv4K8eiEjOePEoXo+M5tLdSOMrL8rzeTAaUGgJniGiwPTnE8DKhd6fOP07qD vZvqILfxKYwZOcU4EiSybtrwrwUKhK77V0DZx5ce/hWQN3Yscg3R6cOtDgBqhavuKe/jx8 P2p1h9UHUOI9QfPpPqKTPlYY2gYRmhXf0tw/nG9i0FSAEbWFhecZLQXbV6QeO83OvX4GNy v5qTDJ6cXOx3NlXFVXw57t8mgGb4vdw5vnlR8wd0rc50sGFyVHVvfnbC6BLBHQ== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1612980007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VVaz0IfL2E09co0Q9gha9+MbY3zsBtFKkJzzyGGZ4ck=; b=kQcVkkEjzNJpDvt/R9ad5yAjImmeSy0oKKM+gUWAWnsbln6aWlAnTas+pku3swqwKJZjsY SZrQWzaLdkW6vMCA== To: Sergey Senozhatsky Cc: Petr Mladek , Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , linux-kernel@vger.kernel.org, "J. Avila" , Oliver Sang Subject: Re: [PATCH] printk: avoid prb_first_valid_seq() where possible In-Reply-To: <87ft26oqya.fsf@jogness.linutronix.de> References: <20210205141728.18117-1-john.ogness@linutronix.de> <87ft26oqya.fsf@jogness.linutronix.de> Date: Wed, 10 Feb 2021 19:06:07 +0106 Message-ID: <877dnf4xco.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-02-08, Sergey Senozhatsky wrote: >> Can we please also ask the kernel test robot to test this patch? Oliver Sang from LKP was able to verify that the RCU stall problem is not seen anymore on their side. See his response below. Thanks Oliver! John Ogness On 2021-02-10, Oliver Sang wrote: > On Mon, Feb 08, 2021 at 10:35:27AM +0106, John Ogness wrote: >> Hello LKP Project, >> >> Thank you for your valuable and excellent work! >> >> You recently detected a problem: >> >> https://lists.01.org/hyperkitty/list/lkp@lists.01.org/thread/STZF3OODVA5KOG447JR2AJJXREWIPRXD/ >> >> We have posted a patch to fix the issue: >> >> https://lkml.kernel.org/r/20210205141728.18117-1-john.ogness@linutronix.de > > Hi John Ogness, > > by applying the patch upon below commit: > commit: b031a684bfd01d633c79d281bd0cf11c2f834ada ("printk: remove logbuf_lock writer-protection of ringbuffer") > > we didn't reproduce the previous INFO:rcu_tasks_detected_stalls_on_tasks > issue in 30 runs: > > b031a684bfd01d63: ("printk: remove logbuf_lock writer-protection of ringbuffer") > 7e926a042bfad8b7: ("printk: avoid prb_first_valid_seq() where possible") > > b031a684bfd01d63 7e926a042bfad8b7334b4677d3 > ---------------- -------------------------- > fail:runs %reproduction fail:runs > | | | > 10:21 -48% :30 dmesg.INFO:rcu_tasks_detected_stalls_on_tasks > 19:21 -90% :30 last_state.is_incomplete_run > 1:21 -5% :30 last_state.post_run > > >> >> Using a local lkp installation I can verify the problem is fixed. But we >> would like to know if there possibilities to verify fixes using the LKP >> test robot? Or is there any way to check that the test robot sees the >> problem is fixed? >> >> Thanks. >> >> John Ogness