Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1581853pxb; Wed, 10 Feb 2021 11:40:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJw9PDX85XOMxISm64MxCLnGH0TQM8pDEibjWpNmV7hb2X14GERJR8vq47L1AzgI0pUl/TC1 X-Received: by 2002:a17:906:b890:: with SMTP id hb16mr4472332ejb.420.1612986023837; Wed, 10 Feb 2021 11:40:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612986023; cv=none; d=google.com; s=arc-20160816; b=om/uWpBz8cIib4HsJUe3eHgjK8DDNdlLEOcYE+WfPmxKZ0OItN3WHcgZESD2z7YBNn 6TFSHy52gVpG0q3a+QiCmocI3xAxP6IWWgYoAYb16/Ej7TQhyhHKrvyN4pPUQCx/fAS2 Z9POF+QwQYAJXXK9bI46dNdaUevTXkzKK8yuwXYX7KMyhOAA3CUSLt9ec0fAyxFCnyJ5 GPVbfdDHlEr9koImpIDBZ302e+rZqy2y54qmKjt+QVIzVsBJ2lxE0N3Xvyv4nbeDP+A2 TLmrhCuMjXq+r6RtBc1YphSEQrbycXy2a0YY17RVXCjn7cPQgF18Os/PChyXYATsgSFm dfSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :mime-version:user-agent:date:message-id:cc:to:subject:from :dkim-signature; bh=phH8kE+wZBsFBWPgB0qEMRbDfOM0sUU704BhMyO7+Xk=; b=a9LGJI5bP2KrL2kQvxynE8qzG0Q6iW+dHMMmttbmOo5Q9182P7XsTs8eGJPcb5MvdF VZwm63YpaCjLvDSj9GSxr4OMHXctY/iC/cAt3NOsGHLgw1BZG56iFevSCdtpAKkfpz5R UoOnOlBX/kYOsocb8igdWWqofpG5UmzkmS7MmTTH+bvf6/5Hy6ebLfMKWmCuUVg19on+ aq51XtXM1tufLDnHU6COhBJbYcv73WddsLI5jxRIiXH3tggga/HpTGF0Fr77LZDwFZFX /8QN+qMyYC+gO9Ax8XLgsTE3grHllA3q2o2dSZKjr+/mYNLrV82VudNlq8ut9CSkkP4l PgjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@codeweavers.com header.s=6377696661 header.b=lU9YPHuv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codeweavers.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o18si2042590edq.587.2021.02.10.11.40.00; Wed, 10 Feb 2021 11:40:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@codeweavers.com header.s=6377696661 header.b=lU9YPHuv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=codeweavers.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233321AbhBJThx (ORCPT + 99 others); Wed, 10 Feb 2021 14:37:53 -0500 Received: from mail.codeweavers.com ([50.203.203.244]:43302 "EHLO mail.codeweavers.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232883AbhBJTfx (ORCPT ); Wed, 10 Feb 2021 14:35:53 -0500 X-Greylist: delayed 1052 seconds by postgrey-1.27 at vger.kernel.org; Wed, 10 Feb 2021 14:35:52 EST DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=6377696661; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Date:Message-ID:Cc:To:Subject:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=phH8kE+wZBsFBWPgB0qEMRbDfOM0sUU704BhMyO7+Xk=; b=lU9YPHuvG7PB6fbwU3Ioi7Tqjz i56W/Z0w2qAEsDPoclsSG56IS8it+SjtfYQWYAErPgZty0f60w79OVqHkTb+RQGBGz+8hP99zdaFn S0+TnI9Co/Br7uogpy13DpxBwE0ZLwp+d2nSM0F5ug2wWIwEF/LjCZ0fBrIeydutl1Lc=; Received: from [10.69.141.136] by mail.codeweavers.com with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1l9uzo-0005ck-DS; Wed, 10 Feb 2021 13:17:54 -0600 From: Nicholas Fraser Subject: [PATCH 3/4] perf archive: Fix filtering of empty build-ids To: Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , "Frank Ch. Eigler" , Song Liu , Adrian Hunter , Kim Phillips , Tommi Rantala , Remi Bernon , linux-kernel@vger.kernel.org Cc: Ulrich Czekalla , Huw Davies Message-ID: <7708cca1-b8f6-c394-75f1-5f9681d625d0@codeweavers.com> Date: Wed, 10 Feb 2021 14:17:49 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -40.5 X-Spam-Report: Spam detection software, running on the system "mail.codeweavers.com", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: A non-existent build-id used to be treated as all-zero SHA-1 hash. Build-ids are now variable width. A non-existent build-id is an empty string and "perf buildid-list" pads this with spaces. This fixes "perf-archive" to skip missing build-ids by skipping lines that start with a padding space rather than with zeroes. Content analysis details: (-40.5 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 USER_IN_WELCOMELIST user is listed in 'welcomelist_from' -20 USER_IN_WHITELIST DEPRECATED: See USER_IN_WELCOMELIST -20 ALL_TRUSTED Passed through trusted hosts only via SMTP -0.5 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.0 AWL AWL: Adjusted score from AWL reputation of From: address Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org A non-existent build-id used to be treated as all-zero SHA-1 hash. Build-ids are now variable width. A non-existent build-id is an empty string and "perf buildid-list" pads this with spaces. This fixes "perf-archive" to skip missing build-ids by skipping lines that start with a padding space rather than with zeroes. Signed-off-by: Nicholas Fraser --- tools/perf/perf-archive.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/perf-archive.sh b/tools/perf/perf-archive.sh index 0cfb3e2cefef..133f0eddbcc4 100644 --- a/tools/perf/perf-archive.sh +++ b/tools/perf/perf-archive.sh @@ -20,9 +20,8 @@ else fi BUILDIDS=$(mktemp /tmp/perf-archive-buildids.XXXXXX) -NOBUILDID=0000000000000000000000000000000000000000 -perf buildid-list -i $PERF_DATA --with-hits | grep -v "^$NOBUILDID " > $BUILDIDS +perf buildid-list -i $PERF_DATA --with-hits | grep -v "^ " > $BUILDIDS if [ ! -s $BUILDIDS ] ; then echo "perf archive: no build-ids found" rm $BUILDIDS || true -- 2.30.0