Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 10 Feb 2021 11:50:42 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Hariprasad Kelam <hkelam@marvell.com>
Cc:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "willemdebruijn.kernel@gmail.com" <willemdebruijn.kernel@gmail.com>,
        "andrew@lunn.ch" <andrew@lunn.ch>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        "Geethasowjanya Akula" <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [Patch v4 net-next 0/7] ethtool support for fec and link
 configuration
Message-ID: <20210210115042.77c40c09@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <MWHPR18MB1421079657254DAD7B37000ADE8D9@MWHPR18MB1421.namprd18.prod.outlook.com>
References: <MWHPR18MB1421079657254DAD7B37000ADE8D9@MWHPR18MB1421.namprd18.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 10 Feb 2021 17:06:29 +0000 Hariprasad Kelam wrote:
> > On Tue, 9 Feb 2021 16:05:24 +0530 Hariprasad Kelam wrote:  
> > > v4:
> > > 	- Corrected indentation issues
> > > 	- Use FEC_OFF if user requests for FEC_AUTO mode
> > > 	- Do not clear fec stats in case of user changes
> > > 	  fec mode
> > > 	- dont hide fec stats depending on interface mode
> > > 	  selection  
> > 
> > What about making autoneg modes symmetric between set and get?  
> 
> Get supports multi modes such that user can select one of the modes
> to advertise. For time being set only supports single mode. Do let me
> know if you want me to Add this in commit description.

You use the same code for supported and advertising.
Please add a check that there is only one advertising mode 
reported so we don't have to take your word for it.

Thanks.