Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1591116pxb; Wed, 10 Feb 2021 11:55:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJxjpUzX1nj9jkDrl2ca/ZrVZMJHZpIsd6aqEMaOqJp+/ktj8duSipCBzeGig+Iv0Z6JVYSp X-Received: by 2002:a17:906:3883:: with SMTP id q3mr4590288ejd.160.1612986954038; Wed, 10 Feb 2021 11:55:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612986954; cv=none; d=google.com; s=arc-20160816; b=HAWxeOVIZyTfykpxPWXSHf7FtI6ivmX/jvp0iyNo30hnjP/UODWe6V/J0O0WslXnDU uRV+HZzKHl9LCksfDC7EGcZ6nST1kMqfNP8YEQx5VsigPylTZlSfUEvnnMtYjHDoDpGB +GfvAfDBldYF/yzlr7U4iuZNW0RXla1RXer1XAjxPd5/nWawkFTQhzlnnlSqaCc/TjhV rpEpX/L6fqZQln9koQRuVT3C33ON2hPp1upXB8HgjPcv7NwYzoiz44oDO/O/c8WU7Nri izydKaVoS4V9DLjZq8FNubrIzu94tIE0k7cMCQVXaBKugxrdrdbudtk9UK50Ym5KHLK7 amRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-language:content-transfer-encoding :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=XzS/ZJanCrIZX7p0c1TNTRFEMN1N0SuLhFmG8GhLakg=; b=qdwu2xKfPG2rfuOpzB6GOE+OS1wfys7buaCSeNeR/SQm0RGy1ye8ER2dAaLROQX64s rZKCCe32r6tJ9f4mhd7/yUL/3aT52bzZ7LS4C8T3GFIZ/OZZ+h9ZCwIq3+Ac67ldcyry nAnthOrREco3NuG8E6ZhbYOoUvOFA2Oqk2+Td7xNwRLygTfaIuAtvFtfh9L2xyX0t6dr wJqjVeS07Y7BuqwfOCylay0C78wBwRm/geUMgjCx2XKCOm6ST/xsw4YDUvNsKEdfieHC IdBoJuJ6W9LJEJqYKm/lCLMsG1lTbyGJKFau8P/1GJO1eVysmlWzui5VinQkBmyQ+BeN 3Nhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=t19jm8m5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o26si2061192ejg.360.2021.02.10.11.55.30; Wed, 10 Feb 2021 11:55:54 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=t19jm8m5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbhBJTwg (ORCPT + 99 others); Wed, 10 Feb 2021 14:52:36 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:42844 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232053AbhBJTw0 (ORCPT ); Wed, 10 Feb 2021 14:52:26 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 11AJpWtR004088; Wed, 10 Feb 2021 13:51:32 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1612986692; bh=XzS/ZJanCrIZX7p0c1TNTRFEMN1N0SuLhFmG8GhLakg=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=t19jm8m5xtSdV1iMjU5+aOt+4B24Iwg4szin03bFWKlCmb8J3aJzq4SuEBhijneLo yezJHP1TU5ZZfRvwSS3sA9AqiGU1IB5bAEwQ8db7bVcfo3k4vxAyvS9C0RaXQexpDB mNc2l38tkUvbgHkN53XAM3jgI+hHSAChC7CZHUgg= Received: from DLEE107.ent.ti.com (dlee107.ent.ti.com [157.170.170.37]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 11AJpVF8102199 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 10 Feb 2021 13:51:31 -0600 Received: from DLEE112.ent.ti.com (157.170.170.23) by DLEE107.ent.ti.com (157.170.170.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 10 Feb 2021 13:51:31 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 10 Feb 2021 13:51:31 -0600 Received: from [10.250.39.16] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 11AJpVQM109838; Wed, 10 Feb 2021 13:51:31 -0600 Subject: Re: [EXTERNAL] Re: [PATCH 2/2] power: supply: bq25980: Moves properties from battery node To: Krzysztof Kozlowski CC: , , "linux-kernel@vger.kernel.org" References: <20210209230527.26712-1-r-rivera-matos@ti.com> <20210209230527.26712-2-r-rivera-matos@ti.com> From: Ricardo Rivera-Matos Message-ID: Date: Wed, 10 Feb 2021 13:51:31 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/10/21 2:23 AM, Krzysztof Kozlowski wrote: > On Wed, 10 Feb 2021 at 00:52, Ricardo Rivera-Matos > wrote: >> fix: exposes POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT on the >> >> charger node > Why is this a fix? Why is exposing this property wrong? What is the > problem here? Why do you start sentences with a small letter? Your > commit message should answer such questions. ACK, I will rebase and reword this commit message > > Best regards, > Krzysztof Best Regards, Ricardo