Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: LUQnrxFF90Ccit3/4s8Yne5ZJZxS7MVzoo5rxwSEBr+9VurlqCc0/9qGs0b+RI9QCCLAwpU0XE
 JCKSmRXbwgmw==
IronPort-SDR: lfrxqcEe4qvK2F9xrVIUg5SgwA6wit7M6Xgz98/oT3Fah64JTxbj6tKKPv0iOV1pfP/FvwJha4
 JjfuD5G3DL9w==
Date:   Wed, 10 Feb 2021 22:46:15 +0200
From:   Sakari Ailus <sakari.ailus@linux.intel.com>
To:     Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        rajmohan.mani@intel.com, Tomasz Figa <tfiga@chromium.org>,
        Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>,
        Hyungwoo Yang <hyungwoo.yang@intel.com>,
        linux-media@vger.kernel.org
Subject: Re: [PATCH v10 2/7] i2c: Allow an ACPI driver to manage the device's
 power state during probe
Message-ID: <20210210204615.GC3@paasikivi.fi.intel.com>
References: <20210205132505.20173-1-sakari.ailus@linux.intel.com>
 <20210205132505.20173-3-sakari.ailus@linux.intel.com>
 <20210209210410.GA2380@kunai>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210209210410.GA2380@kunai>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

Hi Wolfram,

On Tue, Feb 09, 2021 at 10:04:10PM +0100, Wolfram Sang wrote:
> 
> > + * @I2C_DRV_FL_ALLOW_LOW_POWER_PROBE: Let the ACPI driver manage the device's
> > + *				      power state during probe and remove
> 
> Well, for the functional change, I am happy if the ACPI guys are happy.
> The only minor nit for me would be removing the "_FL" snipplet from the
> name of the define because I think it is clear enough that this is a
> flag. If you need to resend anyhow, maybe it is worth a thought. It is

I'll remove _FL for v11.

> not a big issue, so anyway:
> 
> Acked-by: Wolfram Sang <wsa@kernel.org>

Thank you!

> 
> because I assume this will go in via the ACPI tree?

I think so, yes, if no-one has objections. Most of the changes are for ACPI
framework and docs.

-- 
Kind regards,

Sakari Ailus