Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1692620pxb; Wed, 10 Feb 2021 14:32:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJyu7k6MxKm0Y385ikU1Q3SnTR/3Vh+9L//6hkNY+K0M7eC0FtjzhM/6v9k3/PVYpTd0huAw X-Received: by 2002:a17:906:5653:: with SMTP id v19mr5320375ejr.481.1612996328640; Wed, 10 Feb 2021 14:32:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612996328; cv=none; d=google.com; s=arc-20160816; b=jDyqW/XOucWDaU89CIY3j9Sy/vLokLAmgUaGoGnxsEhFEPPzydui4x+GXjTwvvOnNk EY4u+RHnL7rR/+CHAZ2M0m1i68ikQiF3+uHIICxSIJlKM569XLk6vJygI/NDoocz3zM1 moR8DKMv1r/wrWe2siyFT2p3HO7xlwaMGhxtDH+P+9qGHwbotmnikfj9QQ335ME7ri6Y mYmXtbkEF8RYGH1G71NbRz9HItRoeHqJCEs2Ewum6bjgWZxd+3rZKa4dtYC2+f7wZrnp gwz+Ae+x5A/X51cqvq1EbMho6QnhuvHTFnJjeJiSlfMFU7feCqxTBoDjkkdXWW2vYb+f vDwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:to:from:date :ironport-sdr:ironport-sdr; bh=PBBosfdhtebOWiPLrEmalt2pL6XNFXG887Ael5EmK1g=; b=udxkSNllCklSlUDSc4OIwTim3X6jJznlVXJpSFnPL+1EHgYbD4w/j+39PXHi/XKAP5 E3T//MQRVYavvClcJSo7IAr7yVE8QliE42avHdppxAghigDGqveJGms22OzI+VPWFUFX CSm95MougMDveSM6i1VEPy+x//xz4v/hbWKT9EiPkJLskGgb1r7yRL/ForDjmWdyUj55 IivX+AIyjZaaLAxGyVWs+w2FCmNXzyAULOb5nIMgOGsL6pNBOfhFqPkLNA+PcWySqsbl tAgNUUTWaR++k6qzqsYB/wyhnmzPEr3jebgsjJU5c587l0SPtOl1Taapfc1ZDkMq1k6V eqIQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn20si2458316ejc.418.2021.02.10.14.31.21; Wed, 10 Feb 2021 14:32:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233489AbhBJW3Y (ORCPT + 99 others); Wed, 10 Feb 2021 17:29:24 -0500 Received: from mga04.intel.com ([192.55.52.120]:13270 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233231AbhBJW3U (ORCPT ); Wed, 10 Feb 2021 17:29:20 -0500 IronPort-SDR: 6+RfduXYzluN3zFtHuKW2QgWX099b7aYUULdRsCK7udSE/CNPPvMpLU0WyXEJNgqBJJvwtlBAq iQjFKttJAH+g== X-IronPort-AV: E=McAfee;i="6000,8403,9891"; a="179604665" X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="179604665" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 14:27:28 -0800 IronPort-SDR: nDXiYRkUJhAiSE75pYaCXSq6Um6G1p5XlHc+q8pJ4F24vpuu2T8A/3GQth18rtFulhkgZF982K GwRnHHgiW9TQ== X-IronPort-AV: E=Sophos;i="5.81,169,1610438400"; d="scan'208";a="489084676" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2021 14:27:25 -0800 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 10BD420488; Thu, 11 Feb 2021 00:27:23 +0200 (EET) Date: Thu, 11 Feb 2021 00:27:23 +0200 From: Sakari Ailus To: Wolfram Sang , linux-i2c@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , rajmohan.mani@intel.com, Tomasz Figa , Bartosz Golaszewski , Bingbu Cao , Chiranjeevi Rapolu , Hyungwoo Yang , linux-media@vger.kernel.org Subject: Re: [PATCH v10 2/7] i2c: Allow an ACPI driver to manage the device's power state during probe Message-ID: <20210210222722.GF3@paasikivi.fi.intel.com> References: <20210205132505.20173-1-sakari.ailus@linux.intel.com> <20210205132505.20173-3-sakari.ailus@linux.intel.com> <20210209210410.GA2380@kunai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210209210410.GA2380@kunai> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 09, 2021 at 10:04:10PM +0100, Wolfram Sang wrote: > > > + * @I2C_DRV_FL_ALLOW_LOW_POWER_PROBE: Let the ACPI driver manage the device's > > + * power state during probe and remove > > Well, for the functional change, I am happy if the ACPI guys are happy. > The only minor nit for me would be removing the "_FL" snipplet from the I'm actually renaming this as I2C_DRV_ACPI_WAIVE_D0_PROBE, with similar changes to the function names. I opportunistically assume the ack holds still. :-) I'll post v11 soon. > name of the define because I think it is clear enough that this is a > flag. If you need to resend anyhow, maybe it is worth a thought. It is > not a big issue, so anyway: > > Acked-by: Wolfram Sang > > because I assume this will go in via the ACPI tree? > -- Sakari Ailus