Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: RMREcKz370w3SpE8lQCB8XOEMzU2dCsB7HLy3VBBT49mcSln6gItKu6KQ0ifWLPeceaG6yiNJ8
 CjJ9jkvzZMeg==
IronPort-SDR: VyTEMK3rM3wGmhWVpzYqyIKs6nvgYDR3EfvOaWZbl2r2TFtbQkAy/WgBp0XacCu5NH3K1G/yXh
 1j1cSilC3lYw==
Subject: Re: [PATCH v5 02/14] dmaengine: idxd: add IMS detection in base
 driver
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     alex.williamson@redhat.com, kwankhede@nvidia.com,
        tglx@linutronix.de, vkoul@kernel.org, megha.dey@intel.com,
        jacob.jun.pan@intel.com, ashok.raj@intel.com, yi.l.liu@intel.com,
        baolu.lu@intel.com, kevin.tian@intel.com, sanjay.k.kumar@intel.com,
        tony.luck@intel.com, dan.j.williams@intel.com,
        eric.auger@redhat.com, parav@mellanox.com, netanelg@mellanox.com,
        shahafs@mellanox.com, pbonzini@redhat.com,
        dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org
References: <161255810396.339900.7646244556839438765.stgit@djiang5-desk3.ch.intel.com>
 <161255838583.339900.1371114106574605023.stgit@djiang5-desk3.ch.intel.com>
 <20210210233000.GH4247@nvidia.com>
From:   Dave Jiang <dave.jiang@intel.com>
Message-ID: <412e40cc-3982-7301-661f-eb57a4a9144c@intel.com>
Date:   Wed, 10 Feb 2021 16:32:24 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210210233000.GH4247@nvidia.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2/10/2021 4:30 PM, Jason Gunthorpe wrote:
> On Fri, Feb 05, 2021 at 01:53:05PM -0700, Dave Jiang wrote:
>
>> diff --git a/drivers/dma/idxd/sysfs.c b/drivers/dma/idxd/sysfs.c
>> index 21c1e23cdf23..ab5c76e1226b 100644
>> +++ b/drivers/dma/idxd/sysfs.c
>> @@ -1444,6 +1444,14 @@ static ssize_t numa_node_show(struct device *dev,
>>   }
>>   static DEVICE_ATTR_RO(numa_node);
>>   
>> +static ssize_t ims_size_show(struct device *dev, struct device_attribute *attr, char *buf)
>> +{
>> +	struct idxd_device *idxd = container_of(dev, struct idxd_device, conf_dev);
>> +
>> +	return sprintf(buf, "%u\n", idxd->ims_size);
>> +}
> use sysfs_emit for all new sysfs functions please

Will fix. Thanks!


>
> Jason