Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1733863pxb; Wed, 10 Feb 2021 15:49:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJx2MGBSHfEMwMpx8dy+klwR9nN65oHnd67dk5Dus1wCcO2QGfA00woALnnx89ORf2bZUFgb X-Received: by 2002:a17:906:9507:: with SMTP id u7mr5539605ejx.25.1613000971839; Wed, 10 Feb 2021 15:49:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613000971; cv=none; d=google.com; s=arc-20160816; b=FpNCnq2W3MurBaa8zzjlZFWaGxk70SO4V1ANPgqKqvLEDTv2StNcjgwzNVV91yTLGj Jq0X2RW3FMkWABc4hxKa/JZUMbJZGp8Ckbjos6EtQKXhh5QEPGZNREO2hLn4xE/cV2Qb F8TnnHUT9z2VwjsVbtvOqFaY0jQV/FYoqkTb0AIdNLjRWXQ5qTOjYTqE52QsdIbYluBe lzqfIA4jKN/dZprbTwuYzhDNYPllvLCelBa0dts2lKrQOm8Js/aT8IP2N3unyExgyHiB pcOVFGN6fwypRFWrGiIHUSVl5lOiE3p/lPhqGn/OZO7G8z5n5Bt+0khJWZTdG4s1NkON UqPQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=vM//4U9/+YKnq/E5n2pFW1Akp/52mAADNYiWm65AElA=; b=0ZwBnYCgAy+2b7fky1ZEOP918u8jnsZHn+lT4/PmHgMtHF/TfRz3HnAmujtTpCNehJ ZgEwKN7BfItw3K4rtv8LdCznJl7OCU4hYBcMfzvlgw4zCvzDyBZ/TRqai20V+cQifKpw 9TNN82e/qorbIBE6rsimZwxsGzlqE310K2aB+VGN9PUiw1AxHCqQnDnRGNLWS0VACt+B 2pGrC+8W0SfGA7wxzlYGt3lBcHAkBxmrOZ+hSAy7uNy/hQkJ8VL1ID2E4NHkx/h6BRv/ +5SkNjB4EnLewEz71xAqQB3WHcQLcL4NVjqry6sigu/haQ+Y+WbIGk9Mvvyj2J32lfjp AeDQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@anholt-net.20150623.gappssmtp.com header.s=20150623 header.b=iLbknNn8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qp24si2513075ejb.531.2021.02.10.15.48.38; Wed, 10 Feb 2021 15:49:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@anholt-net.20150623.gappssmtp.com header.s=20150623 header.b=iLbknNn8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233903AbhBJXlr (ORCPT + 99 others); Wed, 10 Feb 2021 18:41:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233886AbhBJXln (ORCPT ); Wed, 10 Feb 2021 18:41:43 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8AE9FC06174A for ; Wed, 10 Feb 2021 15:41:02 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id z22so5045842edb.9 for ; Wed, 10 Feb 2021 15:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=vM//4U9/+YKnq/E5n2pFW1Akp/52mAADNYiWm65AElA=; b=iLbknNn8g5cXQ9Y5WEZB/SuN/D7M44YoydiXZwO90Ea603ZhkZk+X2DhxR2l/7Ou7W O9lbiJXseLd5lHzZXZXHBHf3rC5nAkVCv1/mhuxcvVL6B9jzWe6McyoFHB7NwMfZ6jLj FQWDrTow6HC7XADzkQz+NStxb4/OrSKj+PUp3/S3HR+wpZoP2TFcqoA1fcK1/iykCQOf IlV8wPg5jqpMj3TwEcTnxIoQZ9cF2eLGIo0/0zTnuZb/HKNUzwQlBxqw3m6ZB4w9QjQs bdV7YGO0n0NsfBuyAvU/hJvlACy90vZ5b+xRW3YcJapCxclEQaRVwLbB1BgqIa2NT9Qr kAqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=vM//4U9/+YKnq/E5n2pFW1Akp/52mAADNYiWm65AElA=; b=dsCKO+1Zdgesgp/wlYQBdPNj+oXxGKOWXxl2e2JuR1lfhbiVEEKNttT3RoWvnf9Pmg j6mYgcTMFFm1GjG+cbkpEEOnX6q5MEqGT9AqaqjWBnWMXZR4zywygklFinIcIIY0zdGN /QL0Nfo9SmpW5Zu1pcKHw1z/nbFH1zXkBd1i75k3Z9eSh57AK2c0oFNl/B+tVsYKi4zi jUcfkJx9vREcqoxzmmXMRk1vmaYHKPjg+bpKRFmwZFoVkyUEyeBYqldrX37GIfVVy7WB +XcdUyVm/6JjKh0Z+hkYu1+Qq2a4hvPND0iEFQBJHXYK8JB2u90vG2fnQ3p341ckioSk 0T+g== X-Gm-Message-State: AOAM530mdc/MqYSheWojl4bY6q100DMeGktlc7rB+yR2Il2N/zyRtezu yAtIahkMe5ZzhpECdR7qxck0xIc+t1ZrFu+BxAAowNCjCuQrYw== X-Received: by 2002:a50:fe11:: with SMTP id f17mr5530428edt.88.1613000461311; Wed, 10 Feb 2021 15:41:01 -0800 (PST) MIME-Version: 1.0 References: <20210208185557.15703-1-jonathan@marek.ca> <20210210012450.GA26503@jcrouse1-lnx.qualcomm.com> In-Reply-To: <20210210012450.GA26503@jcrouse1-lnx.qualcomm.com> From: Eric Anholt Date: Wed, 10 Feb 2021 15:40:50 -0800 Message-ID: Subject: Re: [PATCH] drm/msm: fix a6xx_gmu_clear_oob To: Jonathan Marek , freedreno@lists.freedesktop.org, Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Akhil P Oommen , Eric Anholt , Sharat Masetty , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 9, 2021 at 5:24 PM Jordan Crouse wrote: > > On Mon, Feb 08, 2021 at 01:55:54PM -0500, Jonathan Marek wrote: > > The cleanup patch broke a6xx_gmu_clear_oob, fix it by adding the missing > > bitshift operation. > > > > Fixes: 555c50a4a19b ("drm/msm: Clean up GMU OOB set/clear handling") > > Signed-off-by: Jonathan Marek > > Thanks. I feel silly that I missed that. > > Reviewed-by: Jordan Crouse Yeah, oops. Reviewed-by: Eric Anholt