Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1734789pxb; Wed, 10 Feb 2021 15:51:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJwm8qqZpC+gDq1F8fPhga4A2M63U/zyFQ3lPVYhezfg4+3J+gvvWI51AyWhHDWSBgS1BzHw X-Received: by 2002:a17:906:cf89:: with SMTP id um9mr5454272ejb.189.1613001094697; Wed, 10 Feb 2021 15:51:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1613001094; cv=none; d=google.com; s=arc-20160816; b=0dPAKm1kXVOUrpxUCsI37YFAWOZeDxQ7q5RETNFuF9uEmx/LQ8MQVuNv0eIimu6tjP VQhGPHiNAAskiCQJDqehebXGAwBtH9nNS7DQEVlY4Yo/g3/yFHG/5Xky4E+3cOSTKQLt TA1rsm+nk0ShrHk3Xrf8fWA3QWeDSRit/RX3vx9QfzHpR+Lx+CCJ57dnF+8tVbmkSyBu FtV3GIi81kE+mPuFdlSEPjQvRRA8jDuLAy76wx6GOoazhAKceQsBg3eZpXGX3hc1AIcE EKxgf6Vqh0fzNV5YEU+/Xo2RdaoRdmLZRDBv04ihVZG7Tg7gbZRxkFXLIpfwxWPcMfCK 4Z4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=mYvNXLMjaAvSNaab09kpmQT1MsTwA+3hPADvnsF7kgg=; b=MWTQT9Bq+O7xxi1uHGMtOAc26mKe//zHzqQGFwsdrvVpA5jjtEGiT6p2y+gHg4xbUU CB2w3lmhugq2JYAyeVj5FUFKDyQNizFOZgMZYGagROs/cZMmvPa+IgxW7SBcVK6U/BNN I8CD59jUf+NBQu8GqtysUQi6tvIIO8kshltt0La3tZfJGXsZVTwPWD818uhZccIc/naI QnnGW0JDlP+EHccPCfdg4BcBt851hY6pB12GCxXr51OvMS55/B63jNHDR+ni3P1gyJ/c xmWONOVDVk0qLCP1xwTAEFXYw98yZ7OPSyjMUfF5cJioNrtcKJFRa9QUwC1iu7CmkIPj aY9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id qp24si2513075ejb.531.2021.02.10.15.51.08; Wed, 10 Feb 2021 15:51:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233897AbhBJXuL (ORCPT + 99 others); Wed, 10 Feb 2021 18:50:11 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:33806 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233741AbhBJXuD (ORCPT ); Wed, 10 Feb 2021 18:50:03 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l9zEX-005QVn-CO; Thu, 11 Feb 2021 00:49:21 +0100 Date: Thu, 11 Feb 2021 00:49:21 +0100 From: Andrew Lunn To: Michael Walle Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski Subject: Re: [PATCH net-next v3 6/9] net: phy: icplus: don't set APS_EN bit on IP101G Message-ID: References: <20210210210809.30125-1-michael@walle.cc> <20210210210809.30125-7-michael@walle.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210210210809.30125-7-michael@walle.cc> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 10, 2021 at 10:08:06PM +0100, Michael Walle wrote: > This bit is reserved as 'always-write-1'. While this is not a particular > error, because we are only setting it, guard it by checking the model to > prevent errors in the future. > > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew